Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count
To:     Alan Stern <stern@rowland.harvard.edu>,
        Ben Dooks <ben-linux@fluff.org>
Cc:     gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@lists.codethink.co.uk, linux-kernel@vger.kernel.org
References: <Pine.LNX.4.44L0.1811141338100.1637-100000@iolanthe.rowland.org>
From:   Ben Dooks <ben.dooks@codethink.co.uk>
Organization: Codethink Limited.
Message-ID: <39eb9e8b-2b5d-ea75-3232-be77c3743dbc@codethink.co.uk>
Date:   Fri, 16 Nov 2018 12:53:57 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <Pine.LNX.4.44L0.1811141338100.1637-100000@iolanthe.rowland.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 14/11/18 18:47, Alan Stern wrote:
> On Wed, 14 Nov 2018, Ben Dooks wrote:
> 
>> From: Ben Dooks <ben.dooks@codethink.co.uk>
>>
>> At least some systems benefit with less scheduling if the NAK count
>> value is set higher than the default 4. For instance a Tegra3 with
>> an SMSC9512 showed less interrupt load when this was changed to 14.
> 
> Interesting.  Why do you think this is?  In theory, increasing the NAK
> count RL value should cause a higher memory bus load and perhaps a
> slight rise in the interrupt load (transfers will complete a little
> more quickly because the controller tries harder to poll the endpoints
> and see if they are ready).

I thought the NAK counter was decremented until the transfer is given
up on. I'm going to have to go back and get some actual figures from
a running system as this was originally done over a year ago with the
SMSC9512 (IIRC) network driver.

>> To allow the changing of this value, add a sysfs node to each of
>> the controllers to allow run-time changing.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> 
> The patch looks okay to me.

I'll look at getting some tracing from the SMSC driver to see what
is going on.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html