Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp475999imu; Fri, 16 Nov 2018 05:34:10 -0800 (PST) X-Google-Smtp-Source: AFSGD/XXBbVT8OdIvzeZxqs5Dp9MW0ux3C5d1oPnW5tH4B+qkNbhEDoOXCHZRkp7hCMK9IJfip3r X-Received: by 2002:a17:902:1681:: with SMTP id h1mr474162plh.129.1542375250319; Fri, 16 Nov 2018 05:34:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542375250; cv=none; d=google.com; s=arc-20160816; b=clE1z9B7hReJBDJfB1mM6pyZ1mt9J3wjnZgVWZBclQZeXVKayP1TVPjNFlxfCHaRfW SI0vDPrGcwYN5YC9cay1cxE/3t55sAZdl/deQja2L9zov6CxRT8NAMzTbAZQGFCmErtH EpIUxCmtiqHf7jo3pv4OOdZXQlyyZIs5Zh/auCnpA0wKfD/6CdxS53SUv8i/YBmZiKH/ OaHktXwIL86Z51qfxGmQfJVkNKQrSDzQcySAGbfvU/4eTw4zyMEFtJ7TGzrp/A+/yFtz 2GNW3b6EpCernCHkNct581EzfZCxeB4ZY6UEaobxZ0DuTt4Ox+HcaZdgoIM7H2v1n2IM rM5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=D+I17SgpkBx0LTt83zn19GDqEvH3RwRfESf09F7mxNg=; b=p0Jy+hTx/let2kPmUAsfw1BKZ7VVPiFnhownM7YdiCBFEyKBubk7RIxncmVHm2wEaw AMgh3R1BXfZiheeKClR6AzOOK2RKjga6LiYSF0xwlMoIlO1LSalU7G1Bu3QMbZodCdbl wwG/VZORElh7u9iM+AgPbHPW7CKL1FizxX6yqJ8QsdSVzhfgJwNlfkm8vjm1G6GObAGD wiisRkcgvwCmJWeJyIgLqs6X06k4Svt16s4/PdFsduaWW6hgOT56bxns5avwvqJx65Hg g8AtC992rKM1fpteh+jTqCut1LEH2KL0O62dAmQVtj7CqhQverFMNJAlHL7gIG4c9Haf sUkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b9si29152072pgt.293.2018.11.16.05.33.55; Fri, 16 Nov 2018 05:34:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389772AbeKPXpm (ORCPT + 99 others); Fri, 16 Nov 2018 18:45:42 -0500 Received: from verein.lst.de ([213.95.11.211]:49814 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727854AbeKPXpl (ORCPT ); Fri, 16 Nov 2018 18:45:41 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 8E4AD68D60; Fri, 16 Nov 2018 14:33:14 +0100 (CET) Date: Fri, 16 Nov 2018 14:33:14 +0100 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, linux-erofs@lists.ozlabs.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , Theodore Ts'o , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg Message-ID: <20181116133314.GC3165@lst.de> References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-5-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181115085306.9910-5-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if (!*sg) > + return sglist; > + else { No need for an else after an early return.