Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp484273imu; Fri, 16 Nov 2018 05:41:34 -0800 (PST) X-Google-Smtp-Source: AJdET5fAyor39kE3JAs+6P3r4/hZF6vQ/3iPoOa85iu3siCV7QldoJeHQGSWCEzJnjkRMnt97aXx X-Received: by 2002:a63:cc43:: with SMTP id q3mr9841714pgi.291.1542375694884; Fri, 16 Nov 2018 05:41:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542375694; cv=none; d=google.com; s=arc-20160816; b=ldLKpQgcYkzzRuyayXfoTyIe9CLCQeSMYi159uDXoY/r+sAGV5pdgVuLnJcA5rJK9c p6wDMYWQo6+ksj0i5JZ1jELtTxMvbJ/diLRgnVDhtbov1ID61trw3kMxlO9xubtionaT cIEgqHBIQWGpEswFLZAOvh53ICKGcvv5e0lrb5Mlh0GLJ3tRRg3ISNNXjZ/Gp5jhDGO2 cDovZWJG/OBF75P9xJpDM16INr5QGZv0L2dH7fQ+P7zrHVLVq8fFdre+pEZS+At2y4RO NMlK0pXPXuoEYE6G60HoCEFDr0rONxAAJmXtdB7v1ANmRFLryB7EOggRD2Ee82kDt4md RVug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aqkEV0pzmHkLbL3IC2gePx0hP5VztR5LiDgBG5wNcXY=; b=yCKQzmDwEtL/P96Cn1QRIH5PjvmuTmvJM0U2o77mhWTb/lG6gvoLk021L9vNkN9eqf T0yKhGwrCeuzvA1hI5n1AxuuR/DP+6aqyMRS2zwcuR5o+ve9RXMefBtODu2pppdzOtnD X7pOD/7W0DYsc1yY/+H/lqIhrui4/+5XbtolhCkdySWfVnBoyESk1ZVAHZB96O5ubLsf +CwghEl/5DF/lbkHgK48Wt14ki9GBVd087Sqy13ElSyJfk9LsJhP2d1SiuCe278A53E3 1IMMZmUfppVhqKp/6H0sQ8vXTGKRsbbnwaIyhixVKLhWnEUsFe62oQiDhwLfQSGqPYCZ GRkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Etuyjccv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10-v6si31315316pla.138.2018.11.16.05.41.20; Fri, 16 Nov 2018 05:41:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Etuyjccv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389950AbeKPXxF (ORCPT + 99 others); Fri, 16 Nov 2018 18:53:05 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:36766 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728079AbeKPXxF (ORCPT ); Fri, 16 Nov 2018 18:53:05 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id wAGDeXcS026154; Fri, 16 Nov 2018 07:40:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1542375633; bh=aqkEV0pzmHkLbL3IC2gePx0hP5VztR5LiDgBG5wNcXY=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=EtuyjccvU9ZxOFIcQqYzwRv0Xl1GPTcfpQKs1JZjD2Q4TECoFIvnaUTjZbqLdNZkj 7LfA0k6cqJV/fWPi9aZSB/DgwUGdrY69KHsKa9xoWn55W/BIoiaAbkzG4JLpfapNKl SdZmuA7kUefdn2tLlH+ALCJqnt2jVZ54HOhn7Np4= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wAGDeXoa126332 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 16 Nov 2018 07:40:33 -0600 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 16 Nov 2018 07:40:33 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Fri, 16 Nov 2018 07:40:32 -0600 Received: from feketebors.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id wAGDeQwr005228; Fri, 16 Nov 2018 07:40:30 -0600 From: Peter Ujfalusi To: Mark Brown , Liam Girdwood CC: , , , , , Subject: [PATCH 1/4] ASoC: davinci-mcasp: Clear TXSTAT register before activating serializers Date: Fri, 16 Nov 2018 15:41:38 +0200 Message-ID: <20181116134141.17396-2-peter.ujfalusi@ti.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181116134141.17396-1-peter.ujfalusi@ti.com> References: <20181116134141.17396-1-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Follow the guideline from the TRM: Before starting, clear the respective transmitter and receiver status registers To avoid stale state stored in the status registers. Signed-off-by: Peter Ujfalusi --- sound/soc/davinci/davinci-mcasp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c index 267aee776b2d..740030b4d37a 100644 --- a/sound/soc/davinci/davinci-mcasp.c +++ b/sound/soc/davinci/davinci-mcasp.c @@ -192,6 +192,7 @@ static void mcasp_start_rx(struct davinci_mcasp *mcasp) } /* Activate serializer(s) */ + mcasp_set_reg(mcasp, DAVINCI_MCASP_RXSTAT_REG, 0xFFFFFFFF); mcasp_set_ctl_reg(mcasp, DAVINCI_MCASP_GBLCTLR_REG, RXSERCLR); /* Release RX state machine */ mcasp_set_ctl_reg(mcasp, DAVINCI_MCASP_GBLCTLR_REG, RXSMRST); @@ -220,6 +221,7 @@ static void mcasp_start_tx(struct davinci_mcasp *mcasp) mcasp_set_ctl_reg(mcasp, DAVINCI_MCASP_GBLCTLX_REG, TXHCLKRST); mcasp_set_ctl_reg(mcasp, DAVINCI_MCASP_GBLCTLX_REG, TXCLKRST); /* Activate serializer(s) */ + mcasp_set_reg(mcasp, DAVINCI_MCASP_TXSTAT_REG, 0xFFFFFFFF); mcasp_set_ctl_reg(mcasp, DAVINCI_MCASP_GBLCTLX_REG, TXSERCLR); /* wait for XDATA to be cleared */ -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki