Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp485644imu; Fri, 16 Nov 2018 05:42:54 -0800 (PST) X-Google-Smtp-Source: AJdET5dYc3zz6egJjr3tbxcCONRmSyWdlzHjxyJX/Poio6Yr6H7wRNMVkjrHdAId3bcLMMAsHHrX X-Received: by 2002:a62:89d7:: with SMTP id n84-v6mr11244780pfk.255.1542375774460; Fri, 16 Nov 2018 05:42:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542375774; cv=none; d=google.com; s=arc-20160816; b=Qiohx8pfXdSDRoYiyYOO5uftGbmMNlfIIYFuuWS/WUF6oGwX7+4h++gtDi9jBNTzm1 jhm68hSaGjELTojV5mHwu36dZ6ZGi2EHVK7ax3NSIvgqnHjklplLcnrGlO0yXUbVZAki Qy/gK4zeBE4r28ASM9rqNzn9Lb1ckRPXXG+rYciKIu2VLJAqhw+YW9e9uqDVVwBEUroH 6r++y2H0MOW3acPtSdY08iInBHJflBQHvR5KtcU/wkYF4eP5slwOdaTtDiRyjFyyrPFl 4nY0iA3fyzXEjD1oGir+VonhLiJKgy2Bf0Mv8g1UPnOjBi25LfyOnGs1BS4Z7TbmH38y XF/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=f/zUcjjjul8hpWWPpGs9Sr6mh7WhBhj+49ihXEcbSgo=; b=JVRAUcerqLp7uvSQMMJje91lHzGhMGntO1ktWkzVssZ8hV7+nd2PT/JoVAtkbJB+9d lmyMF4aT7yA0t095jIEmEvU54b075EgGc7yjGP8otXedcVoIHLJprWTur53/e0wiCAlx To7iPLxWkE80YDXiF7T4iiQGEktjKrryG8A7+8BK5OvKIwlvKxh654MvdzT5gtwkHJGL C3VjDvjVaZFWKR/3g/kpqCCRSrdolnCvsI9OAR5cxbxOY79ofAs2h6kbedOzMgtsHIen mEY+3BQf3+UsgeAIZyDpt1S01xuXbI28W8kZqxCIXrdveN9m+W+7NiE9/n91vuJG4hXG RXMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 92-v6si13254427plw.117.2018.11.16.05.42.40; Fri, 16 Nov 2018 05:42:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389774AbeKPXyZ (ORCPT + 99 others); Fri, 16 Nov 2018 18:54:25 -0500 Received: from mga02.intel.com ([134.134.136.20]:62476 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727711AbeKPXyZ (ORCPT ); Fri, 16 Nov 2018 18:54:25 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Nov 2018 05:41:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,240,1539673200"; d="scan'208";a="250265950" Received: from unknown (HELO localhost) ([10.249.254.86]) by orsmga004.jf.intel.com with ESMTP; 16 Nov 2018 05:41:54 -0800 Date: Fri, 16 Nov 2018 15:41:53 +0200 From: Jarkko Sakkinen To: Roberto Sassu Cc: zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com, stable@vger.kernel.org Subject: Re: [PATCH v5 6/7] tpm: ensure that the output of PCR read contains the correct digest size Message-ID: <20181116134153.GD4163@linux.intel.com> References: <20181114153108.12907-1-roberto.sassu@huawei.com> <20181114153108.12907-7-roberto.sassu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181114153108.12907-7-roberto.sassu@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 14, 2018 at 04:31:07PM +0100, Roberto Sassu wrote: > This patch protects against data corruption that could happen in the bus, > by checking that that the digest size returned by the TPM during a PCR read > matches the size of the algorithm passed to tpm2_pcr_read(). > > This check is performed after information about the PCR banks has been > retrieved. > > Signed-off-by: Roberto Sassu > Reviewed-by: Jarkko Sakkinen > Cc: stable@vger.kernel.org Missing fixes tag. /Jarkko