Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp492000imu;
        Fri, 16 Nov 2018 05:49:05 -0800 (PST)
X-Google-Smtp-Source: AJdET5f8OZ4MOx4CA2yinhCW77Lu8L0gjvqkIc+Ad8rNL0Ts0+nhmNipCOuevKxAhRXqJ6PnHUEH
X-Received: by 2002:a62:e30a:: with SMTP id g10-v6mr11049250pfh.151.1542376145000;
        Fri, 16 Nov 2018 05:49:05 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1542376144; cv=none;
        d=google.com; s=arc-20160816;
        b=JRPun9UzqQhMMYf2Nc1Wk/HMesTngPKEBOkrwD53TL5rslrT5xO7Dcol9IEDdCX1tB
         5wWgMiJ1JbUo39JNHczi3/5xQtlv6Cc05G6DNHa6lFxSzISnStRvVcDP11203nJhRAUe
         bhITNWsXet3UWDdCDYY1fpabv4xFW7T1hi680ptW5AR3+bRWeZYT4AecMLmBX3BNUtZj
         DKZ79LDNGxCmVNish9VehKW3DUQQhtyqSSzVJSUHUsZ2+uH5RTsT6RePwU151ZxSpN/A
         RoSW1gYikcUHL2LcFdtvs+fss++G8jZZkAcR4ntYAyTMEn8p0b/UYBMg8PLIPTfBibKj
         Jv4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=IuhsPZmMXkBTsvX1QknGREZO+d+31Tg1u5z7cQC9o0U=;
        b=hHgtFEJh9BCsWJOub8bqAQCS4VM1GoxVxAYSKJN+nbiJGWNS0DqZrgruN3xYFYJn4O
         hkfTmWXHi+IkMX0ZXsMmqdDzVrUvknsTv98l5aZu654zEfVXQFrTe7cTg0f/k4ynyLtR
         hKTz+RN8M4N61e35f9Ldmsom+ZxiOaGRfLUXlXXGZjNQcIE1acm4W7CTiyuVJJZVs0rI
         rSokbQaKZJBvYj7FfumNEI/+PZny4CIFl1EKiCMWT8WiNAJfKJG0cRzcf1pxok9wvJAY
         jokmN/+nP5psuWRfEJk7+ElR/Buw0ColqoHTCYOI5lTIL7mOJP2vbLNybOml2wEXl2rL
         8DeA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id c10-v6si31315316pla.138.2018.11.16.05.48.50;
        Fri, 16 Nov 2018 05:49:04 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2389828AbeKPX7Q (ORCPT <rfc822;zcyberian@gmail.com> + 99 others);
        Fri, 16 Nov 2018 18:59:16 -0500
Received: from verein.lst.de ([213.95.11.211]:49976 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727999AbeKPX7P (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 16 Nov 2018 18:59:15 -0500
Received: by newverein.lst.de (Postfix, from userid 2407)
        id 5663868D60; Fri, 16 Nov 2018 14:46:45 +0100 (CET)
Date:   Fri, 16 Nov 2018 14:46:45 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Dave Chinner <dchinner@redhat.com>,
        Kent Overstreet <kent.overstreet@gmail.com>,
        Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, Shaohua Li <shli@kernel.org>,
        linux-raid@vger.kernel.org, linux-erofs@lists.ozlabs.org,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org,
        "Darrick J . Wong" <darrick.wong@oracle.com>,
        linux-xfs@vger.kernel.org, Gao Xiang <gaoxiang25@huawei.com>,
        Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>,
        linux-ext4@vger.kernel.org, Coly Li <colyli@suse.de>,
        linux-bcache@vger.kernel.org, Boaz Harrosh <ooo@electrozaur.com>,
        Bob Peterson <rpeterso@redhat.com>, cluster-devel@redhat.com
Subject: Re: [PATCH V10 11/19] bcache: avoid to use
 bio_for_each_segment_all() in bch_bio_alloc_pages()
Message-ID: <20181116134645.GI3165@lst.de>
References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-12-ming.lei@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181115085306.9910-12-ming.lei@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -	bio_for_each_segment_all(bv, bio, i) {
> +	for (i = 0, bv = bio->bi_io_vec; i < bio->bi_vcnt; bv++) {

This really needs a comment.  Otherwise it looks fine to me.