Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp494625imu;
        Fri, 16 Nov 2018 05:51:43 -0800 (PST)
X-Google-Smtp-Source: AJdET5fRdkj9JZkohlftxw9D3RbbFPztyuozU6QUQ4KD37H1OhfobQu6yjCD5UA42uhZPLjMG5cE
X-Received: by 2002:a62:cac4:: with SMTP id y65-v6mr11075693pfk.27.1542376303747;
        Fri, 16 Nov 2018 05:51:43 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1542376303; cv=none;
        d=google.com; s=arc-20160816;
        b=Dh1rmAfi3sclEu2FD9kfaTUUcNeaY59Ljus6qyweZVJiOqpTeSeewnGjBeeqz57q9L
         Liz++h6/Sa6pJ07Rb8LGdGMQfF979mMwYySPbR0r/HZ4vWzdSIXCI8YxYNy33MvwUVDl
         L/Qip+0+pu7YJc7tgh7s2OJIY39JeVc6tqyeQxdWE8HHZ35y0IBtOV/AX/c/wAhuVbox
         6xNzJl/ip/OhMq2w+JqdJ4ekI9VS5J+hOapF+U3Sgx3P98eju3aCRMsKEPktQ1Okoxp9
         9TpzyEHax71VGII/Xtr/BrEC3bEEXo7rOgfHIO+GPDMU7ogRCfbfESqPs+4hcNv3BfXp
         YYOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=3lPaBJRq1udXhWfDvA1BH8FMUs0QH8pgUQKeCqErynU=;
        b=YQTo4kld27HxxQcVKqKl2/T+85d6zyv1kKsINs+6KuLTWDTdoVmi/CV1ZpziwqqNkN
         7jvrTvsN8skVhrPjXzJURPhcz2VLrIPZgAwNVy6RamChiFLN60lkALOd8SrhDM27WuJ8
         +ej3Co1JneVxJMJEnH+Mg8LzsgpThc+fyx56uCvM+iCR39ndQmrx6ZeFA29oJ94ugleO
         jVbtS98qwtJeBRSzXLGU+jh0Njy0LyyRIfN/2TUChIQv5pioXYD26QILvIKWb2+g3Wkj
         QhdQjZq2XMgQru8SaaaqjpOcFH/3ijBC9cxW42lQte5eu78ijdKoJc1yZUpcqjKtDLSV
         av2w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 12-v6si9915538pfu.2.2018.11.16.05.51.29;
        Fri, 16 Nov 2018 05:51:43 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2389711AbeKQACI (ORCPT <rfc822;zcyberian@gmail.com> + 99 others);
        Fri, 16 Nov 2018 19:02:08 -0500
Received: from verein.lst.de ([213.95.11.211]:50005 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727727AbeKQACI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 16 Nov 2018 19:02:08 -0500
Received: by newverein.lst.de (Postfix, from userid 2407)
        id C8C3968D60; Fri, 16 Nov 2018 14:49:36 +0100 (CET)
Date:   Fri, 16 Nov 2018 14:49:36 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Dave Chinner <dchinner@redhat.com>,
        Kent Overstreet <kent.overstreet@gmail.com>,
        Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, Shaohua Li <shli@kernel.org>,
        linux-raid@vger.kernel.org, linux-erofs@lists.ozlabs.org,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org,
        "Darrick J . Wong" <darrick.wong@oracle.com>,
        linux-xfs@vger.kernel.org, Gao Xiang <gaoxiang25@huawei.com>,
        Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>,
        linux-ext4@vger.kernel.org, Coly Li <colyli@suse.de>,
        linux-bcache@vger.kernel.org, Boaz Harrosh <ooo@electrozaur.com>,
        Bob Peterson <rpeterso@redhat.com>, cluster-devel@redhat.com
Subject: Re: [PATCH V10 13/19] iomap & xfs: only account for new added page
Message-ID: <20181116134936.GJ3165@lst.de>
References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-14-ming.lei@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181115085306.9910-14-ming.lei@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I'd much rather have __bio_try_merge_page only do merges in
the same page, and have a new __bio_try_merge_segment that does
multi-page merges.  This will keep the accounting a lot simpler.