Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp497506imu; Fri, 16 Nov 2018 05:54:55 -0800 (PST) X-Google-Smtp-Source: AJdET5eVXZtgWo33O5W0K/t4CO4q7KyIoGlAmXB5aAluPa4wawyMIIUSZarLd/IhJrEZGhppPJAl X-Received: by 2002:a17:902:6a3:: with SMTP id 32-v6mr11198351plh.337.1542376495146; Fri, 16 Nov 2018 05:54:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542376495; cv=none; d=google.com; s=arc-20160816; b=L/Zgnwvipfdi+Wze8BtUrKSivI5qZkuTLxjd/DQ4hnpjc9Zt/iJPURxlQadPBu794d 3xv9jVEXaym2F4urtRr/ai7GoWaW/+N/Wz7BmUXFW/67NJwcFKl/iKK1D4V+xcyNw3eR jKWRosIUHrSd5eR4eAAZeeUu+xhd+ZFhgykGAhhtCdn4XTU7dMjcTtVtoBno72NJDzVu 9ufMOOSQ0gU0ff4uN1u52o3lebUDyfbUQFethHIhEkONHz0mVmfbGZ1AczjukDi6Y7/2 q+lF0PB79G1nQ7lk2cy/WtHWeM+cEdSfgliUAbP0SHNXmJnMXZx2OWav89cc9TJLhRpX itPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=YV21nFSjyu1OXnb0SR2KoVshmColCljtJ6zMBSOaJSQ=; b=xBKKxc8vGp9kaIvl49dDYu5QdmAsIRMNFqllt4Fh6x8IE5WSt2zEwUFtHWvsWTVlC8 b2orOl9ZEKUmv9C30P2CRroid7w6ARz1ZQv/uKU4rrTKHXCTkRiKosa+bgRvY0vClEeK vm7waoYMqSn5fVGKj50gZbTVLIwCebBgRKJVctPPD0yU4KqORz4tRYDxIxEUeYcOocRf P7yHBg2R0z1rbkgqq/8VTG9mywSXI1Ft1QN0BzjoMFaQobwHVTbDdGzyzDZsZj4iONEO w4o9YeSv6U6xiL4lFVOW+Ey6utQuehTTSHcBTWRmLpKO4n5izcRDMrZb8fGxC8Qe3wbM YOaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si3233620pfe.52.2018.11.16.05.54.40; Fri, 16 Nov 2018 05:54:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389881AbeKQAGN (ORCPT + 99 others); Fri, 16 Nov 2018 19:06:13 -0500 Received: from verein.lst.de ([213.95.11.211]:50059 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728079AbeKQAGN (ORCPT ); Fri, 16 Nov 2018 19:06:13 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 0ECFB68D60; Fri, 16 Nov 2018 14:53:41 +0100 (CET) Date: Fri, 16 Nov 2018 14:53:40 +0100 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, linux-erofs@lists.ozlabs.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , Theodore Ts'o , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V10 15/19] block: always define BIO_MAX_PAGES as 256 Message-ID: <20181116135340.GL3165@lst.de> References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-16-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181115085306.9910-16-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/include/linux/bio.h b/include/linux/bio.h > index 5040e9a2eb09..277921ad42e7 100644 > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -34,15 +34,7 @@ > #define BIO_BUG_ON > #endif > > -#ifdef CONFIG_THP_SWAP > -#if HPAGE_PMD_NR > 256 > -#define BIO_MAX_PAGES HPAGE_PMD_NR > -#else > #define BIO_MAX_PAGES 256 > -#endif > -#else > -#define BIO_MAX_PAGES 256 > -#endif Looks good. This mess should have never gone in. Reviewed-by: Christoph Hellwig