Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp618573imu; Fri, 16 Nov 2018 07:39:15 -0800 (PST) X-Google-Smtp-Source: AJdET5cPq+CkPhDZMwcq0GGUsRdl9vB5KyYljRvyK6o7o1gFzRiuwNSFhIFCjGZL3jcxao2ceeHL X-Received: by 2002:a17:902:8d83:: with SMTP id v3-v6mr11359497plo.162.1542382755092; Fri, 16 Nov 2018 07:39:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542382755; cv=none; d=google.com; s=arc-20160816; b=LOnvFQjTvIMZ7xn81Kc0224gXw4A6KPhlBgYEaAVW6VKlLOsXmVlkMyrwKkvlXFdZu VPc4/VyeAR1ANJNXxZPT4Q+ZnV5GX96tTiRgLA95H8zgkKIObA8ZR9sayVJGMTyxxWGT bq35WXGdFMNr+hXzm3SrIlVsdv7eiObFc5N71Z24wNO4iWAoHOHu0+vO8FNlJlp2pGdi DeEqUMHUZ38QxkBO6sf2CZ2cyVKK6w7zU3QAf+mIkIJJPZWgTsKggDBe7O+BfVWmeNIi BezVVOM96Zb2TY8DgupS2zEiTvMx0zhI3J1fhO41XhgfLqH2WOVX8XVmEbQq899noyfA NvBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to :subject:cc:to:from:date; bh=yxOE7XLkiqE8SqMN7bmRSLOtB5kh4o2mW3O5094zk58=; b=o2gjT9yLpCutg4RkA4TH2VFU8a0xDKUtv72XUodbliqnR16P7eXJ6JV32+EyHX4Eg+ 4RMw2gjBD+TXNg0UTw8ZhYauIopTOt7R/MLIjxJTir2zu/xFiR8l7ICV92hhdYuJ4+oq quPqX+rRAYhwfkVtgvSVJw8QwxN9yOpFWwHuuz2kr99DXbulTbBdajppJVSvSfiIlOT2 4oeiEsRhfO2DMM/yy9AZlJ5k9Zoi0SeQ1xDSSO5+18Y1eF5NFmrsg8RRAkT812rnbpEj O6OjaIQbrs8KMuc4uA+hW7w7ZJTisL3jB8mlSTqbdlY1Rf190RlroAiHMVZW5rBynAJH mzvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t136si15804738pfc.262.2018.11.16.07.39.00; Fri, 16 Nov 2018 07:39:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389978AbeKQBvJ (ORCPT + 99 others); Fri, 16 Nov 2018 20:51:09 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:34480 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728175AbeKQBvJ (ORCPT ); Fri, 16 Nov 2018 20:51:09 -0500 Received: (qmail 1710 invoked by uid 2102); 16 Nov 2018 10:38:18 -0500 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 16 Nov 2018 10:38:18 -0500 Date: Fri, 16 Nov 2018 10:38:18 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Ben Dooks cc: Ben Dooks , , , , Subject: Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count In-Reply-To: <39eb9e8b-2b5d-ea75-3232-be77c3743dbc@codethink.co.uk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Nov 2018, Ben Dooks wrote: > On 14/11/18 18:47, Alan Stern wrote: > > On Wed, 14 Nov 2018, Ben Dooks wrote: > > > >> From: Ben Dooks > >> > >> At least some systems benefit with less scheduling if the NAK count > >> value is set higher than the default 4. For instance a Tegra3 with > >> an SMSC9512 showed less interrupt load when this was changed to 14. > > > > Interesting. Why do you think this is? In theory, increasing the NAK > > count RL value should cause a higher memory bus load and perhaps a > > slight rise in the interrupt load (transfers will complete a little > > more quickly because the controller tries harder to poll the endpoints > > and see if they are ready). > > I thought the NAK counter was decremented until the transfer is given > up on. That's right. So if the RL value is higher, there will be more polling attempts in quick succession before the NAK counter drops to 0 and the controller gives up. More polling attempts in quick succession means heavier memory bus usage. > I'm going to have to go back and get some actual figures from > a running system as this was originally done over a year ago with the > SMSC9512 (IIRC) network driver. > > >> To allow the changing of this value, add a sysfs node to each of > >> the controllers to allow run-time changing. > >> > >> Signed-off-by: Ben Dooks > > > > The patch looks okay to me. > > I'll look at getting some tracing from the SMSC driver to see what > is going on. Okay. Should we consider the patch to be held in suspense until then? Alan Stern