Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp773793imu; Fri, 16 Nov 2018 09:58:48 -0800 (PST) X-Google-Smtp-Source: AJdET5fIwf+1NWQpIiZmml3xXH/NS5v0T05TGvsguevqY3rbXWxSo8qjrz2/uby/Pngk5P2xWTs5 X-Received: by 2002:a17:902:f20b:: with SMTP id gn11mr11272635plb.93.1542391128347; Fri, 16 Nov 2018 09:58:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542391128; cv=none; d=google.com; s=arc-20160816; b=hBq8pJVAi7U8FKYnM0bjF0P8xapHtdihbV8I+/JveJ1bCqMCwemJmtJF7VXNuaMfkz qCLdR9LJZkZmYHQwDpw+QXDTqt/e/P/V80WgITuM5qDLIKa9ZcceiUx9ZZMLm8juTm7p L7pwPCTAyRJfykJKa1E97cv0vq1/H1tLi0yIRZykf5jFAyoMg84+kFIkisL+fCx6ESVv JUIDJ71nceVJlLkYHkaT/9r7qBNFanfo+XJbCn2gYNk1ZB4coH29fdjCZWTXjJWCva0F i1D5wxQmB6/FD7FguZQ5L0o9kSlRo/d6dXD4K6wKjuu4OTdnGmvZNBvgQHPcxGiwjx27 7Nqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=eMBywuEKH5yqGIRgxStiD9BYtMdPQJswzyP8imvi/hQ=; b=FpNCZXGjo536Qbi8PjDLcPUGXf9nyzHVkzIaY9XCdh8JyqZkveMIlkMjF4n5JyhLhZ mRii8Ax70xFtu1D7us/bo9ztOjaYkXLXWx7O5fz+BC+Qk0GFolDRKw5bAHpwjftwU6gi W2O+cLGBd2O/S/M+0x1GcJf3VykGXLHVimqCWycVUpYwRImmQD035qp2L7+QksDak9cR 92nw2UlJTL7SFZq+abDiLYdS6SQIljkgJP+i7DoT8+QbKZoKBWzjlAoyidkv8nJPaex9 LRla54IaOxSb5t7WTckuO9iQ/EYQrZFj2ZFcQdTLRlcwv25fsZPEkI2KGOcpWg9HgETo Ib0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9-v6si28296658pfh.271.2018.11.16.09.58.33; Fri, 16 Nov 2018 09:58:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390099AbeKQEKb (ORCPT + 99 others); Fri, 16 Nov 2018 23:10:31 -0500 Received: from smtprelay0125.hostedemail.com ([216.40.44.125]:41825 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727544AbeKQEKb (ORCPT ); Fri, 16 Nov 2018 23:10:31 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 657E71806ECF3; Fri, 16 Nov 2018 17:57:07 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::,RULES_HIT:41:355:379:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2198:2199:2200:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3653:3865:3866:3867:3868:3871:3872:3873:3874:4321:5007:6120:10004:10400:10450:10455:10562:10848:11232:11658:11914:12740:12760:12895:13019:13069:13311:13357:13439:14181:14659:14721:19904:19999:21080:21451:21627:21740:21795:30051:30054:30060:30070:30091,0,RBL:172.58.19.122:@perches.com:.lbl8.mailshell.net-62.14.0.180 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:29,LUA_SUMMARY:none X-HE-Tag: pipe08_37beb9f9c14e X-Filterd-Recvd-Size: 2724 Received: from XPS-9350 (unknown [172.58.19.122]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Fri, 16 Nov 2018 17:57:03 +0000 (UTC) Message-ID: Subject: Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile From: Joe Perches To: Jani Nikula , Julia Lawall , Geert Uytterhoeven Cc: ksummit-discuss@lists.linuxfoundation.org, "linux-nvdimm@lists.01.org" , vishal.l.verma@intel.com, Linux Kernel Mailing List , stfrench@microsoft.com, Greg KH , Mauro Carvalho Chehab , Dmitry Vyukov , "Tobin C. Harding" Date: Fri, 16 Nov 2018 09:56:59 -0800 In-Reply-To: <878t1tgpk8.fsf@intel.com> References: <154225759358.2499188.15268218778137905050.stgit@dwillia2-desk3.amr.corp.intel.com> <154225760492.2499188.14152986544451112930.stgit@dwillia2-desk3.amr.corp.intel.com> <878t1tgpk8.fsf@intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-11-16 at 14:44 +0200, Jani Nikula wrote: > I quickly cooked up this script to produce the top-5 commit prefixes for > the given files over the arbitrary last 200 commits. It'll give you a > pretty good idea if you're even close. > > --- > #!/bin/sh > # usage: subject-prefix FILE [...] > # show top 5 subject prefixes for FILEs > > git log --format=%s -n 200 -- "$@" |\ > grep -v "^Merge " |\ > sed 's/\(.*\):.*/\1/' |\ > sort | uniq -c | sort -nr | sed 's/ *[0-9]\+ //' |\ > head -n 5 > --- > > Someone who knows perl could turn that into a checkpatch check: See if > the patch subject prefix is one of the top-5 for all files changed by > the patch, and ask the user to double check if it isn't. Or some > heuristics thereof. This won't work when a patch contains multiple files from different paths, or even multiple files from a single driver. Perhaps it's better to use a generic mechanism like basename $(dirname $filename): with some exceptions and add an override patch subject grammar to appropriate various sections of MAINTAINERS. I also think it's better to use a separate script like scripts/spdxcheck.py and tie any necessary checkpatch use to that script.