Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <Justin.Lee1@Dell.com>
To:     <sam@mendozajonas.com>, <netdev@vger.kernel.org>
CC:     <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
        <openbmc@lists.ozlabs.org>
Subject: RE: [PATCH net-next v4 0/6] net/ncsi: Allow enabling multiple
 packages & channels
Thread-Topic: [PATCH net-next v4 0/6] net/ncsi: Allow enabling multiple
 packages & channels
Thread-Index: AQHUfWg1dcgy1q1MWUOagrTe9pjUGqVS0K7Q
Date:   Fri, 16 Nov 2018 20:17:06 +0000
Message-ID: <f41bcc1c06da4f0ead13cc97fc13d68e@AUSX13MPS302.AMER.DELL.COM>
References: <20181116045159.4980-1-sam@mendozajonas.com>
In-Reply-To: <20181116045159.4980-1-sam@mendozajonas.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Samuel,

I have reviewed/tested it. It works well. Thanks for supporting these featu=
res!

Justin


Reviewed-by: Justin Lee <justin.lee1@dell.com>
Tested-by: Justin Lee <justin.lee1@dell.com>


> This series extends the NCSI driver to configure multiple packages and/or=
 channels simultaneously. Since the RFC series this includes a few extra ch=
anges to fix areas in the driver that either made this harder or were roadb=
locks due to deviations from the NCSI specification.
>=20
> Patches 1 & 2 fix two issues where the driver made assumptions about the =
capabilities of the NCSI topology.
> Patches 3 & 4 change some internal semantics slightly to make multi-mode =
easier.
> Patch 5 introduces a cleaner way of reconfiguring the NCSI configuration =
and keeping track of channel states.
> Patch 6 implements the main multi-package/multi-channel configuration, co=
nfigured via the Netlink interface.
>=20
> Readers who have an interesting NCSI setup - especially multi-package wit=
h HWA - please test! I think I've covered all permutations but I don't have=
 infinite hardware to test on.
>=20
> Changes in v2:
> - Updated use of the channel lock in ncsi_reset_dev(), making the channel=
 invisible and leaving the monitor check to ncsi_stop_channel_monitor().
> - Fixed ncsi_channel_is_tx() to consider the state of channels in other p=
ackages.
> Changes in v3:
> - Fixed bisectability bug in patch 1
> - Consider channels on all packages in a few places when multi-package is=
 enabled.
> - Avoid doubling up reset operations, and check the current driver state =
before reset to let any running operations complete.
> - Reorganise the LSC handler slightly to avoid enabling Tx twice.
> Changes in v4:
> - Fix failover in the single-channel case
> - Better handle ncsi_reset_dev() entry during a current config/suspend op=
eration.
>=20
> Samuel Mendoza-Jonas (6):
>   net/ncsi: Don't enable all channels when HWA available
>   net/ncsi: Probe single packages to avoid conflict
>   net/ncsi: Don't deselect package in suspend if active
>   net/ncsi: Don't mark configured channels inactive
>   net/ncsi: Reset channel state in ncsi_start_dev()
>   net/ncsi: Configure multi-package, multi-channel modes with failover
>=20
>  include/uapi/linux/ncsi.h |  15 ++
>  net/ncsi/internal.h       |  19 +-
>  net/ncsi/ncsi-aen.c       |  75 ++++--
>  net/ncsi/ncsi-manage.c    | 522 +++++++++++++++++++++++++++-----------
>  net/ncsi/ncsi-netlink.c   | 233 ++++++++++++++---
>  net/ncsi/ncsi-rsp.c       |   2 +-
>  6 files changed, 660 insertions(+), 206 deletions(-)
>=20
> --
> 2.19.1