Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1066971imu; Fri, 16 Nov 2018 15:17:19 -0800 (PST) X-Google-Smtp-Source: AJdET5caathY66fgTXv+PCVALMq4Hb3ibccPMzGYcMlUF1ujFiwZm5gqK5/gtaMIFymf9RIKVxfR X-Received: by 2002:a62:292:: with SMTP id 140-v6mr13533986pfc.16.1542410238974; Fri, 16 Nov 2018 15:17:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542410238; cv=none; d=google.com; s=arc-20160816; b=WJe/MArx0GfplPNQDHm2ZjHZ2rJN8ybjVCh30qUVuQv1bDgLYEwrBaVapeAlWYRQDX N9ah8Y+ic1L5zDy/xObWNWGRlCYlMgd1/vK0x9gYA4bq7v/s9oBQc29E+3K12K3+OZvO EE8jN6gL6BPN2UKFTTmXZp0OZixH638Uc9ekEdgFmoy4eQg3yLESVimhcaeyk9Y4ziJP Flbg1fvZujd3cU/TKQhuu9PE4GEY4Ce9NXUMAxvbzSyi1b/TEayqAIgBU+ABSxrZSB6C oxen435kmAExDCXyrIHz4oOK/YPdMqoquqFwGqB/3oPH/2SCn4/LQ/nldqbNJ0CEos1h HFhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:cc:cc:in-reply-to:references:subject :from:date:message-id; bh=X/9fPxFg1g9vrx+jxfZhN5zRTWV0pLK46LaccVoPxLs=; b=AOP40JQd7LhvZrpolKri7W2jecuOjkqaurNLme4E9geP2Rb7jP7Zoq8G+NdimTsQ3p bf8O0Qm1CPzGkZ8iNQrD7mqRau58Wk1sV/sSYXpEKwqrIUenZhYhsizZr0wsB9xHpjxB PO/64fpX+0BcO/y64kGe9J0GLSUKeuGxHukVowWRl+GibvJTzPgYl9KW5h0m40XjBdge cXeCUCNugd2e7PZICGTi2N2z9iEvIrWR5s6dY/J8gVRAjOdQMpva9s7RyufdZmXDH/Bn 4GGALbAP7clsabf7J7zoVuu79THRCbNBkupdFqpfbJSieAo0vnROqAqtwSGbyzUbru8S gVoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2si18124212plz.392.2018.11.16.15.16.54; Fri, 16 Nov 2018 15:17:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730312AbeKQJNr (ORCPT + 99 others); Sat, 17 Nov 2018 04:13:47 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:34674 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbeKQJNq (ORCPT ); Sat, 17 Nov 2018 04:13:46 -0500 Received: by mail-oi1-f195.google.com with SMTP id h25so2658172oig.1; Fri, 16 Nov 2018 14:59:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:subject:references :in-reply-to:cc:cc:to; bh=X/9fPxFg1g9vrx+jxfZhN5zRTWV0pLK46LaccVoPxLs=; b=nJtY9JZ7vllQlwCVKBmSJGc9F4Kvd+hCQgxoagHCdiQalhwnpNpmFCams9ZLJM/pV0 M3SWneCsqLrff5fj3+qkqpmIBCjxhueJktTEoqt8+7bsRM//hXKTIBAErz7cnyyETIAD /jJJKuS1y2fOhvxGRmHMhB2WyLwTyj6VhiWiiDgJFitrqfsWSGVZ0am/kaCi+wR6yw3e z9w7oc15kvD/czu4EjZWvP7fyyGTLWGyWJikQdQ6ec2pXFDYAAg8Jg0NfkEBVt/GY1c/ rn89SLme7u3AD/oijQnsFKFW0QhG2gUcjsFD+JECpqkv7Qz2tOHSWWfOcZ7pjc0RqS06 zDqw== X-Gm-Message-State: AGRZ1gLAo/CXdD0s9/1T3AMXK3cYeivk1Lf5JKVa+QZ69FGz8y9K1GLd rfDXojPDDfle3N6IBXMopg== X-Received: by 2002:aca:e514:: with SMTP id c20-v6mr2143076oih.75.1542409168651; Fri, 16 Nov 2018 14:59:28 -0800 (PST) Received: from localhost (mobile-166-173-57-127.mycingular.net. [166.173.57.127]) by smtp.gmail.com with ESMTPSA id f37sm1959147otd.15.2018.11.16.14.59.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Nov 2018 14:59:27 -0800 (PST) Message-ID: <5bef4bcf.1c69fb81.39c0b.e18d@mx.google.com> Date: Fri, 16 Nov 2018 16:59:26 -0600 From: Rob Herring Subject: Re: [PATCH v5 5/9] dt-bindings: spi: Adjust the bindings for the FSL QSPI driver References: <1542116782-13118-1-git-send-email-frieder.schrempf@kontron.de> <1542116782-13118-6-git-send-email-frieder.schrempf@kontron.de> In-Reply-To: <1542116782-13118-6-git-send-email-frieder.schrempf@kontron.de> Cc: "linux-mtd@lists.infradead.org" , "boris.brezillon@bootlin.com" , "linux-spi@vger.kernel.org" , Mark Brown CC: "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "marek.vasut@gmail.com" , "richard@nod.at" , "miquel.raynal@bootlin.com" , "david.wolfe@nxp.com" , "fabio.estevam@nxp.com" , "prabhakar.kushwaha@nxp.com" , "yogeshnarayan.gaur@nxp.com" , "han.xu@nxp.com" , "shawnguo@kernel.org" , Schrempf Frieder , Mark Rutland , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Schrempf Frieder Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Nov 2018 13:47:37 +0000, Schrempf Frieder wrote: > Adjust the documentation of the new SPI memory interface based > driver to reflect the new drivers settings. > > The "old" driver was using the "fsl,qspi-has-second-chip" property to > select one of two dual chip setups (two chips on one bus or two chips > on separate buses). And it used the order in which the subnodes are > defined in the dt to select the CS, the chip is connected to. > > Both methods are wrong and in fact the "reg" property should be used to > determine which bus and CS a chip is connected to. This also enables us > to use different setups than just single chip, or symmetric dual chip. > > So the porting of the driver from the MTD to the SPI framework actually > enforces the use of the "reg" properties and makes > "fsl,qspi-has-second-chip" superfluous. > > As all boards that have "fsl,qspi-has-second-chip" set, also have > correct "reg" properties, the removal of this property shouldn't lead to > any incompatibilities. > > The only compatibility issues I can see are with imx6sx-sdb.dts and > imx6sx-sdb-reva.dts, which have their reg properties set incorrectly > (see explanation here: [2]), all other boards should stay compatible. > > Also the "big-endian" flag was removed, as this setting is now selected > by the driver, depending on which SoC is in use. > > [2] https://patchwork.ozlabs.org/patch/922817/#1925445 > > Signed-off-by: Frieder Schrempf > --- > .../devicetree/bindings/spi/spi-fsl-qspi.txt | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > Reviewed-by: Rob Herring