Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1073343imu; Fri, 16 Nov 2018 15:25:48 -0800 (PST) X-Google-Smtp-Source: AJdET5d6cKMN+fgCJzzgaNZYytlf+pDtycZHqhETeFStQihJL3jKB+uRQq1VWWBEIGPgjO9pzIVp X-Received: by 2002:a62:7892:: with SMTP id t140mr13134057pfc.237.1542410748521; Fri, 16 Nov 2018 15:25:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542410748; cv=none; d=google.com; s=arc-20160816; b=C5QJBEsLtUgBg6oCZVkx72sMD9hYoVk8JGbeiO2Fcc5jT4NLeJweIdZ1mrLhkjnK/o ChKqHbjRKJWdWgbmHXPkQ8Mc1nUqtcPIaW33ctsH7keJv+Fe3on6m396vmTaZf0TilPz hA9opAgDo3neo0uWCSlAACQpaApe+imSNhLDaVZVxXcZFleeH4lG7RSloQXEvi67cFgp yib49V3/6M67nujkKylSfQJbciCwr/3/Yh8OBpD+GY9kxPo+LlSnagJVwJxUyjvrXpum UAw3Ia767cCMKvjANKRe3n4tRhMZzWG/1McgGLwyaWyEj91nAXVSGSAqdtpZF5ILgaAr 7U8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DnW6j3b7hQfTSor4EgGvVKxnbH355l7Vymiy7KfcfR8=; b=rB3X65WyHCAj0n+J8M+Am7hpfwW6bVg323HMDbe48kLWBOCCc8NKa75PxJa7mntJJV poQ+R6JyVpX3G8LKNm/pfCsI6dQZNu6LdhyD6Claq7GJbVRfEVTyHbthxaThUXzk3oQk HNhQgOOulqep9/SPSMv7CDHo8XsFDN7S6lVgvijEbEEmkvFUttf4SbxTJjkGhnZPOBD4 3GctigCh+kpL+X0N+SiZ1pG/yFphj/OBjW++UVPSpbG2eMGGTRou3z97kj+YGCDlUieI 5nSNIzlLrAZkftRAe9Zzm/TM4sQrvjwKZHTCi4ruayGIF+2A9+MEPPSf3sdmEInWmvTs VXvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 27si31493267pgp.135.2018.11.16.15.25.34; Fri, 16 Nov 2018 15:25:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730475AbeKQJjU (ORCPT + 99 others); Sat, 17 Nov 2018 04:39:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54926 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726222AbeKQJjT (ORCPT ); Sat, 17 Nov 2018 04:39:19 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 502994E91F; Fri, 16 Nov 2018 23:24:58 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-11.bss.redhat.com [10.20.1.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id CED385D739; Fri, 16 Nov 2018 23:24:56 +0000 (UTC) From: Lyude Paul To: amd-gfx@lists.freedesktop.org Cc: Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , "David (ChunMing) Zhou" , David Airlie , "Jerry (Fangzhi) Zuo" , Roman Li , Tony Cheng , Daniel Vetter , Shirish S , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] drm/amd/dm: Understand why attaching path/tile properties are needed Date: Fri, 16 Nov 2018 18:24:39 -0500 Message-Id: <20181116232443.1709-3-lyude@redhat.com> In-Reply-To: <20181116232443.1709-1-lyude@redhat.com> References: <20181116232443.1709-1-lyude@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 16 Nov 2018 23:24:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Path property is used for userspace to know what MST connector goes to what actual DRM DisplayPort connector, the tiling property is for tiling configurations. Not sure what else there is to figure out. Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c index 0cca1809fdcd..1b0d209d8367 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c @@ -345,9 +345,6 @@ dm_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr, drm_connector_attach_encoder(&aconnector->base, &aconnector->mst_encoder->base); - /* - * TODO: understand why this one is needed - */ drm_object_attach_property( &connector->base, dev->mode_config.path_property, -- 2.19.1