Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp81818imu; Fri, 16 Nov 2018 17:54:51 -0800 (PST) X-Google-Smtp-Source: AJdET5ekUYzIL9EK9QL4JVRdLJyABb1JLgdpJthSFNuWny58YhaTAa1/0Kk5KtDLV4dz6uOt1co9 X-Received: by 2002:a63:f74f:: with SMTP id f15mr12218467pgk.190.1542419690993; Fri, 16 Nov 2018 17:54:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542419690; cv=none; d=google.com; s=arc-20160816; b=lRBqibQJB3teU94B9MM1ApgMJgvR0K/YLhp26Yg9D1X2vyI9e+Sme/5zM87t5BMtLn W3J9i9suWPwNKQS67BR5ErCavNyffTQS4KlE3iYpQytnJoQb8wKMxuh2sFk+Ly7sYcxV ALMJpSYSjcVe5iKI8Tn5rlMNzi0hoW3Ncz+5ONBf1SuOgKjFMzsJFXAHhPHJhx6OP+KU C9DuJGTE1WshEedo71YRBBMytjUcSFY6hU2b6zouwmYNCSUMcrrjhgrM6P2K83lxRaUI 6/zswKlCdtwTmiLpaXol3oZ0hCd701Oy6/hVL6TemtgukBGyR1YRfmqJjT3Y6qRvOpys InZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/QuOQ2ktNOuGzkGZkvCU1LqpXgue9a/ZPpeQbHXPrTY=; b=WRcSrXZw4gio/xw923FhmaaXnr+rkqOZTLekTxzFG6hDmW/ulVzkVer96Jv0inlXJS c7iwLkeFqmU5cXiiQsblr39W+mGAyFrU21GgT5xiNgpgk1UdEF0DFnp2iA2STNNvoRXq 51Zt6TV+o91cAtaF2xVxizTyNgVWOQ8SlVSJCkm/3sauSyA/8to9EnY0zDzWQSTUQLqA 7ktKY01dwTvTwwsHjrwcjtH2tEOHxdq86WVYSJJCfLgiFVbgQwN5GTpTgSMv3vDjpE+A ldlCW6pqMaAYiEEj+YL1EkokYyXFHR4DDswBDfVEyfwyscVLnx1lnyeJNq9glvXWtp8n D2nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="LVdju/DM"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c15si29040694pgg.446.2018.11.16.17.54.36; Fri, 16 Nov 2018 17:54:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="LVdju/DM"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731034AbeKQMGy (ORCPT + 99 others); Sat, 17 Nov 2018 07:06:54 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:37873 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727116AbeKQMGy (ORCPT ); Sat, 17 Nov 2018 07:06:54 -0500 Received: by mail-pl1-f193.google.com with SMTP id b5so5523422plr.4; Fri, 16 Nov 2018 17:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/QuOQ2ktNOuGzkGZkvCU1LqpXgue9a/ZPpeQbHXPrTY=; b=LVdju/DMOr3j/fj/sZAxVzGxizXGSbo2I0nEIlJsCJ3/MSnt9k070VmkZjbxu85MYn /c2uMZYzTDlmsaq8p1Xz9G8KxcDOkikCt5ZlTQEpg1Ujpce5Vo9YKKhLmrg/5+vwFAee z+eKzQdxDQTmo7et1Qu+1/VVKcUHM5WBUFWdNd7dpMP7Kdj8KFWvSWmr3VpuffaPHKsk r+wgSTW9qFVnm2WVBTOaeLeNaOyyBWdwjx5G05nZhuLg4Vd4cra8x3WsrGCNaf8r7q+Y ZHNFdC4Am/SnX6IM5S4vLBEZd3hmOJvzBV2k9wcRmRivBhxWb0V7eOF8rCYLg4aebAzm mq2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/QuOQ2ktNOuGzkGZkvCU1LqpXgue9a/ZPpeQbHXPrTY=; b=c4LKByEtLNFbxHXWuuYYoc7nXJsfKsXZ4fTMrLShfIPpocb/f6bw6jMIFdinS3K7eG RuFjAAfxt1Wak21KPl6rJx8XPXKKIMhrlWehwW8E17HYnyct7RdwtqPTJMP9pmbQLr/s 12zGupC0a1mDCzQz3l/KmakpjOSH126efTQUwMFAx0m9Rx8llMxq7+9PvMhcFQazBzeh eBTZKPFfh0hnuVbkhlsYG4nS7Em2VaXfFYv+Ewjg/FedIdITfYcZ3TJTqPMph7XVdvVk oqPgfYay2oRQEZgx9dfjfRyVPeDIRbR10bCIT4MaCLzFosVlDEy3k62FCAcTp2s7ItjS fdwA== X-Gm-Message-State: AGRZ1gJ4mRn+h6SjrmaytE/Mu894a8FbvDJKZZhk0GtNU0b2chjqwbLW LEhw0YDBddq8YarbufB8cGQ= X-Received: by 2002:a17:902:d697:: with SMTP id v23mr12951540ply.261.1542419524609; Fri, 16 Nov 2018 17:52:04 -0800 (PST) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:180::1:3220]) by smtp.gmail.com with ESMTPSA id p188sm8987705pfg.65.2018.11.16.17.52.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 17:52:03 -0800 (PST) Date: Fri, 16 Nov 2018 17:52:02 -0800 From: Alexei Starovoitov To: Nathan Chancellor Cc: Alexei Starovoitov , Daniel Borkmann , Quentin Monnet , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bpf: Remove unused variable in nsim_bpf Message-ID: <20181117015201.r6t62y25a2c22why@ast-mbp.dhcp.thefacebook.com> References: <20181112221042.11160-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181112221042.11160-1-natechancellor@gmail.com> User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 12, 2018 at 03:10:42PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/net/netdevsim/bpf.c:557:30: error: unused variable 'state' > [-Werror,-Wunused-variable] > struct nsim_bpf_bound_prog *state; > ^ > 1 error generated. > > The declaration should have been removed in commit b07ade27e933 ("bpf: > pass translate() as a callback and remove its ndo_bpf subcommand"). > > Signed-off-by: Nathan Chancellor Applied, Thanks