Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <e6910a457e75e240e18ed395ccb2f960dda6fc94.camel@sipsolutions.net>
Subject: Re: [PATCH v2 1/3] compiler-gcc: hide
 COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW from sparse
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc:     linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Date:   Sat, 17 Nov 2018 12:29:12 +0100
In-Reply-To: <20181117004209.v67yalpxuswhs2vr@ltop.local> (sfid-20181117_014213_396373_F28FF538)
References: <20181109093534.15121-1-johannes@sipsolutions.net>
         <20181117004209.v67yalpxuswhs2vr@ltop.local>
         (sfid-20181117_014213_396373_F28FF538)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2018-11-17 at 01:42 +0100, Luc Van Oostenryck wrote:
> On Fri, Nov 09, 2018 at 10:35:32AM +0100, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> > 
> > Sparse doesn't support all the overflow builtins, so just hide
> > them from it to avoid lots of warnings/errors reported by it.
> 
> The development version of sparse support these builtins
> since their introduction in the kernel and sparse's main tree
> have been updated (very recently).

All the better, but I certainly checked sparse git before even
considering this patch, so saying "but it's all there" feels somewhat
dishonest. Also, the sparse repo is 'backdated' to the end of October.
I'm almost certain this wasn't present when I sent the patch.

However, it would be nice to be able to use distro sparse versions, so
not sure I fully agree that we shouldn't apply such patches.

johannes