Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 17 Nov 2018 16:32:28 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Stefan Popa <stefan.popa@analog.com>, mark.rutland@arm.com,
        knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
        Michael.Hennerich@analog.com, gregkh@linuxfoundation.org,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] dt-bindings: iio: adc: Add common ADCs
 properties to a separate file
Message-ID: <20181117163228.5f5b5bb8@archlinux>
In-Reply-To: <20181116225302.GA23266@bogus>
References: <1542108061-3471-1-git-send-email-stefan.popa@analog.com>
        <20181116183838.6a079255@archlinux>
        <20181116225302.GA23266@bogus>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 16 Nov 2018 16:53:02 -0600
Rob Herring <robh@kernel.org> wrote:

> On Fri, Nov 16, 2018 at 06:38:38PM +0000, Jonathan Cameron wrote:
> > On Tue, 13 Nov 2018 13:21:01 +0200
> > Stefan Popa <stefan.popa@analog.com> wrote:
> >   
> > > There are several ADC drivers that depend on the same device tree
> > > bindings. Rather than continue to duplicate the properties, this patch
> > > adds a common adc binding document that can be referenced. For beginning,
> > > only two properties are documented.
> > > 
> > > Signed-off-by: Stefan Popa <stefan.popa@analog.com>  
> > Looks very sensible to me, but as we are looking at a some generalization
> > here, I'd like an Ack from Rob if possible (as he suggested it I think :)  
> 
> Looks fine to me, but I don't have any clue if this will be flexible 
> enough for various h/w.
I think we'll need more to cover all cases, but hopefully things that
make sense to be optional in general.  Rather hard to predict.  This is
the obvious stuff so far.

This is better than the current mess of different options!

Jonathan

> 
> Rob
>