Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2459031imu; Mon, 19 Nov 2018 00:29:53 -0800 (PST) X-Google-Smtp-Source: AJdET5diZ9oDQW8aoqNiiofXz3K8k3PiBpySQSBwZ175WQ53gjy0V52FyqSNpSgoluEF2JsKfk4X X-Received: by 2002:a65:5088:: with SMTP id r8mr13574525pgp.15.1542616193203; Mon, 19 Nov 2018 00:29:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542616193; cv=none; d=google.com; s=arc-20160816; b=beWsjCxvTiDwiNB541xES6kPJWWoWR56NVvTBbyw5qjP4ugwC0IeN8/umvh+aesCPX hRjHmozH0/HuD5oToM6X+K2WUXB27UZPMAPGEAtdc0BwwsOOcA7ybKv1xp3YSKML8bVI s5VgbBB4yXixopBXcGt2LqHgf5uWjgQcU9lwzHFhJt0A4MGsD0Q10s8WT75sIJtb3qrc 9yniM/MYT6fpWpI9/tZddPWMe8+YowkPaohlugIhbV4NaZdlfBHaTDMnb2AQY9JdB9RW 0MPqIytzj1M/7ljKCIzApmeYXRooBzyO4ZdEtcJ6TWBmb+Goa2OAmD0arrHTysWJHyXo szdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=dvi79ySygSsumwfq0LkGl36vaIinu1WuTEOZeNu4VRg=; b=BUGL5uiFcqOgpfEELNWzKLc/wT8OoB3bhjqnRVbZWMjup54pJjB4ZlSQSuEX3yOif4 Xbaj/EIWaafQtZK7uOzc1c3dLODOgSHBF4PCzlEmgxCVnmjyuvOK1vslVPiEg90l838N kS2sgxG1/Enrqv0d8eHsNemwWpiN2PXxbcGwxkBcM2GKC1mtnxfalf9pK2dzZwgmsKZX LK4JfWmufkLnmmgZG3gXajHONuHvmi+FqgYOBq0GfSJ4LbJmmdqK35pb/If1IiNhy7jn RKVp1tZ028M7CIkmLpJh+hvpojOZKEHO2nanUJSmbrcx/SVQwlwGKbt+/0Nldg3hcIbz fZ3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1si19695671pgi.480.2018.11.19.00.29.37; Mon, 19 Nov 2018 00:29:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727211AbeKSSvl (ORCPT + 99 others); Mon, 19 Nov 2018 13:51:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36178 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbeKSSvl (ORCPT ); Mon, 19 Nov 2018 13:51:41 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2E54B89ACE; Mon, 19 Nov 2018 08:28:46 +0000 (UTC) Received: from ming.t460p (ovpn-8-26.pek2.redhat.com [10.72.8.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6E6331974C; Mon, 19 Nov 2018 08:28:24 +0000 (UTC) Date: Mon, 19 Nov 2018 16:28:20 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, linux-erofs@lists.ozlabs.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Theodore Ts'o , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Message-ID: <20181119082818.GF16736@ming.t460p> References: <20181115085306.9910-1-ming.lei@redhat.com> <20181115085306.9910-12-ming.lei@redhat.com> <20181116134645.GI3165@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181116134645.GI3165@lst.de> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 19 Nov 2018 08:28:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 16, 2018 at 02:46:45PM +0100, Christoph Hellwig wrote: > > - bio_for_each_segment_all(bv, bio, i) { > > + for (i = 0, bv = bio->bi_io_vec; i < bio->bi_vcnt; bv++) { > > This really needs a comment. Otherwise it looks fine to me. OK, will do it in next version. Thanks, Ming