Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2565915imu;
        Mon, 19 Nov 2018 02:37:13 -0800 (PST)
X-Google-Smtp-Source: AFSGD/VZ2AgQSOtmLDQYlu0+7fhHg4D9mAjll5mBoBpgDYUFLrxue/dv8qRsqmPwN5V8LPJuCAs0
X-Received: by 2002:a63:902:: with SMTP id 2mr2760112pgj.219.1542623833088;
        Mon, 19 Nov 2018 02:37:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1542623833; cv=none;
        d=google.com; s=arc-20160816;
        b=ZXyzhz+hXhk7Mz7Fh+6/m8yXBLZxE1DtmpnaMCDzZ+l/0sfAfkzawDvjfphY2csYQD
         34kRdfkgiIs++OCHrlhVgfjPEylzclJ9fH/fDDUeTz4Cp439KvEDw+XsYBTZJoRjZAIZ
         3j+iUjpGYTbjoySE8trUutroZsoF5J8Ezu5/KDCW5YrVKz8DWotsFDet1avzYZbM4dtf
         poCbdzSM/CDP6F1L0yDqojty5z86jlTIOTT/o3lvsYIpQaCj5+V+vIJdYfvbBVfF51CR
         w85NJpYbXv97tg0z+XWeJ7eLsuQTdZq1JqVuxHDQ+UcrLgfnG4sEkhe+xyw5SIf/+W4o
         UD2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=7aPfZg3ok4fYsUsc++MIDA9Lblt97XM1FS0Oj8LDK4Y=;
        b=uuWEjkaQLLXrlesoJH6HZxPiubnTqL6jyYgRfnKWhyyKLXa7PRjoHIW2X9J/LSX0Vk
         UMRSlakfiWHvz407FK4zv84iItUmpUVjuABylNAY1y6NhpSXJ7t2tZ3AZG8ZRR7/ySzk
         SV4lUvV7gOufVxzLImZx0bmY7Fg8BhhWvDssRdjdmyRB1g9hoXE2pW5LRRLD8lZHyp5b
         UxX2ha5PEVGs+Yt/TmhnYaSa7uszjqlpAXh8jD6yvnRXEwzSfZmU9VeXYUbg56+N26xj
         +V1PMTdbJnlVLGgTj0F+13HM5uJtj6+QZ+ptQPi16qUtI3UxTFo36R79BUzMgvGqZUVB
         pKuw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id x5si35135748pga.440.2018.11.19.02.36.58;
        Mon, 19 Nov 2018 02:37:13 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728456AbeKSU6z (ORCPT <rfc822;kkoh.linux@gmail.com>
        + 99 others); Mon, 19 Nov 2018 15:58:55 -0500
Received: from hetzy.fluff.org ([88.198.11.153]:53848 "EHLO hetzy"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1727698AbeKSU6y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Nov 2018 15:58:54 -0500
X-Greylist: delayed 1691 seconds by postgrey-1.27 at vger.kernel.org; Mon, 19 Nov 2018 15:58:52 EST
Received: from ben by hetzy with local (Exim 4.89)
        (envelope-from <ben@fluff.org>)
        id 1gOgRo-0001TG-Ix; Mon, 19 Nov 2018 10:06:28 +0000
Date:   Mon, 19 Nov 2018 10:06:28 +0000
From:   Ben Dooks <ben@fluff.org>
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     Ben Dooks <ben.dooks@codethink.co.uk>,
        Ben Dooks <ben-linux@fluff.org>, gregkh@linuxfoundation.org,
        linux-usb@vger.kernel.org, linux-kernel@lists.codethink.co.uk,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count
Message-ID: <20181119100628.iukzaouikfsbrywq@hetzy.fluff.org>
References: <39eb9e8b-2b5d-ea75-3232-be77c3743dbc@codethink.co.uk>
 <Pine.LNX.4.44L0.1811161034500.1487-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44L0.1811161034500.1487-100000@iolanthe.rowland.org>
X-Disclaimer: These are my views alone.
X-URL:  http://www.fluff.org/
User-Agent: NeoMutt/20170113 (1.7.2)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: ben@fluff.org
X-SA-Exim-Scanned: No (on hetzy); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 16, 2018 at 10:38:18AM -0500, Alan Stern wrote:
> On Fri, 16 Nov 2018, Ben Dooks wrote:
> 
> > On 14/11/18 18:47, Alan Stern wrote:
> > > On Wed, 14 Nov 2018, Ben Dooks wrote:
> > > 
> > >> From: Ben Dooks <ben.dooks@codethink.co.uk>
> > >>
> > >> At least some systems benefit with less scheduling if the NAK count
> > >> value is set higher than the default 4. For instance a Tegra3 with
> > >> an SMSC9512 showed less interrupt load when this was changed to 14.
> > > 
> > > Interesting.  Why do you think this is?  In theory, increasing the NAK
> > > count RL value should cause a higher memory bus load and perhaps a
> > > slight rise in the interrupt load (transfers will complete a little
> > > more quickly because the controller tries harder to poll the endpoints
> > > and see if they are ready).
> > 
> > I thought the NAK counter was decremented until the transfer is given
> > up on.
> 
> That's right.  So if the RL value is higher, there will be more polling
> attempts in quick succession before the NAK counter drops to 0 and the
> controller gives up.  More polling attempts in quick succession means 
> heavier memory bus usage.
> 
> > I'm going to have to go back and get some actual figures from
> > a running system as this was originally done over a year ago with the
> > SMSC9512 (IIRC) network driver.
> > 
> > >> To allow the changing of this value, add a sysfs node to each of
> > >> the controllers to allow run-time changing.
> > >>
> > >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> > > 
> > > The patch looks okay to me.
> > 
> > I'll look at getting some tracing from the SMSC driver to see what
> > is going on.
> 
> Okay.  Should we consider the patch to be held in suspense until then?

Yes, I'm not going to have access to any of the test hardware until the
end of the week, and will re-verify my initial notes from last year.

-- 
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.