Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Olof Johansson' <olof@lixom.net>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] arm64: Explicitly mark 64-bit constant as unsigned long
Thread-Topic: [PATCH] arm64: Explicitly mark 64-bit constant as unsigned long
Thread-Index: AQHUfhiZwItjBBrszU+mUSyuKaet9KVXA/Iw
Date:   Mon, 19 Nov 2018 12:07:16 +0000
Message-ID: <51cf0f37dc694a858fcc422763f6ca72@AcuMS.aculab.com>
References: <20181117015456.101222-1-olof@lixom.net>
In-Reply-To: <20181117015456.101222-1-olof@lixom.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


From: Olof Johansson
> Sent: 17 November 2018 01:55
...
> -#if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0xffffffffffffffff
> +#if (SCTLR_EL2_SET ^ SCTLR_EL2_CLEAR) != 0xfffffffffffffffful
>  #error "Inconsistent SCTLR_EL2 set/clear bits"
>  #endif

Wouldn't this be clearer if written:
	#if SCTLR_EL2_SET != ~SCTLR_EL2_CLEAR
which then begs the question of why there are separate 'set' and 'clear' masks.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)