Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH][i3c-next] i3c: master: fix mask operation by using the
 correct operator
To:     Colin King <colin.king@canonical.com>,
        Vitor Soares <vitor.soares@synopsys.com>,
        Boris Brezillon <boris.brezillon@bootlin.com>
CC:     <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20181116184223.28240-1-colin.king@canonical.com>
From:   vitor <vitor.soares@synopsys.com>
Message-ID: <7d569740-e5d3-b8a6-79cf-9885039e53de@synopsys.com>
Date:   Mon, 19 Nov 2018 12:41:10 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181116184223.28240-1-colin.king@canonical.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Coling,


Thanks for your report.

On 16/11/18 18:42, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The masking operation on status is using a bitwise 'or' rather than
> a bitwise 'and' operator, and hence the result is always non-zero
> which is probably not what is intended. Fix this by using the correct
> operator.
>
> Detected by CoverityScan, CID#1475523 ("Wrong operator used")
>
> Fixes: 88acc98a712a ("i3c: master: Add driver for Synopsys DesignWare IP")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/i3c/master/dw-i3c-master.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 0153e6e9de52..b532e2c9cf5c 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1085,7 +1085,7 @@ static irqreturn_t dw_i3c_master_irq_handler(int irq, void *dev_id)
>   
>   	spin_lock(&master->xferqueue.lock);
>   	dw_i3c_master_end_xfer_locked(master, status);
> -	if (status | INTR_TRANSFER_ERR_STAT)
> +	if (status & INTR_TRANSFER_ERR_STAT)
>   		writel(INTR_TRANSFER_ERR_STAT, master->regs + INTR_STATUS);
>   	spin_unlock(&master->xferqueue.lock);
>   
Acked-by: Vitor Soares <vitor.soares@synopsys.com>