Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2872025imu; Mon, 19 Nov 2018 07:22:23 -0800 (PST) X-Google-Smtp-Source: AJdET5fJ6slxzOxr+yRdc/6cfYUAvdnP1/Ftda4d5GNfA8ysWQR3oKJXUwVK9xUCMg45JTu5mSHX X-Received: by 2002:a63:6cc:: with SMTP id 195mr20760741pgg.52.1542640943560; Mon, 19 Nov 2018 07:22:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542640943; cv=none; d=google.com; s=arc-20160816; b=Gsiv1upj+oTzy8uWiCmYU9OK1k+DfHQQDlTdlJOrvR1k7sKzcES2gphY/8JHI7mu9l yaEUMeSVe/y5XUL5GlRc+b/nKRGdlyNjq+TDacv5BfRq3m5+nQCwkpZtUyTrxCv3QXt9 rflvRS/AkER2V1fqkyUW00CHx5w0bm0fGtjCD6wSp66qyNWvXA2PgRFgvakUMfWK7q9Y gfjLisc4Fr2p4riWCvUHSySLhU4MLmUI9dpUsfg43gWEuFsfzgTxDrxYkxfQ1fSb1loO hgGlxJq0zqigZVxJp3p3CAIhqlXA72KXjNqa3R4DcUHHOya52jt/s63zjs8fa0XPEzrf 5A0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=CRhVELdiAtzAfphCg7+bAcuWRRr/DatQWwtqdSahUms=; b=jQDp9WHr/L5CAr2AjmKgdvhhsYm+8Z93A53IzxrY0yn7CYIBPJFcTCZf4PfiMaW3dK nAw8L1qNVaKfH7xKIyV308MvUICb2VqNoU7XnMB4VzElQaKXayvtjv9GucrV2sOfZy8i wd5BP5iPopVMzLTG6nofaVeA9oOnU6eKcOmR9qWbX1FjuhzFT5OvuAs+jUCK83PUOK5y cZuCxZOcxTyjmw73H7aBBtNmiR67Dc/2iAzTUvT/i25YpG/aG2L7pKTN2bVILYxO0nvQ W6MSU1QIMBmz6vGg8aTYDFFT9DlzdFZFSQzEwGwu0sFR8IhZ5ZzCZ8IgCWQOxOwl5A1U 5ZRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m17-v6si20744488pfj.48.2018.11.19.07.22.06; Mon, 19 Nov 2018 07:22:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729801AbeKTBos (ORCPT + 99 others); Mon, 19 Nov 2018 20:44:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:44408 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729483AbeKTBos (ORCPT ); Mon, 19 Nov 2018 20:44:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B049AB01F; Mon, 19 Nov 2018 15:20:52 +0000 (UTC) Date: Mon, 19 Nov 2018 16:20:51 +0100 (CET) From: Jiri Kosina To: Rodrigo Rivas Costa cc: Benjamin Tissoires , "Pierre-Loup A. Griffais" , lkml , linux-input Subject: Re: [PATCH] HID: steam: remove input device when a hid client is running. In-Reply-To: <20181014173643.9643-1-rodrigorivascosta@gmail.com> Message-ID: References: <20181014173643.9643-1-rodrigorivascosta@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 14 Oct 2018, Rodrigo Rivas Costa wrote: > Previously, when a HID client such as the Steam Client was running, this > driver disabled its input device to avoid doubling the input events. > > While it worked mostly fine, some games got confused by the idle gamepad, > and switched to two player mode, or asked the user to choose which gamepad > to use. Other games just crashed, probably a bug in Unity [1]. > > With this commit, when a HID client starts, the input device is removed; > when the HID client ends the input device is recreated. > > [1]: https://github.com/ValveSoftware/steam-for-linux/issues/5645 Applied to for-4.20/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs