Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2917969imu; Mon, 19 Nov 2018 08:03:58 -0800 (PST) X-Google-Smtp-Source: AJdET5elEL5GKbsuhjuC6mLQjCGevvjnXMkvjAbyxTZD1a7ne6etyGD4pJetPMEoU38yynnP+8Tp X-Received: by 2002:a63:a441:: with SMTP id c1-v6mr20865038pgp.49.1542643438718; Mon, 19 Nov 2018 08:03:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542643438; cv=none; d=google.com; s=arc-20160816; b=wKNBFVmofMMS4MWU11xomix3ob39lKX/2Y9hbgqt/UNSgqUW0K4FqkNKeeU/GRNPrl chZwTx74U/VMsaC87PP4i7nk1ZlWea1wiqpmhu5JvDvFhFvxnojSwbdS4+22Qx77CuQz 1/YB7Dddgmfg1YJBj0teishlz1Rh3ihgw/r9Cn3iFPN8y0Fv7PEk7dBQiJxqDwzPIBU4 VGBaCypsloAo1ZQkEm4alFNuEKMI3mvWguqP3xXxLjqcW3vdxBsLqX5WKU6Z21uGf/op vWoI8YyB9cDF0JR2tUkZDL1BQiPGmhou7i8NOZgAWaklKJlCjNy7wlyZQ0c13gMAKWC6 ROlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=aymKjIWN8ukMxUH2SG/wZK723NvrrNtHl6M0poCc4xQ=; b=lKp/2x+2+VSAqMcZ8lcy2Eq3XNEtAdGzFTS1D6wXrTm+KuwhgyhbDZjGtL/dyqo5h1 bfGoezmgZjZmo3EPpoh5iB/nmhLobP1WMGz3S2WeL/WH+DDAeeWAqwLhAAzsmiF4QrBh l/Y+S4OCmhmL2fP3JzMtAlGgKcGuwA4jVNIgoNpxFpYFfmbrhD1hgR7sUJwElZFxkSYg QwEw0IOtoey3S0Wqd4QIWFcrl/AgyyUBBVEAzo+zXmopBNC4i24TLfT+1nIOyc1uh87U EtU/7VOVXWj3wAek2zR3GtfHXPy4zffaj17TJ/khSEpKrS6hdL9Ik1itJMsC7hdNl/8m C8oA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v14-v6si40245013pgt.78.2018.11.19.08.03.40; Mon, 19 Nov 2018 08:03:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729978AbeKTC0P (ORCPT + 99 others); Mon, 19 Nov 2018 21:26:15 -0500 Received: from mga04.intel.com ([192.55.52.120]:27569 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729928AbeKTC0N (ORCPT ); Mon, 19 Nov 2018 21:26:13 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2018 08:02:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,253,1539673200"; d="scan'208";a="101478507" Received: from tmuluk-mobl4.ger.corp.intel.com (HELO localhost) ([10.249.254.135]) by orsmga003.jf.intel.com with ESMTP; 19 Nov 2018 08:02:05 -0800 Date: Mon, 19 Nov 2018 18:02:04 +0200 From: Jarkko Sakkinen To: Andy Lutomirski Cc: Dave Hansen , "Christopherson, Sean J" , Jethro Beekman , Florian Weimer , Linux API , Jann Horn , Linus Torvalds , X86 ML , linux-arch , LKML , Peter Zijlstra , Rich Felker , nhorman@redhat.com, npmccallum@redhat.com, "Ayoun, Serge" , shay.katz-zamir@intel.com, linux-sgx@vger.kernel.org, Andy Shevchenko , Thomas Gleixner , Ingo Molnar , Borislav Petkov Subject: Re: RFC: userspace exception fixups Message-ID: <20181119160204.GD13298@linux.intel.com> References: <20181118071548.GA4795@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 19, 2018 at 07:29:36AM -0800, Andy Lutomirski wrote: > 1. The kernel needs some way to know *when* to apply this fixup. > Decoding the instruction stream and doing it to all exceptions that > hit an ENCLU instruction seems like a poor design. I'm not sure why you would ever need to do any type of fixup as the idea is to just return to AEP i.e. from chosen exceptions (EPCM, #UD) the AEP would work the same way as for exceptions that the kernel can deal with except filling the exception information to registers. > 2. It starts exposing what looks like a more generic exception > handling mechanism to userspace, except that it's nonsensical for > anything other than ENCLU. Well, I see the user space and namely the run-time the host for the enclave i.e. middle-man to provide services for emulating instructions etc. /Jarkko