Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2961669imu; Mon, 19 Nov 2018 08:40:27 -0800 (PST) X-Google-Smtp-Source: AJdET5fWiJITqPpzo+h1N9adLdHj55/uNYLOKNH/ap+k0rGt07SNkUcL4WO32wgBTmec1Rmlq3pY X-Received: by 2002:a62:42d4:: with SMTP id h81mr23597404pfd.259.1542645626943; Mon, 19 Nov 2018 08:40:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542645626; cv=none; d=google.com; s=arc-20160816; b=AoyZPT7zX7cHtPrQLNAQG+29faKWI4lhwnkeMs7nvyqfEwjYAZFMisdUHQ7wzAM87Y l7ZpsY6nFQ/JcI3pT1IxeTVvl/iEuCc0dfXxbm+bU8b4HeMFU4GS2x5iVpvgVbf+BXg3 GRdUftiyXt0U/J+KR46iRVOIIzJ9dv2LZa9eSb5SLzxaPoChr1Alpvfp1XHYBv32mtja Wiyxmz4l7v1h5o1P+ODD4yfEbf/geip0yJlOnL6VFann2MMTr8lJwwj0ABnlDLjKX7H5 +saAxqlSJiOFiugTYdEIyQdHRFply1Xp48z6hX2TIACNTc4uKYQT1kJuJab9Vj53Czus butQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TX0mkiXibUO5V7CgbJ/95ozJRwmMO69VA/q4EkggIb8=; b=Zz6DauMh1XnKObeWjIEpY1gyINwYfHSUvAnMHpRysIXsmil6M6sHTWf8gX6L5LeIeJ 6/GrxFEYfsBLbexx2KCeGgjxb1IuFrOM1NT2/PwmuqDDEpcuwgGWOWYo8k/stlX6iGXT lsK0/n5i1KEiJ06B+P6KYukgcJy1kMWW7rSj2AFFnhWyusO7QR28lAVhzrXA6k63DbAm KZx6fgRVMiBRvFjnppMFXkrDYRnbi7l6qXkpXthAI5pjgABmuSaeJZ2RMHAv/Go1WD3+ iIXt3w5bbHsXuEsYQDiFHZyIjwzsqhff+W/8RAc+WCElJ7wyMl8F6pY//gvl1k9EHjVm 4JcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KrUOfwXG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2-v6si45566855pfa.150.2018.11.19.08.40.11; Mon, 19 Nov 2018 08:40:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KrUOfwXG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732395AbeKTDCR (ORCPT + 99 others); Mon, 19 Nov 2018 22:02:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:34496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731789AbeKTDCQ (ORCPT ); Mon, 19 Nov 2018 22:02:16 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 456A5208E4; Mon, 19 Nov 2018 16:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542645487; bh=oWCtfpi68nU95c62X41bkqd3ZvfdYleF9rXbC4jTux0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KrUOfwXGBVp86B1SZM5OW+q6t1d5UkWvNMnOCMNPGxLO8uLlyxdp5Ixv+LI0bv98Z 0MAPd9Q2qZe+2STFF0kA5OxzbKS5K+subF9uv1BSqVOSi3I7VAMTAfJZjonNECMQwR dIGc4cWS1tYyc05cBk/22cH0rC9UFpAHHvCkbaf0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lucas Stach Subject: [PATCH 4.19 180/205] drm/etnaviv: fix bogus fence complete check in timeout handler Date: Mon, 19 Nov 2018 17:28:07 +0100 Message-Id: <20181119162641.178596387@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119162616.586062722@linuxfoundation.org> References: <20181119162616.586062722@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lucas Stach commit 6fce3a406108ee6c8a61e2a33e52e9198a626ea0 upstream. The GPU hardware fences and the job out-fences are on different timelines so it's wrong to compare them. Fix this by only looking at the out-fence. Cc: Fixes: 2c83a726d6fb (drm/etnaviv: bring back progress check in job timeout handler) Signed-off-by: Lucas Stach Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/etnaviv/etnaviv_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/etnaviv/etnaviv_sched.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_sched.c @@ -93,7 +93,7 @@ static void etnaviv_sched_timedout_job(s * If the GPU managed to complete this jobs fence, the timout is * spurious. Bail out. */ - if (fence_completed(gpu, submit->out_fence->seqno)) + if (dma_fence_is_signaled(submit->out_fence)) return; /*