Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2973093imu; Mon, 19 Nov 2018 08:49:58 -0800 (PST) X-Google-Smtp-Source: AJdET5etLTlSJAHnbYs5eychOWvgyaReZa0KGqj5iAQ2fKNBmY6ODKi6pa/PXDTnsYIKNgp0ZKYF X-Received: by 2002:a62:d046:: with SMTP id p67mr20501906pfg.129.1542646198001; Mon, 19 Nov 2018 08:49:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542646197; cv=none; d=google.com; s=arc-20160816; b=vy+g6XbaJ9zal6AnOdp50M3dIn4XK3uJV+z4n9E0N/gOJZRyCrIcdE1Qo62YQnSK+C MxfvySD4YPQ6LEKz4SwXwHFlk3g+9UHXBG0amQpnkRa0TlClgG7LepyeIt/M8wo14w11 3HYTq3jNV9bFPslvJ3SgL5v9N/uPsxwxF88olpYc3oNkYYQfAdoFJQPNckaRJWKEKMQ2 fXhxFZXNx2y0lULcRfB+YPPaxEbIANUl3A/MTUhCf4PtPwrR8qh1hOl7zp72A22jfwPr k09GAvM4j+QRzQnyfhZ4Xql5965krZtJCkIW22FgJiO7d++UcgcKIaEVEf0gNJPpFfgf gZ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=slBAMgbzeMJCkt1jfYtjbwn7DCOjNbJiWWnKslmxFN4=; b=nEA+lvC3kPtRgIFAZstAc+7uZhsQy1TTZ9csh5iL8o2UEWEHurEzZcAJ198dibNgOI 8jyAwv+qzNikOAM6VNBee2XsxWzpZzta6LsrOsZPEf8YCjbNgYhwkmKg5E+PIxBH7v/p jlWQA9yK6erZavd97sAEjnLT1Ohz7d7Vedd6oBKEtMZSOoiQlsgTD++Z/wdJ57el/wP6 czF9R5FBb7q/YSJZAAH/hjPtlijYs/s6ahgXrfmC8NJtcISAavJVqvHtRF8cZKWtWNJN PQTm4QAELZKNUqk8vEzF+Cc8iwaKto0E4O63MuQGs+LRlNGdwwXAL3TnRwFo8a/QSUop wZBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DTVT44AD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33-v6si44834951plk.407.2018.11.19.08.49.42; Mon, 19 Nov 2018 08:49:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DTVT44AD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389175AbeKTDLw (ORCPT + 99 others); Mon, 19 Nov 2018 22:11:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:47926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389165AbeKTDLv (ORCPT ); Mon, 19 Nov 2018 22:11:51 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30C87206BA; Mon, 19 Nov 2018 16:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542646059; bh=6vM8VTpiu7OnQDkmjkItR2kotiU9Pie+zTji6FG2pmU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DTVT44ADrbrMv8+XBvdvlKp5Gop0qeACj7QpIpXmNBkC10IVgDKqxHVaQDgaDJPB6 7jnkXiK7zS+9nz2yZNdzzcUP7O+zk/FvIV5fovioMlbw5kN6DnKuJsYHPi10lEboTi zQcQL/UOw3GFHJnY4iLaY0YCXpcRVajb1RNpHDxo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexandru Ardelean , Jonathan Cameron , Sasha Levin Subject: [PATCH 4.14 020/124] staging:iio:ad7606: fix voltage scales Date: Mon, 19 Nov 2018 17:27:54 +0100 Message-Id: <20181119162617.429169927@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119162612.951907286@linuxfoundation.org> References: <20181119162612.951907286@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alexandru Ardelean [ Upstream commit 4ee033301c898dd0835d035d0e0eb768a3d35da1 ] Fixes commit 17be2a2905a6ec9aa27cd59521495e2f490d2af0 ("staging: iio: ad7606: replace range/range_available with corresponding scale"). The AD7606 devices don't have a 2.5V voltage range, they have 5V & 10V voltage range, which is selectable via the `gpio_range` descriptor. The scales also seem to have been miscomputed, because when they were applied to the raw values, the results differ from the expected values. After checking the ADC transfer function in the datasheet, these were re-computed. Signed-off-by: Alexandru Ardelean Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/staging/iio/adc/ad7606.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/staging/iio/adc/ad7606.c +++ b/drivers/staging/iio/adc/ad7606.c @@ -26,9 +26,12 @@ #include "ad7606.h" -/* Scales are computed as 2.5/2**16 and 5/2**16 respectively */ +/* + * Scales are computed as 5000/32768 and 10000/32768 respectively, + * so that when applied to the raw values they provide mV values + */ static const unsigned int scale_avail[2][2] = { - {0, 38147}, {0, 76294} + {0, 152588}, {0, 305176} }; static int ad7606_reset(struct ad7606_state *st)