Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2977470imu; Mon, 19 Nov 2018 08:53:39 -0800 (PST) X-Google-Smtp-Source: AJdET5dICKUjMGd+qN5yNTJqkn0/n27lX/8SvMFGv3QUDMBKgQgh5z40TSIjY/F/Ps4MKUw/tyr4 X-Received: by 2002:a65:434d:: with SMTP id k13mr20939235pgq.269.1542646419599; Mon, 19 Nov 2018 08:53:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542646419; cv=none; d=google.com; s=arc-20160816; b=aWrEKGO6flANwybJWFHUsuVnorclkGLbCtELhchuWK7Oy2fnxa384p5S/F4nQcTyxr WcK/sRCmotf4FR9wt6XiiW/1IhZKqN+NjTAGnGm94YSOs+x9CTLfdF8lLEw7jPnjbqT8 Q2uslJnmPeMRdODgwVLsL803D1HgebxXh4527EMe5TY+M4mVZ/Ag/DFwjbEld6wRGeXB HFR+6Zxkj/tLnM+3K+QG6I7dE0aymZpHhMgSIrsuHIneBmm1BJbsTHgjGOaJUKLzyHJu UFzciDpi/uG/NzU+hVHp7owhXfTHCCMfBaDqAKhyfRdD4h89Si28C5/vo2LjHmjpPy4J mIPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=f9VeEzGx0gKzmNk+JRhW708nwiudV93xTgmIA+uKIrQ=; b=ST4bDwdykA+080mLD7ox5HI3z9o/0cuUHZV1hE3D0eNL6wY/I82rb8yHz0HlOuZ7/P HThftXO9eSr3u0oRZQlLt+8TMihMRHeJuacDAVksNDz5wDaypOqQ7gqwpjK8zLztwtSJ rRetc8x8EtYplmcNP1LYCLUfvFEWidVRQHBH9TG+IiIqHyqILyxHUxHxu/0iy18SLE0a SUWCxhgUwbhD80fu7aMODdfW05hlI9/NVk/7bJm+jO7wnzezpmSFlBnKh/J9ieOUMwTF R85fBNSXXKt7mxAPHb7tjdi/frDyKjwwoSmbs5ljoCVZBWYO51+r1mX/Y9VIx4lZPIFr dPLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qEZpt90S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10si25377558plr.439.2018.11.19.08.53.24; Mon, 19 Nov 2018 08:53:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qEZpt90S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390529AbeKTDQ2 (ORCPT + 99 others); Mon, 19 Nov 2018 22:16:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:54366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389669AbeKTDQ1 (ORCPT ); Mon, 19 Nov 2018 22:16:27 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DAF120851; Mon, 19 Nov 2018 16:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542646334; bh=kk3GEKQ2L38lUvHkbsDGFRJs8N/sbl+sUGUFQSoOsVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qEZpt90SQiYVeFyI5YyswY+nqsm1E5aL48w2o3w8EHM13KMHww7gi9gyqgaAJVOKj F8BM/joH0kPdxpBNvT2QsdokeMzIj05HOzoxrLx8S7WE7gTqM9TIRgkv78CDChoCaB LbHMXWpEf1daCWwxMZtKY6ZhX7yBvW308Wkovyas= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sergii Romantsov , Chris Wilson , Lionel Landwerlin , Michal Wajdeczko , Joonas Lahtinen Subject: [PATCH 4.14 118/124] drm/i915: Mark pin flags as u64 Date: Mon, 19 Nov 2018 17:29:32 +0100 Message-Id: <20181119162633.545048385@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119162612.951907286@linuxfoundation.org> References: <20181119162612.951907286@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Wilson commit 0014868b9c3c1dda1de6711cf58c3486fb422d07 upstream. Since the flags are being used to operate on a u64 variable, they too need to be marked as such so that the inverses are full width (and not zero extended on 32b kernels and bdw+). Reported-by: Sergii Romantsov Signed-off-by: Chris Wilson Cc: stable@vger.kernel.org Reviewed-by: Lionel Landwerlin Reviewed-by: Michal Wajdeczko Link: https://patchwork.freedesktop.org/patch/msgid/20181102161232.17742-2-chris@chris-wilson.co.uk (cherry picked from commit 83b466b1dc5f0b4d33f0a901e8b00197a8f3582d) Signed-off-by: Joonas Lahtinen Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/i915_gem_gtt.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) --- a/drivers/gpu/drm/i915/i915_gem_gtt.h +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h @@ -584,20 +584,20 @@ int i915_gem_gtt_insert(struct i915_addr u64 start, u64 end, unsigned int flags); /* Flags used by pin/bind&friends. */ -#define PIN_NONBLOCK BIT(0) -#define PIN_MAPPABLE BIT(1) -#define PIN_ZONE_4G BIT(2) -#define PIN_NONFAULT BIT(3) -#define PIN_NOEVICT BIT(4) +#define PIN_NONBLOCK BIT_ULL(0) +#define PIN_MAPPABLE BIT_ULL(1) +#define PIN_ZONE_4G BIT_ULL(2) +#define PIN_NONFAULT BIT_ULL(3) +#define PIN_NOEVICT BIT_ULL(4) -#define PIN_MBZ BIT(5) /* I915_VMA_PIN_OVERFLOW */ -#define PIN_GLOBAL BIT(6) /* I915_VMA_GLOBAL_BIND */ -#define PIN_USER BIT(7) /* I915_VMA_LOCAL_BIND */ -#define PIN_UPDATE BIT(8) +#define PIN_MBZ BIT_ULL(5) /* I915_VMA_PIN_OVERFLOW */ +#define PIN_GLOBAL BIT_ULL(6) /* I915_VMA_GLOBAL_BIND */ +#define PIN_USER BIT_ULL(7) /* I915_VMA_LOCAL_BIND */ +#define PIN_UPDATE BIT_ULL(8) -#define PIN_HIGH BIT(9) -#define PIN_OFFSET_BIAS BIT(10) -#define PIN_OFFSET_FIXED BIT(11) +#define PIN_HIGH BIT_ULL(9) +#define PIN_OFFSET_BIAS BIT_ULL(10) +#define PIN_OFFSET_FIXED BIT_ULL(11) #define PIN_OFFSET_MASK (-I915_GTT_PAGE_SIZE) #endif