Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2994016imu; Mon, 19 Nov 2018 09:06:40 -0800 (PST) X-Google-Smtp-Source: AJdET5csq7yJZC22VyxtT5G5J9sbwYA09UWlaHPD/vQTaMVo0ZvdCp6Jzb64tXm9dBiEfaPMMGRM X-Received: by 2002:a63:1321:: with SMTP id i33mr21169237pgl.380.1542647200029; Mon, 19 Nov 2018 09:06:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542647199; cv=none; d=google.com; s=arc-20160816; b=U8T/WELJmwR9ngWZDeEGDBKCFVl9k3geunzV75n4QsmMXg6SB4gUjxbQ990gYCwQZf LJ0+ccs3Pjr1+hJ5zVWoNyl3m5Qgbt5ZTSfn9hZG+B/0Yq6arNuJxibbsOvdxcXkTYD4 CWskDgB+nGOCH9uTXCPKGIYCL2mcONDdCXNLrkLqLM9AbBUzjuXlvH7RyWlMzIf693Zh YSLZ6mrNy32I0zysy9NBIyXafEJ7M3DJfS5ZuFQQbgASyvdYrgBGNhTLu+qwimRRJzbP XXHy73neP18UcieW+8dqLGds/xcoZUOs9xm80Yo2mdrIbiPZfklMZUz+oq6QiIosnKP3 IzIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fDSbRtwijuBQMPOU6ZHQDkF5F3SxzzMgF/RgWLxSOjQ=; b=Xou3v2RpcsrtGZ+4kyd/+M0uAyqfrmY71Tk0NulB/YVQdzNMTf7GnG81InM3c5BfTp U7P8uxZB1T98rSU/knckezNUX2YjLhaFmMB8Ym3VbTWTCpgs7YkHmt7nD001GID7mWO3 VQv/7i/sw2igwIQPIJcBNdwngF41JkEY1GofPAgQ5g+PjX5e+p6yhMBvixVZu0Bybm5U Hz9ZBATSK1eVVKqzTdsH6odckQV351MPzY1AXz97FY3EC9uQBfp+ZEy/76JtQIfsTKuR sLLPGPPnjrqKJNgepUwAGLfxc9V/lzxA5kgfGpTOQaS+totYy51CEYmF8qNfmcOhCDun n2ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I53b4DEp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4-v6si3384053plt.315.2018.11.19.09.06.22; Mon, 19 Nov 2018 09:06:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I53b4DEp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406694AbeKTD3P (ORCPT + 99 others); Mon, 19 Nov 2018 22:29:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:43874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405697AbeKTD3P (ORCPT ); Mon, 19 Nov 2018 22:29:15 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5001C2148E; Mon, 19 Nov 2018 17:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542647097; bh=EK2wsdX/dYU0HvW/ToQqHYcN4kS3HbqDUy3jiWjAO+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I53b4DEppKL64mjl9dAa8YPVKz+Um5AjvSgE4zf7emM4c3LCPtOruIrSOYnNhIXH/ HIBDQfpBYkS2WpaJF2HiPikeDMZzyeyjK3NBlQNUaJo3z17wsW4Yg75+TVUWrgJvW0 Q75MIwaTFbnByX1kTay2FCeSgmgf+EvM6wSducG0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mauro Carvalho Chehab Subject: [PATCH 3.18 49/90] media: em28xx: use a default format if TRY_FMT fails Date: Mon, 19 Nov 2018 17:29:31 +0100 Message-Id: <20181119162628.749178578@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119162620.585061184@linuxfoundation.org> References: <20181119162620.585061184@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mauro Carvalho Chehab commit f823ce2a1202d47110a7ef86b65839f0be8adc38 upstream. Follow the V4L2 spec, as warned by v4l2-compliance: warn: v4l2-test-formats.cpp(732): TRY_FMT cannot handle an invalid pixelformat. warn: v4l2-test-formats.cpp(733): This may or may not be a problem. For more information see: warn: v4l2-test-formats.cpp(734): http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html Cc: stable@vger.kernel.org Fixes: bddcf63313c6 ("V4L/DVB (9927): em28xx: use a more standard way to specify video formats") Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/em28xx/em28xx-video.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/media/usb/em28xx/em28xx-video.c +++ b/drivers/media/usb/em28xx/em28xx-video.c @@ -1280,9 +1280,9 @@ static int vidioc_try_fmt_vid_cap(struct fmt = format_by_fourcc(f->fmt.pix.pixelformat); if (!fmt) { - em28xx_videodbg("Fourcc format (%08x) invalid.\n", - f->fmt.pix.pixelformat); - return -EINVAL; + fmt = &format[0]; + em28xx_videodbg("Fourcc format (%08x) invalid. Using default (%08x).\n", + f->fmt.pix.pixelformat, fmt->fourcc); } if (dev->board.is_em2800) {