Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3000817imu; Mon, 19 Nov 2018 09:11:37 -0800 (PST) X-Google-Smtp-Source: AJdET5e2edaULP40WBsq4YJto6KNGVH+7n5pp3OoNeux8EPU1uMZLdJG6MbMNvBugr3on/8cK7l0 X-Received: by 2002:a17:902:bd46:: with SMTP id b6mr23067730plx.231.1542647497127; Mon, 19 Nov 2018 09:11:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542647497; cv=none; d=google.com; s=arc-20160816; b=A+56wJJLybjBtwy+JYOqgrM/x9AM92xyVryElhYS08+RRbU+hJ5oZ/iv6qoZEeZWJv ZOg3xXvtS3O2Hb7Y55/xG4eQnTYtjRzOVQgB1fo6gFcbTSBHZgN3BoPfMKQ37ObzcTwU C0+iTwiPKU0Rw+uwHhDo7/Fz2936cOXNr13LYEpokKF5sRDIefjo4y6VVdCupRXvQPIb CxGEFtl9A7rueP10bn/YhZoZr7M81mGUiXDGN6QK8HAkDh3dqc1hJ2dGAoBIP524wLjg 5vLQwn0AQ+xmeAXPFlIYAkeBPnjXjmf9ZZvq19fga4fy1468hWsbAUoCcj9hfMeOX6tR fLLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=R+Dpq23IopkXmE6QZMsX2ekXnOEkIXip6NosX+fi66E=; b=Z70FRsPqLqimuOJ430N99CecZZmADJh1Yq1DvE70MgX7WZOMagdqnnhq3QI6SlqKDB IyoblqUPN7HUCqsqlcImbERUniTQLdF9YUVMq0i6CQb/fmMHhwoBiqLhCT0AVw3MaJFd m6cTh/a6kGJSPz8ekz2mrd3ugwReTuaMxHu5eJYM6S3akEks/Wi1O/gfXetqYlgUXnUt jtR2OwZCY/bUbKx9HNXJL8eUeDBb7tuCBjsKFhZeXBN0F5kGefWY1Y8VN1cNiPWvLIfs U0XDC+nT+Fa97yoi0sBWvG9oxb2L8SmhXCIIYF1hnQTUhIh8JFUqN9Wm7ITWhMPqEMj5 tBFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VDYh8njh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s17si39095386pgi.513.2018.11.19.09.11.18; Mon, 19 Nov 2018 09:11:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VDYh8njh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406940AbeKTDaI (ORCPT + 99 others); Mon, 19 Nov 2018 22:30:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:44982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406252AbeKTDaF (ORCPT ); Mon, 19 Nov 2018 22:30:05 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25EB62148E; Mon, 19 Nov 2018 17:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542647147; bh=WFgjdxfefbOILBdaRWnD3+8zuXkKui0H3Z/m0vIRy/M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VDYh8njh4j1uWRi+YohG3ZjSByK82vVUU9gt3mQmKBx7GFvzhcE0js2nq4RhtE/Yo 0WkGtinvyqurjOuIlq4nxl76QOwu7neW5sdodFheVpOzeaatKZCeplnRcY9CECNkOh wPKOAKe03+RICSr6dyZFtLtMpHOGFDcS6ByeF94s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+c54f8e94e6bba03b04e9@syzkaller.appspotmail.com, Al Viro Subject: [PATCH 3.18 30/90] gfs2_meta: ->mount() can get NULL dev_name Date: Mon, 19 Nov 2018 17:29:12 +0100 Message-Id: <20181119162625.791222977@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119162620.585061184@linuxfoundation.org> References: <20181119162620.585061184@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Al Viro commit 3df629d873f8683af6f0d34dfc743f637966d483 upstream. get in sync with mount_bdev() handling of the same Reported-by: syzbot+c54f8e94e6bba03b04e9@syzkaller.appspotmail.com Cc: stable@vger.kernel.org Signed-off-by: Al Viro Signed-off-by: Greg Kroah-Hartman --- fs/gfs2/ops_fstype.c | 3 +++ 1 file changed, 3 insertions(+) --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -1358,6 +1358,9 @@ static struct dentry *gfs2_mount_meta(st struct path path; int error; + if (!dev_name || !*dev_name) + return ERR_PTR(-EINVAL); + error = kern_path(dev_name, LOOKUP_FOLLOW, &path); if (error) { pr_warn("path_lookup on %s returned error %d\n",