Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3013356imu; Mon, 19 Nov 2018 09:21:20 -0800 (PST) X-Google-Smtp-Source: AJdET5ffiQj5vty7WeS/WdzkMpbEqqlt65JNNZ9ne8E00o6k8n1oidx85SrrBxnl7gW9qCj/oQ4i X-Received: by 2002:a17:902:8346:: with SMTP id z6mr23126212pln.340.1542648080152; Mon, 19 Nov 2018 09:21:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542648080; cv=none; d=google.com; s=arc-20160816; b=hwo8STv7c/Bdg6iO2J1ch2r520R5OFojbRiuwr2veKR+mS+RY29W8q99IgNyMQp/1x qquKwpH2MEfnD/VuzWVWGivkjm5/WA8RJFAbi2JHWxc/VmwbAlZcWXleUAU8ukK+b9kA phFim+vbBXOfC+3UC9PCnHO6/2Axo0qwmgvsLgOZduFCK+A5IUUWPVMy94IZM4KwN186 mO7trjci72Jig1M1c7Of8LsQq9UwEkPqe3nT4sabWjq98R/LoNSRT6nb29SbqhpEy4wG 84T3AeraN74m2PqAJEVuYKloMHMsgahP1DmdF2/AjigHQDMmaMqRWy7mdfFQGAh7/XBQ V3Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=W4fRazBtZEwMsRMOs4Geju9utyk8rMvZtwtzYUAZ/aY=; b=jg73UT4wh6WfgXrcSXtX8F8uXx0NgDIJ07TjWxX7IrEs3HBFZXGvCXIJmJyIJ1TKoo V3VbpVpflsVnbP40qFc1rLiD5jTf9NTp3r97M3QDwbtyT6oCqUGvwzdlxYd2Wjh/lpg7 hHGpjg6lZ2uyHh5wM/jh5TYrydc2UKZA7VhpDnS8xjR7sockkzTJ6gZWrh2trZOFFTQ0 gx9ptiJHzLcKkWUixtzNfA5Y0vBfEIUToxoYXuH31JIuLLTYo2YlY9JOKecMK3HR6yFI /jDfZVmmwhiCjjCdQ3oWzTns/jUMx1n1q0k2gLaMeYP4MTatS+lXyjitUKI5r04IQKmw 3OFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ndQ7+afn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16si39544388pgh.58.2018.11.19.09.21.04; Mon, 19 Nov 2018 09:21:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ndQ7+afn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405416AbeKTDYv (ORCPT + 99 others); Mon, 19 Nov 2018 22:24:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:37766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405032AbeKTDYu (ORCPT ); Mon, 19 Nov 2018 22:24:50 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9B3221731; Mon, 19 Nov 2018 17:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542646834; bh=l5Yr9yY8mQsv0yLJT3gH2+2coK5Kgi7pOiImeUfFtOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ndQ7+afn7tJQvPk3y03WqMVgGAkSfMdjpmOMxgsdhaPlKcFUGY5pbbtIsvF8CUfT7 f2KdmM/1W5AJcO+Az0rBnAT8GHbZmriBYiNnf3uHvN7oe8pSwdUMeUQPnvayTVrma6 qyy9HCzJyvDeDp2icxOHuPfPmYLT7edooLcANpJA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Amir Goldstein , "J. Bruce Fields" Subject: [PATCH 4.4 070/160] lockd: fix access beyond unterminated strings in prints Date: Mon, 19 Nov 2018 17:28:29 +0100 Message-Id: <20181119162638.083297780@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119162630.031306128@linuxfoundation.org> References: <20181119162630.031306128@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Amir Goldstein commit 93f38b6fae0ea8987e22d9e6c38f8dfdccd867ee upstream. printk format used %*s instead of %.*s, so hostname_len does not limit the number of bytes accessed from hostname. Signed-off-by: Amir Goldstein Cc: stable@vger.kernel.org Signed-off-by: J. Bruce Fields Signed-off-by: Greg Kroah-Hartman --- fs/lockd/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/lockd/host.c +++ b/fs/lockd/host.c @@ -340,7 +340,7 @@ struct nlm_host *nlmsvc_lookup_host(cons }; struct lockd_net *ln = net_generic(net, lockd_net_id); - dprintk("lockd: %s(host='%*s', vers=%u, proto=%s)\n", __func__, + dprintk("lockd: %s(host='%.*s', vers=%u, proto=%s)\n", __func__, (int)hostname_len, hostname, rqstp->rq_vers, (rqstp->rq_prot == IPPROTO_UDP ? "udp" : "tcp"));