Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3017118imu; Mon, 19 Nov 2018 09:24:27 -0800 (PST) X-Google-Smtp-Source: AJdET5ciZOm/A4cXrOIDat7LHTwfPbpU4XHDxgVZH/uV5xkGwi0qlfZXFFTIUfc8aGbjQVMmQQz2 X-Received: by 2002:a63:c051:: with SMTP id z17mr20483109pgi.20.1542648267655; Mon, 19 Nov 2018 09:24:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542648267; cv=none; d=google.com; s=arc-20160816; b=z4XM6+qy1LxBIcMpqBt0SRwl0Y+0dLJu5bYF2SNnR0u5hCYG79ab/xnBmnmdT9AFtc BumoUbAmYBkXHVgelW3CJJoEVsXJ6D5kIUpKRLGTSrXGOr1At8lOVj5ZyYdVt6n4Mxba 2B69Oti+GhdQzW4TX0V2d/zpTpXPck8fMz72XMJbBw0ZIQYAi5m6I8/jj4Mkn5lyfMfH 7AlsjX9HZVUbQggxTbFbbAAujLlEAXANEGwm+xhoaWmaLbetAkQeIdDlBVC2UQ9nwlMv QwKm4lvIHdOFQAaF2hDnsUlAxa+TksUhIIBlEocmo0dZGtYCkoXaWgk48EuOcBUc6Eqb xnSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=raXr2eIEcM/Asw1PH1cg7gxHTcBKR9DP0hbUYwgNdqw=; b=OTrn11VzcuIhVfTRWKTsR+BnYI5ebs0MG5K0OF0arZBcuV2FrGmAq7Ih7GFE/p1tVg UeCcYgeVk+cq5on89Z1OzKyzlcvIrKphwho5lX5kuQsfsfvhJM6A/nElDQRH0cwU89bc 4VWk+m6Oi06SSW0XuyRMxabOhW+Ue5M42jac7dIHzVC98VoeOSpf1DeumWkmvuTqjfys mokrmsL0Z/uo860b6vXJc/gusBT9SWpN3b8f3KEDhOsMn5Pr1NU5PfVuK5WVEcJgolkz oj3YtE7YbK8WEkzVSOlmFHJeWn1QDqkZOwzyf0KdLJhl8JKnprVrvXOC9Hhcr1+w4SE4 qbXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cl3BH3aR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16-v6si27418334pfm.51.2018.11.19.09.24.05; Mon, 19 Nov 2018 09:24:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cl3BH3aR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404718AbeKTDWV (ORCPT + 99 others); Mon, 19 Nov 2018 22:22:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:33964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403845AbeKTDWU (ORCPT ); Mon, 19 Nov 2018 22:22:20 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF20C2148E; Mon, 19 Nov 2018 16:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542646685; bh=+MFj62VTLZi1Iy+VVFJ+U7l7vvFLXno+py6p6b6XwAs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cl3BH3aRs0PDhuP7Ey2WiGuFb/K8icB60XQZCwlxJjFTj64Y9ivm40XvfkljJqpyy ZX9liGAgxtxYhE+RPFs99l61zLZN2130IfwtaigeX0Rr8sLsOaWQgBxIG8S7tnAJ22 rylwDBnJJGE6Ko7qHASYrGWXCnyw7uugHtOtU5XQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+c54f8e94e6bba03b04e9@syzkaller.appspotmail.com, Al Viro Subject: [PATCH 4.4 051/160] gfs2_meta: ->mount() can get NULL dev_name Date: Mon, 19 Nov 2018 17:28:10 +0100 Message-Id: <20181119162636.515140005@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119162630.031306128@linuxfoundation.org> References: <20181119162630.031306128@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Al Viro commit 3df629d873f8683af6f0d34dfc743f637966d483 upstream. get in sync with mount_bdev() handling of the same Reported-by: syzbot+c54f8e94e6bba03b04e9@syzkaller.appspotmail.com Cc: stable@vger.kernel.org Signed-off-by: Al Viro Signed-off-by: Greg Kroah-Hartman --- fs/gfs2/ops_fstype.c | 3 +++ 1 file changed, 3 insertions(+) --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -1353,6 +1353,9 @@ static struct dentry *gfs2_mount_meta(st struct path path; int error; + if (!dev_name || !*dev_name) + return ERR_PTR(-EINVAL); + error = kern_path(dev_name, LOOKUP_FOLLOW, &path); if (error) { pr_warn("path_lookup on %s returned error %d\n",