Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3066767imu; Mon, 19 Nov 2018 10:07:26 -0800 (PST) X-Google-Smtp-Source: AJdET5efJObgz8GwdYV/fBXX9wJy0saPCxOJIViZdKDv516wL1LMgb2Dh8cC3xMbmcPwcUZCMkpe X-Received: by 2002:a63:cc12:: with SMTP id x18mr20814638pgf.33.1542650846338; Mon, 19 Nov 2018 10:07:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542650846; cv=none; d=google.com; s=arc-20160816; b=llGW777HLhEE7Rc/YTNEbi9KIqwNbFqYqQsIcaboRGzeFCjZOURovM0NXif8Ydnx+H 9Gr3WT4F/DRHsEi/9i7XTI+Ak1uqh2aF1B7SVrSPppbri+KeWDQG6vXd+S5bdC1N5LEH 3QtHxYlLKPRylN+Eg6VrrGD4qZa1J1DlvfQnSexKB7AzphG0xy+9SwTSEsxVNtyFD4RH YSjcZG/2/uASSsRYa0WyU3ExIb/ZaIMyb8bFG1o4OARj/PVG6Slaew9Lm5ZYlbjzbmem eOjBld/R9Ryf8pH9QgI4ZY73F+MbULI6c15Tuwzn2EpBt9LYJA5iGoVu1fWn25NiVA5v qx1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w8Me3SdV4Fo20GzmbfGaQl+asHvfAyVbQofkZGY4KEs=; b=QOHSJ7pVx9U0t/8iwfE0T5E5BRJ1MPGXWf2+kbXYkQvFOxDmn84fUtfUQbFsGcppRY TZ1z00YTKPnWRCn1amZNy/owu1ttMmceeLEqml1b8upAns+SkhJKotqciFUkzfEokN9X puXWuE10+jZgWOlUQCjUhVTiK8HBY50KXTEXJ+UDwqObPojZszPxnIF91zWdilFuBFi4 FFQOHYGe88IYBgR4vgfLqk0y0EwFRhiIjYaZhJfdemLN8bE9mp9yU2o9O7wFQ2l/UANo AYxEMzg9LnB4kd0c6GDwj8F3b9JDBu7tftM3GLyPo9on6Orpk5ipxzWdUS0Zp0LL0Owo f8aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="qX0nZ/4t"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1si1723156pld.92.2018.11.19.10.07.11; Mon, 19 Nov 2018 10:07:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="qX0nZ/4t"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731021AbeKTC5P (ORCPT + 99 others); Mon, 19 Nov 2018 21:57:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:55794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730994AbeKTC5O (ORCPT ); Mon, 19 Nov 2018 21:57:14 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAEE220870; Mon, 19 Nov 2018 16:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542645187; bh=pIjE03AXdBEJ6/ozBXc7uVxMdpt+sHAZo+b6Sb7Kpoc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qX0nZ/4tkcz5njXMr8T+Qauxq6Eb6eDooBnIfuKAMEGJOjUoYadnEHFtJuUfB0ZBm TnEiLbKsiXT1eZnldZ/XhsTwtnFEWEDnxoji1Fqrk6CV1gvA5xrWJf5ieNjBuvFe0j 7lLMGxaWuAwB2YJr4Q9RAp4xr4+cMWIUCVVdXzys= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nick Sarnie , Nicholas Kazlauskas , Harry Wentland , Bhawanpreet Lakha , Alex Deucher , Sasha Levin Subject: [PATCH 4.19 020/205] drm/amd/display: Raise dispclk value for dce120 by 15% Date: Mon, 19 Nov 2018 17:25:27 +0100 Message-Id: <20181119162620.982335916@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119162616.586062722@linuxfoundation.org> References: <20181119162616.586062722@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicholas Kazlauskas [ Upstream commit 481f576c6c21bf0446eaa23623ef0262e9a5387c ] [Why] The DISPCLK value was previously requested to be 15% higher for all ASICs that went through the dce110 bandwidth code path. As part of a refactoring of dce_clocks and the dce110 set bandwidth codepath this was removed for power saving considerations. That change caused display corruption under certain hardware configurations with Vega10. [How] The 15% DISPCLK increase is brought back but only on dce110 for now. This is should be a temporary workaround until the root cause is sorted out for why this occurs on Vega (or other ASICs, if reported). Tested-by: Nick Sarnie Signed-off-by: Nicholas Kazlauskas Reviewed-by: Harry Wentland Acked-by: Bhawanpreet Lakha Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c @@ -466,6 +466,9 @@ static void dce12_update_clocks(struct d { struct dm_pp_clock_for_voltage_req clock_voltage_req = {0}; + /* TODO: Investigate why this is needed to fix display corruption. */ + new_clocks->dispclk_khz = new_clocks->dispclk_khz * 115 / 100; + if (should_set_clock(safe_to_lower, new_clocks->dispclk_khz, dccg->clks.dispclk_khz)) { clock_voltage_req.clk_type = DM_PP_CLOCK_TYPE_DISPLAY_CLK; clock_voltage_req.clocks_in_khz = new_clocks->dispclk_khz;