Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3076037imu; Mon, 19 Nov 2018 10:15:12 -0800 (PST) X-Google-Smtp-Source: AJdET5ek8tfBCXrCNK12VHVeb4O1x7FFt+nDUHku0hZ2f2OinQ0vIJl+hWayyc7I4HDUfDcALVzL X-Received: by 2002:a62:85:: with SMTP id 127-v6mr23769442pfa.24.1542651312895; Mon, 19 Nov 2018 10:15:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542651312; cv=none; d=google.com; s=arc-20160816; b=gSYegqhJoZEvpC8juiMVLNpFAvq422H2ycuuhEC2V0Adeva4I5RdBLnvM3DVyDpDcN 7eKvzNWJrBePQwqsrxbg7yFvAsuhvy2Sa/Vmg+DfjsnLb0VnKHwwsfBmsNv77qC5wSoY sh7Ti3sy1b11nzt70FB4qYx7L3eNRXBmNxVSVSdgk1n33+Sni7/2idIiv4ZJLdF1eUqD whDpySyV3CyEp6Hl9V70aMqxGXxxIcrihFOWtE5IYB8wzpGbKbQWLxtQywxDFGbg9aK9 m20SlO97sCku5mi5CqSD9D68fq61cHvZJNBpVY58lqxuF/q+NkXHMzydyHf0V9U0Qo7S DBlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=6W32WSnvIwjpVkVMJW6FpWiLc8H69hjtMxr2k8H6BBQ=; b=Q+vyBs+CvoNauxRQLfv1xAT88tfzybT9SHhGmAKgozBYUURj/6jg1KX4uJKUWJQhN9 sbtOPG5BCJo/bXS6xXjot24/K21+8TyzJarYtG84JLvGsvhT5sY3H9gQ0+tlFKaMjhAi f+m5FHAIKP3OuB28c1HRnpLHYlPDmKf+4nT4IbZBXpK7Ys3sjJGwd54ea2JeWKFhQlDF 3StBveFRDnj86z2T8EL0sziU9id5lknLSKTLBYdcoLt3v8fn/IxXd4c1Rebz4Wo5m6jF sAhnqiE3xs48ElWA4Jt1tmp8ODQiuyKoqYYnIto9VFQhr6I3uO/f7A8ay0+BxajAasl8 0jbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q73si21219557pfi.205.2018.11.19.10.14.46; Mon, 19 Nov 2018 10:15:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730102AbeKTEir (ORCPT + 99 others); Mon, 19 Nov 2018 23:38:47 -0500 Received: from mga07.intel.com ([134.134.136.100]:60223 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729975AbeKTEir (ORCPT ); Mon, 19 Nov 2018 23:38:47 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2018 10:14:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,253,1539673200"; d="scan'208";a="87643713" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by fmsmga008.fm.intel.com with ESMTP; 19 Nov 2018 10:14:06 -0800 Date: Mon, 19 Nov 2018 11:10:51 -0700 From: Keith Busch To: Sinan Kaya Cc: Tyler Baicar , mr.nuke.me@gmail.com, austin_bolen@dell.com, alex_gagniuc@dellteam.com, Shyam_Iyer@dell.com, lukas@wunner.de, bhelgaas@google.com, rjw@rjwysocki.net, lenb@kernel.org, ruscur@russell.cc, sbobroff@linux.ibm.com, oohall@gmail.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Linux Kernel Mailing List , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 0/2] PCI/AER: Consistently use _OSC to determine who owns AER Message-ID: <20181119181051.GA26707@localhost.localdomain> References: <20181115231605.24352-1-mr.nuke.me@gmail.com> <20181119165318.GB26595@localhost.localdomain> <74f2c527-0890-5e14-5e2d-48934a42dae6@kernel.org> <20181119174127.GE26595@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 19, 2018 at 12:56:56PM -0500, Sinan Kaya wrote: > On 11/19/2018 12:41 PM, Keith Busch wrote: > > > Still, breaking existing systems that rely on HEST table is not cool. > > > I'd rather have users specify "pcie_ports=native" to skip FF rather than > > > having broken systems by default to be honest. > > The pcie_ports=native work-around ignores FF to potentially unknown > > results, though. > > > > How about being able to enable/disable FF in BIOS? > > We can't really turn off firmware first in the kernel without asking help > from the firmware. The _OSC method this patch utilizes is the ACPI spec defined way for the kernel to wrest control from firmware. BIOS specific menu settings shouldn't be our only recourse when we have a spec authority defining generic OS interfaces to accomplish the same thing. Unless there is a disagreement on the _OSC interpreation, we'd have to accept that platforms breaking from this patch are non-compliant. > Like you said, it causes unpredictable results. > > There will be two competing software trying to touch the same registers.