Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3169794imu; Mon, 19 Nov 2018 11:46:18 -0800 (PST) X-Google-Smtp-Source: AJdET5eUL6cXxdFmEeoRQ2irJdAza/4ZW+qrKw3Apn0gpEDbSYYx7fXuBiKsJ2QagjIJgEUSmf/t X-Received: by 2002:a17:902:868b:: with SMTP id g11-v6mr20737957plo.96.1542656778306; Mon, 19 Nov 2018 11:46:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542656778; cv=none; d=google.com; s=arc-20160816; b=fQLNIR46eFlVgIrt97NOht4ek74DB2L0n5akdXkC8UG4sQXfLwI02BW6Y/pgjdLsFE MGdKL/rQzlfCTUpx2Ufo38Vpdeo745iW7cuxMI2RkMayWCCFESfsWub7nLlo73uzsAtO Bm1U019AhDN6dEO9MmBaIO8DAW1aPhGKcelaFxbI/iLxCRRA0y3WCZWMR5bSdQj+mf7x Ks/JKZRBtYclV5AUf4wUPs/PaqU+2PnZmx2Z1/4opWXrQD/bGMZOotemaE7DcNGvrU4h upyEFdCjetYqOQAgFvmljJCSHjm4hQw6HP9fGO52p3RQGUxq8t+oyphrRtIgGhU5Gp91 zQfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature; bh=Gs0NvFcUJxnHUvsqBpDe00I6FfdfD4FknGEFh4wDtZw=; b=u+n8jaGrOsF1voo/qgZV2+WPykA34m+Mw/6mWXGrhwJ6bMqGgFXCwuzsmIi9Um3OGK xNweeWvxVj7jM7VIjTGz2FJ7+5K7fMXUkEh2IshIPchXvyE2EaIsAIGpv2MZCYwx/kwz vKOZg5qCZKJ3GpF+Rj4+/X2u/CDJqWgjxBsWi+QrWnOW6GJB33GG3sjykKjBuiZP0pqz RE8CDsRon1W46zVc6fOG/2Hb8teSDNt+zEQpop+aUWRpKCDVEKQ5RJW5RzQq/2/wKGwd vKoYl+sdhRHrJHYAjeI3IYWB62uu7iPZaj8PQm63KzHj287Z9Mr0iPFeIIasveAmZzKe 8bnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=0DbZVIFl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f189si11289912pfg.123.2018.11.19.11.46.02; Mon, 19 Nov 2018 11:46:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=0DbZVIFl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730174AbeKTGKZ (ORCPT + 99 others); Tue, 20 Nov 2018 01:10:25 -0500 Received: from mail-eopbgr700079.outbound.protection.outlook.com ([40.107.70.79]:63712 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726668AbeKTGKZ (ORCPT ); Tue, 20 Nov 2018 01:10:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gs0NvFcUJxnHUvsqBpDe00I6FfdfD4FknGEFh4wDtZw=; b=0DbZVIFlv50Lcpv8CRz+f286BnQGIkali5/XTuiGU8/S3RNrR3fuptQYpvE12iawXWw20L40d9OlaAatmjP/xiw4xSzGyW+4uYmkYZ3qqvc3W8wAbAtTjy4dpBkPaZqIGP5p3daJqDyRzKZOQNAxY56+prEP2BDi1TXmio39Kkk= Received: from BY1PR12MB0406.namprd12.prod.outlook.com (10.162.146.27) by BY1PR12MB0469.namprd12.prod.outlook.com (10.162.147.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.25; Mon, 19 Nov 2018 19:45:16 +0000 Received: from BY1PR12MB0406.namprd12.prod.outlook.com ([fe80::94cb:cedf:281:79f2]) by BY1PR12MB0406.namprd12.prod.outlook.com ([fe80::94cb:cedf:281:79f2%6]) with mapi id 15.20.1339.026; Mon, 19 Nov 2018 19:44:55 +0000 From: "Zuo, Jerry" To: Lyude Paul , "amd-gfx@lists.freedesktop.org" CC: "Wentland, Harry" , "Li, Sun peng (Leo)" , "Deucher, Alexander" , "Koenig, Christian" , "Zhou, David(ChunMing)" , David Airlie , "Li, Roman" , "Cheng, Tony" , Daniel Vetter , "S, Shirish" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] drm/amd/dm: Understand why attaching path/tile properties are needed Thread-Topic: [PATCH 2/2] drm/amd/dm: Understand why attaching path/tile properties are needed Thread-Index: AQHUfgOYyVVCIfDxYkK68ANZTiJrdKVXgzAQ Date: Mon, 19 Nov 2018 19:44:55 +0000 Message-ID: References: <20181116232443.1709-1-lyude@redhat.com> <20181116232443.1709-3-lyude@redhat.com> In-Reply-To: <20181116232443.1709-3-lyude@redhat.com> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerry.Zuo@amd.com; x-originating-ip: [165.204.55.250] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY1PR12MB0469;20:f6ZtcW9i12vxo+AYpDkJWtV9Lngt4rV6CAq0eZKVLTzaeCtIoy+vXi7v+6DBAuQyFJbNqRvZnWLI2D62OWgccFKMYKQ+X8wwHTb+5OFhYA6jWnAAEkMGTkFVIU0bda4Kr+wzngmgLe9WgyuoAch4WOi6XPmdrCO4yMZLsq9dDLliDUUeMVqU3M+J5hlFDphu3UHF8VBm3Y8XDCSY4yagJ/bZ47dNm8n1ivu3Nns0Gm78o+5Izx+ysU09hyLn+6eH x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(346002)(39860400002)(376002)(136003)(396003)(366004)(13464003)(199004)(189003)(53936002)(71200400001)(575784001)(99286004)(71190400001)(4326008)(25786009)(6246003)(54906003)(3846002)(110136005)(6116002)(486006)(11346002)(68736007)(305945005)(2906002)(476003)(446003)(9686003)(86362001)(66066001)(55016002)(7736002)(316002)(5024004)(74316002)(256004)(72206003)(6436002)(186003)(105586002)(106356001)(478600001)(5660300001)(14454004)(26005)(7696005)(76176011)(2501003)(53546011)(2900100001)(229853002)(6506007)(81166006)(8676002)(81156014)(97736004)(102836004)(8936002)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0469;H:BY1PR12MB0406.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-office365-filtering-correlation-id: 9aadaf73-76e7-4c62-a35c-08d64e577b23 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:BY1PR12MB0469; x-ms-traffictypediagnostic: BY1PR12MB0469: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231415)(944501410)(52105112)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095);SRVR:BY1PR12MB0469;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0469; x-forefront-prvs: 08617F610C received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: TZN6AfIIiCswPEPgNdD5xTzzDhuM23U+HJaXb24kVk+kFKGJAz3H8YqBBsADkuPDlxbezC76+vcQVsxJcHQ19MZJiEdnLj4F5ksj/uG8PmzvKXgg78LjJXoQftL6acECX6+Xk7GHvmMrk/5NnDei0t9+H+1R4tgfGfkRMf4+04lxBS1tMoAP87m4ajOmimHnNs1aQGvnIZg08V/2JVIyc1IprPvSaW53yKR/fTIAS5AydBS92FNHScqSGWFUFyO/d59ZA8ORw6OxInL3ytZg8kWnYgYEf5WOmKx3RADC7SXMdjcU7h6rJdfttx7fYgk3d6RPI3/beMws/gv85BaRUZRPT/9RIevraGlvfXueyGM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9aadaf73-76e7-4c62-a35c-08d64e577b23 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2018 19:44:55.3464 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0469 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----Original Message----- From: Lyude Paul =20 Sent: November 16, 2018 6:25 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Deucher, Alexander ; Koenig, Christi= an ; Zhou, David(ChunMing) ;= David Airlie ; Zuo, Jerry ; Li, Roman= ; Cheng, Tony ; Daniel Vetter ; S, Shirish ; dri-devel@lists.freedes= ktop.org; linux-kernel@vger.kernel.org Subject: [PATCH 2/2] drm/amd/dm: Understand why attaching path/tile propert= ies are needed Path property is used for userspace to know what MST connector goes to what= actual DRM DisplayPort connector, the tiling property is for tiling config= urations. Not sure what else there is to figure out. Signed-off-by: Lyude Paul Reviewed-by: Jerry (Fangzhi) Zuo --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/= drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c index 0cca1809fdcd..1b0d209d8367 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c @@ -345,9 +345,6 @@ dm_dp_add_mst_connector(struct drm_dp_mst_topology_mgr = *mgr, drm_connector_attach_encoder(&aconnector->base, &aconnector->mst_encoder->base); =20 - /* - * TODO: understand why this one is needed - */ drm_object_attach_property( &connector->base, dev->mode_config.path_property, -- 2.19.1