Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp120046imu; Mon, 19 Nov 2018 19:01:55 -0800 (PST) X-Google-Smtp-Source: AFSGD/U7NpsRwKsx4Q2gOqCmsgq5c4QUcifMeN6z2Va+IjuiohjJQhWVSm6qdSHN/MpRpCgteaVq X-Received: by 2002:a65:564b:: with SMTP id m11mr272897pgs.216.1542682914943; Mon, 19 Nov 2018 19:01:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542682914; cv=none; d=google.com; s=arc-20160816; b=eIHrCAh3X12tVci0yJJDqg8omRjX3QHMHCSadUz25kuc8jVGa7Ov70mG6VwDb0HjQA /T23M1KT357nVy6Az0nu8h2A5F3axpN4r8ofP0i+Eo7vzpYP3KxzNN7bdXFnOdnjoe4T lxP4p8SG+qdK50WBSyIEi46dIGpyaGaE4p+BZJWbm2NX3EWDTI9XUqvgHeusbzPkVkUp Jk9dIC0xF9pWgvaaF5ZE9QkCw9TgapGdUI7zxrn9JsQhJfoR858PqKqS6aitC9D5FOTG VwwD+nB45ndF+VMmHfimTvNom7+QzBuKOQVuK/FKEDCYBMLYq0vwzInve5e1n3qZ2pJ3 8klg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=oo7A5EWXw1q4JQzewIcxR4lQ2SI5WD377TCNhPnojqg=; b=a812N5fyuVX3W+mt2EA5IYrvJHBGeb+go0M0g425lce3epsWJqxHfgv0YURHpgdt8a 8RJSdSt5ILh2l0kVveuxYXwJDhTy4bn48WbeuGD+DrUSUiCy0vNQjcqRe8uF+M+0vWQW SBk+fvplU3d8ijQdlYu2tVddrUMDkazjZNPXvuD8nA54F7Ted3BLDwjA3zHqHpFRvDZb OrHOLxA7clyUf8rf1UuIVzWglDNdKYryNppT4rSnqQuSt5nv13LD0GhScCjJiwpTIE8M 5V4tUCDUiV5sToaCNHa8toLpKfwvsaP0cqgAP3fKdeNQ7fPS8GXZ71BZFR8Qx8ek8zlc tQDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k23si5517790pll.241.2018.11.19.19.01.39; Mon, 19 Nov 2018 19:01:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731537AbeKTN0x (ORCPT + 99 others); Tue, 20 Nov 2018 08:26:53 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:57264 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726576AbeKTN0x (ORCPT ); Tue, 20 Nov 2018 08:26:53 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EE06114D73C21; Mon, 19 Nov 2018 19:00:00 -0800 (PST) Date: Mon, 19 Nov 2018 19:00:00 -0800 (PST) Message-Id: <20181119.190000.791259337031857840.davem@davemloft.net> To: xuechaojing@huawei.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, wulike1@huawei.com, chiqijun@huawei.com, fy.wang@huawei.com, tony.qu@huawei.com, luoshaokai@huawei.com Subject: Re: =?utf-8?B?562U5aSNOg==?= [PATCH 1/4] net-next/hinic:replace multiply and division operators From: David Miller In-Reply-To: References: <20181119061234.12839-1-xuechaojing@huawei.com> <20181119.150142.777293649598457239.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 19 Nov 2018 19:00:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: xuechaojing Date: Tue, 20 Nov 2018 02:21:31 +0000 > This wqebb size is 32 in rx and in tx is 64, so the value is a power > of two. You know this. I know this. But developer in the future may not and try to use non-power-of-2. Please add the necessary checks. I will not ask another time.