Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp606847imu; Tue, 20 Nov 2018 04:16:12 -0800 (PST) X-Google-Smtp-Source: AFSGD/XECJfTkK3CeknYks3wg9VKksE/Ro1mDpQ9waeJFGtXHQqSrqVb8iu5nzkNgdWRY0Wi7TZp X-Received: by 2002:a63:4044:: with SMTP id n65mr1654730pga.90.1542716172482; Tue, 20 Nov 2018 04:16:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542716172; cv=none; d=google.com; s=arc-20160816; b=KcCH17MNcdURDg8KP4raGXLViluz1i3JeMYdhc0g77IFqwgtz5aCwDkPKvXvE1SaRD 0cDZiBeobnKPOh5RbEHzt/q1Qu4hxqe4hjQQZqmM/Ue491USefHx+a4WKnOx3YRycm/0 ATuruMUJoUXOLo+w8g7gP6Mt/39JaVLGi/2m2f939dMV4qQX+p/sg3OJba8JtM6Bcy+1 TbpN1R4/MEbfahpQIxabyCV4CygRJn386OTUX3EwFR3fDGhwHb7E82/a1iSPVvtm5LWh VeozKlnABIBnPSfL65syDLUUVulaGlqNtNZ6B0opSkNk1UXpzStiFIZusx62CEQYobPJ ImFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=VARyCiyK22GAw/KcTUz7ScGd4e5hmjDFupJ43f1s3V4=; b=U2i8WvbAyGGZ7QfEt+ZdtkNY9GD1U4PwSe5KbtFAv8npAScz9gvgKJEqs6aBedt4v8 qntMNXuZz2PhXgaVKcAzj7BKiL36EJMTWrDnc8NQx6/e2VZE6BDUNcZ/n6ZhrwfRxBuO X27feCzjrsiVV74ZXFGbWL5lvs49cXdQE0W+ao01PVWLq9qJ029IJ38qguWokORmnk60 lZ/leY6ack4Cdh7s4iEH3TdTstfUYznVsSRCaMEUWLCyc+NHIIDHLwSJ3osBBc0/p2jx rgXPNMPCkqMsIFNKGdoSBtXC0rDBDR7w6Nf10/6doIAwxhIUpIE9/xMhtSfQLcmW2vNY vhWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D+XeVGTj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ca19si22628069plb.238.2018.11.20.04.15.56; Tue, 20 Nov 2018 04:16:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D+XeVGTj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728782AbeKTWoJ (ORCPT + 99 others); Tue, 20 Nov 2018 17:44:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:36432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728041AbeKTWoJ (ORCPT ); Tue, 20 Nov 2018 17:44:09 -0500 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D63FA20671 for ; Tue, 20 Nov 2018 12:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542716118; bh=Cfj1fMhkmUYRRftMBOR/7DftYu/3bzdnk43yN0a5mi0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=D+XeVGTjBdwZwOU9w35NzcpV3oIWlNZeSkqwdqOcf6gOmfRDLg6nRsBZqGvlHGpGl Z8vquZBy6OMhQ7yVXcSJgpQpYr4PewaTnWshS++KkGai3hfZSku6/gLuD4vi4Y6gIY eFieTkArwvkcCPj/c7k8o97ugivwVN+zqPgkcd9M= Received: by mail-lj1-f175.google.com with SMTP id s5-v6so1406222ljd.12 for ; Tue, 20 Nov 2018 04:15:17 -0800 (PST) X-Gm-Message-State: AGRZ1gKjqZ0pez9NYH89b9XRs5CK+n/v1bgWWUPWuKeknfXZBBVNlzYE aUrHrEwgQLPYfu89wWQQ0g42WifQ2JSnQBK0XGE= X-Received: by 2002:a2e:81d3:: with SMTP id s19-v6mr909161ljg.138.1542716115927; Tue, 20 Nov 2018 04:15:15 -0800 (PST) MIME-Version: 1.0 References: <20181120113326.0d4f061e@xps13> <20181120130859.78d53da3@bbrezillon> In-Reply-To: <20181120130859.78d53da3@bbrezillon> From: Krzysztof Kozlowski Date: Tue, 20 Nov 2018 13:15:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops To: boris.brezillon@bootlin.com Cc: miquel.raynal@bootlin.com, jmkrzyszt@gmail.com, Stefan Agner , richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Nov 2018 at 13:09, Boris Brezillon wrote: > > On Tue, 20 Nov 2018 12:48:46 +0100 > Krzysztof Kozlowski wrote: > > > On Tue, 20 Nov 2018 at 11:33, Miquel Raynal = wrote: > > > > > > Hi Krzysztof, > > > > > > Krzysztof Koz=C5=82owski wrote on Tue, 20 N= ov 2018 > > > 10:46:33 +0100: > > > > > > > Hi all, > > > > > > > > Since few days linux-next has problem on Freescale VF500 - MTD seem= s > > > > to be broken. > > > > > > > > Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969= d > > > > ("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops"= ) > > > > as reason of failure to find MTD partitions. > > > > > > > > Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF50= 0, > > > > 128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4= ) > > > > trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver. > > > > > > > > The MTD partitions are missing entirely (nothing under /dev/mtd). > > > > In the logs you can also see: > > > > [ 1.232161] UBI error: cannot open mtd ubi2, error -2 > > > > > > > > Attached - dmesg.log > > > > > > > > Let me know if you need defconfig or any other information. > > > > > > Thank you very much for testing and reporting the bug! > > > > > > Could you please test with this diff applied [1] please? We discussed > > > with Boris and we think it should fix your setup (and all others also > > > impacted). > > > > > > [1] http://code.bulix.org/r1m99i-509201 > > > > error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399 > > error: drivers/mtd/nand/raw/nand_base.c: patch does not apply > > > > Maybe you have a git tree with this somewhere? > > Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix Works fine now, thanks! Tested-by: Krzysztof Kozlowski Best regards, Krzysztof