Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp714250imu; Tue, 20 Nov 2018 05:56:16 -0800 (PST) X-Google-Smtp-Source: AFSGD/VgNQWCrkeXAvegA/kbpLpEPhijby4tg8QhxqgvYh1QEQ3XWqrxmM6kczuw5pQSB1c7mtDY X-Received: by 2002:a17:902:780a:: with SMTP id p10mr2421762pll.54.1542722176203; Tue, 20 Nov 2018 05:56:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542722176; cv=none; d=google.com; s=arc-20160816; b=v0aWPUh+Y4k5Nrk+NMd8AuDF25PvFidnnrCVliBBVfjORIXz2qDm0M/gfkDf/sHYba tNdsuL39Bih5frtLgNWfApX2ogimIeUHT00HsNiFuqix08OYD3Cj1j3z9avwxcLQjRZR 3Y9tJ7azHF7glDw8pJkCs3LxrbN15y6QQ5wSgQaksetYmz2N5zz9yrzQkHd/VVCwP230 gw2oZ+NznCO0RqoW6pnVxsqemHuZUlRPaT28hh6zXiBhqgWK+zADw1ipf+1bnXXB1g2L ttHzOELqWMDrVIJU+e6kRQDpquxYdHfPiqBtRphsLuUXoVgyD09fUwcAWTz5eAZMoJjF htPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=66iIlPCfZlFO5GQa3do0QVvy8oEyyGVSFc9uHlBtYRQ=; b=V6sp33oPHMu0hf9q5WxST2URGqE32PynHBtoFTFgcr5db4fUQadd1sUUqi0LiMJOkf mmHSW0wwgI4i9/CE6nupUK0RO0QQEZqEpuThYsgky/kBq3p1d3jttsxnH9HMqHQF/RuV tNrgdMz/LQd+Uy/B0+I8BjYwla1B+GWI9JSW1eh1LgWcl+LnzBcvdO1urx6fW9jBKGVz 7ijOyjFFlJV+awdb3mEsE0HUZXHnhPVTnU5mIGt/J33KXzXcdHB/bBN/fLivhBqZyXtY Su9zMBKi0+9KBn6DhXSVli6y4x5MDG5D562Jj2Qg9hGgPwDm4WvUq7uK5eUeopgD2hCx 9XAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si42744169pgg.463.2018.11.20.05.56.01; Tue, 20 Nov 2018 05:56:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728751AbeKUAYh (ORCPT + 99 others); Tue, 20 Nov 2018 19:24:37 -0500 Received: from mail.bootlin.com ([62.4.15.54]:56890 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbeKUAYh (ORCPT ); Tue, 20 Nov 2018 19:24:37 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id EE28920D31; Tue, 20 Nov 2018 14:55:19 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from qschulz (aaubervilliers-681-1-13-146.w90-88.abo.wanadoo.fr [90.88.134.146]) by mail.bootlin.com (Postfix) with ESMTPSA id A7D0220745; Tue, 20 Nov 2018 14:55:09 +0100 (CET) Date: Tue, 20 Nov 2018 14:55:08 +0100 From: Quentin Schulz To: Andreas Schwab Cc: davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com, allan.nielsen@microchip.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com, linux-riscv@lists.infradead.org Subject: Re: [PATCH] net: phy: mscc: fix locking in vsc85xx_default_config Message-ID: <20181120135508.paxzs63cqy2llc7d@qschulz> References: <20181008100728.24959-1-quentin.schulz@bootlin.com> <20181008100728.24959-2-quentin.schulz@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ntnyqwowhkgpjtiz" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ntnyqwowhkgpjtiz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andreas, On Tue, Nov 20, 2018 at 02:48:37PM +0100, Andreas Schwab wrote: > Don't use locking phy_read/phy_write functions while inside > phy_select_patch/phy_restore_page region. >=20 > Fixes: 6a0bfbbe20 ("net: phy: mscc: migrate to phy_select/restore_page fu= nctions") > Signed-off-by: Andreas Schwab Have you tested this patch? Does it solve your issue? Reviewed-by: Quentin Schulz anyway since it's to be done. You need to send your patch as a mail separate to this patch series. You also need to prefix your patch with [PATCH net-next] instead of only [PATCH]. This is specific to the net subsystem. Use scripts/get_maintainer.pl on your patch to get the people to put in Cc and in To. Thanks, Quentin --ntnyqwowhkgpjtiz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEXeEYjDsJh38OoyMzhLiadT7g8aMFAlv0EjwACgkQhLiadT7g 8aMwkBAAlxyAg33/B6pRIqeuRGnreLcxBPkH2jhQsxDU/vaKz8rt51V2AVQI6DfA A2cLtqV8S0yec8Z3ZoD4bQGCqTwRm2pm/28jILlfZIHrX6hkDdi1Iqtb1cDh2oc1 7DLnPtg+t9XHQYeYbouDw1bsNmDToN/ZQHU11r8NPUdKFhgs2On0rQxygOqKX6DE ZJhfdnFuKGeqKnrbUZYy4CU8o7n3cCu0DoMQP48Etn/K+mlHnvSyj4r/RFDw21pD INhNvFCjcfsKRbHNx5i48KX23wb74tec11J7Y95MLxoRRxU5F3hWUhGrrV1br7M4 JCz76BsLnIr+wmZsoEEfri6yWbeoZIq+WJPW0S1N8BQhez+DWZCLyLjpWawxuWFQ ohveKoEuR4NXjhuqLEPvKHTISAG4tHkUiLV9M8I7zgLUOvdd17E5vA/G6SAbuTc7 12IWm37LdUp+9e8Y9rTWdubBg51bfIUb43KriB9hWek3XVswi7QkVKEuFzLxz6Ws KWXKOP0IaxbtS/i6Rdn1SIJ8GTfoikAzDEMFgNths7R8Fx1fvONMEKTeYb7JF5AF FWad5HJm3Br6fZyUqbvpFFJ+poebiqavH1LNE8HjTxbfnuetu/RPZaFQ+JO98MBN ewcszCCIwphpF0i8juSBwr9nRRBZhNZFgpEvKDbzl88VfyU37yc= =FCjc -----END PGP SIGNATURE----- --ntnyqwowhkgpjtiz--