Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp816039imu; Tue, 20 Nov 2018 07:23:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/U0nf0h1/US7Wk/ZoePDqp4FBdVIqUtt9Hi59qNT9cvFKNTkCDGtJtS7p32ukDvslkfjddM X-Received: by 2002:a17:902:14b:: with SMTP id 69mr2725546plb.52.1542727407895; Tue, 20 Nov 2018 07:23:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542727407; cv=none; d=google.com; s=arc-20160816; b=RyXWcgqVwGudP2Gc2GumEsZm1KCr6WsN/MuruDvAu9NMZ80E0Ujw88o9Yu0RmbOTxA AKYRJq/cbRcF5cSAQb59XB2lE2NlGqCNfgwgNPdu+SgB8OrWCXELbNSqoT0+EEej5yQc I0NpaRYvaSbVcXWcvkt5cCAPilR4I36oMIbliQiSMouQT88U/ZypJg+dk2eACFoOAx5C RIf/+7Oq8U7wLAvn8JpMFaRkIdvjPOAhNyzQzlAr8oCmNAPo0nl3QvhHoC2jH4IJGd0d dC4grvNR7/Y3N+sz8yozKNDTQS1ArlOt914wgeVdFZ502R0+ThkcW9a/Fx2LvDsRjcmp T+vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=6+tYmLNsznf4K1U8H6p8DxxOxR11sgzODxzzcyrvNyA=; b=WoXAxkx83/DQO+WJ0JoLKHysSD/eIv5l3Mj1yvTWsfF2+cJqOQzTUwBcHbc9yb6k1q wN28QAavb9U25r6vTslLQmL3sx+848boIxx3ZsnjKtmSuFb4DjHHtbnm4LGR+QZOO7B6 mzLP+fpqXApSO19TJlKmaPuoeb6ZjQbdrGf4c67YKsGN1dYiiDXGS+rsJbLcyjR6EHlE GcVin3f7BhpeZe7QJYsX/lxzyHV5f1dPUQ4oX2P7pOrfJnzVI7oKQa7mGa0dKNE6oPnb FkDw4RdwOxqHz6V3p6a7wmuPg/raXIRd4mI/jfkz90PE2py8kGK72Ezr1t1O9rDfQ0Gt ZO3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i198si31855537pfe.289.2018.11.20.07.23.12; Tue, 20 Nov 2018 07:23:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729961AbeKUBXo (ORCPT + 99 others); Tue, 20 Nov 2018 20:23:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:39252 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729931AbeKUBXn (ORCPT ); Tue, 20 Nov 2018 20:23:43 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 240B4AFC8; Tue, 20 Nov 2018 14:54:11 +0000 (UTC) From: Nicolas Saenz Julienne To: stefan.wahren@i2se.com, eric@anholt.net, dave.stevenson@raspberrypi.org Cc: linux-rpi-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne Subject: [PATCH 10/16] staging: vchiq_core: don't add a wmb() before remote_event_signal() Date: Tue, 20 Nov 2018 15:53:45 +0100 Message-Id: <20181120145351.30390-11-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181120145351.30390-1-nsaenzjulienne@suse.de> References: <20181120145351.30390-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's the first thing remote_event_signal() does. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 8b23ea5322e8..5791c2b670fa 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -1137,9 +1137,6 @@ queue_message_sync(VCHIQ_STATE_T *state, VCHIQ_SERVICE_T *service, size); } - /* Make sure the new header is visible to the peer. */ - wmb(); - remote_event_signal(&state->remote->sync_trigger); if (VCHIQ_MSG_TYPE(msgid) != VCHIQ_MSG_PAUSE) @@ -3269,7 +3266,6 @@ static void release_message_sync(VCHIQ_STATE_T *state, VCHIQ_HEADER_T *header) { header->msgid = VCHIQ_MSGID_PADDING; - wmb(); remote_event_signal(&state->remote->sync_release); } -- 2.19.1