Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp856163imu; Tue, 20 Nov 2018 08:00:43 -0800 (PST) X-Google-Smtp-Source: AJdET5cCe++pTKclCuTdYLCSvTVVBFpKKHFnrQcK0IZceE9rH9WfA2cpxNtx6fiyVy05ZTu9stls X-Received: by 2002:a62:34c5:: with SMTP id b188-v6mr2848937pfa.65.1542729643864; Tue, 20 Nov 2018 08:00:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542729643; cv=none; d=google.com; s=arc-20160816; b=eTRr1+osNTDLjFSz6eof2HYDWWF/Y61n75xnppZjmXfWfJa6ox7fF1IKNLJGabmcWn w2w5G6NMuAf2NBPH1tEJrr7Fyr/IqYmXjGtBbNmL7plcGLWRGAyTmYoSHpQEMu5pj1Y0 nFEHlPSXpJkdf6LguaDjDhDm7Ikc4+Gf1zV8sQGYLNc4MStDk/V7hdoxwOdplzoXbiHK OkqkVb7ZCWmG6D7n7yJKmivpoaBKqut6FlNsaCuxceNYyk+MERSelY7JonjKE9LlgOft LzM210N2jIqeoj6xTYtYv9JDPHAX/mwfkAOgtct0oMsZ/3E2xnJQfTZEaWHwYpQMNbTp Tj4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=QAWWIJREo0tp09xB5vEdyZDaNN6au3OPA9qY0LXCgT8=; b=NG6FhJRQRh5uaJdeRC6IrSTkQpbTCAiz/efaHkP3RLslXVgqw0c4EhHndiCcuEFmiR GjXNKS1xVnIYSA/+cNMOSpGfi/HcWUxSaS9dEvLcWZzVgNcdh+yzHF9jsfqm3Q6BE70Q Pvt4ZPgIK4cKQnZwpzuLcaP5XcPMe1Z5/8lOQZQqKceYy9t31H/nlFU54eIPlzKTlX/4 Ae/+4Rql8wdo/zOc6BM+ZQL7P+eyleZF96kcmL89VrY3hXN3uJQel4Q7AJq7y8QLgX5r 0PEebTFi7PxDnrXqx7pkT/R78iqE7oTPVGQfh8NBl3zPyDPfAOLDudoSgdxWSPP77ZNp tLEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gn7si24841911plb.321.2018.11.20.08.00.29; Tue, 20 Nov 2018 08:00:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729905AbeKTXdc (ORCPT + 99 others); Tue, 20 Nov 2018 18:33:32 -0500 Received: from foss.arm.com ([217.140.101.70]:48572 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726708AbeKTXdb (ORCPT ); Tue, 20 Nov 2018 18:33:31 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FEB580D; Tue, 20 Nov 2018 05:04:29 -0800 (PST) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E9EB63F5B7; Tue, 20 Nov 2018 05:04:27 -0800 (PST) Date: Tue, 20 Nov 2018 13:04:25 +0000 From: Lorenzo Pieralisi To: Stefan Agner Cc: minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: dwc: layerscape: constify driver data Message-ID: <20181120130425.GB23472@e107981-ln.cambridge.arm.com> References: <20181119100022.27501-1-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181119100022.27501-1-stefan@agner.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 19, 2018 at 11:00:22AM +0100, Stefan Agner wrote: > Constify driver data since they don't get changed at runtime. > > Signed-off-by: Stefan Agner > --- > drivers/pci/controller/dwc/pci-layerscape.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied to pci/dwc for v4.21. Thanks, Lorenzo > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 3724d3ef7008..905a0ab0e6fa 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -222,12 +222,12 @@ static const struct dw_pcie_ops dw_ls_pcie_ops = { > .link_up = ls_pcie_link_up, > }; > > -static struct ls_pcie_drvdata ls1021_drvdata = { > +static const struct ls_pcie_drvdata ls1021_drvdata = { > .ops = &ls1021_pcie_host_ops, > .dw_pcie_ops = &dw_ls1021_pcie_ops, > }; > > -static struct ls_pcie_drvdata ls1043_drvdata = { > +static const struct ls_pcie_drvdata ls1043_drvdata = { > .lut_offset = 0x10000, > .ltssm_shift = 24, > .lut_dbg = 0x7fc, > @@ -235,7 +235,7 @@ static struct ls_pcie_drvdata ls1043_drvdata = { > .dw_pcie_ops = &dw_ls_pcie_ops, > }; > > -static struct ls_pcie_drvdata ls1046_drvdata = { > +static const struct ls_pcie_drvdata ls1046_drvdata = { > .lut_offset = 0x80000, > .ltssm_shift = 24, > .lut_dbg = 0x407fc, > @@ -243,7 +243,7 @@ static struct ls_pcie_drvdata ls1046_drvdata = { > .dw_pcie_ops = &dw_ls_pcie_ops, > }; > > -static struct ls_pcie_drvdata ls2080_drvdata = { > +static const struct ls_pcie_drvdata ls2080_drvdata = { > .lut_offset = 0x80000, > .ltssm_shift = 0, > .lut_dbg = 0x7fc, > @@ -251,7 +251,7 @@ static struct ls_pcie_drvdata ls2080_drvdata = { > .dw_pcie_ops = &dw_ls_pcie_ops, > }; > > -static struct ls_pcie_drvdata ls2088_drvdata = { > +static const struct ls_pcie_drvdata ls2088_drvdata = { > .lut_offset = 0x80000, > .ltssm_shift = 0, > .lut_dbg = 0x407fc, > -- > 2.19.1 >