Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp883385imu; Tue, 20 Nov 2018 08:20:56 -0800 (PST) X-Google-Smtp-Source: AJdET5d2kxLcikaMD+2y7Gen2AWyiHcGFF8AXXdinB+6Y1RwMpitJ8w6aSkG7lz5abDFc9hIZQ3N X-Received: by 2002:a62:1912:: with SMTP id 18-v6mr2938671pfz.194.1542730856552; Tue, 20 Nov 2018 08:20:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542730856; cv=none; d=google.com; s=arc-20160816; b=Eq95b0lgro5hFlwqSvb7SLQ6xYA0+wIytrbwP5iw3Sy+sWZvxK11gCmgvj0du/jgYu giLFiHPgSkmFl/TWA3px1nIlNAEXo6ucvktH0IMBPmewARlfqpMykcG2iG54hR2GFdRj C4ujVoxjp9fijnE+S6TV936ftxdkHheEpOUJN3B1bK+45FSRMrMBGe4ku0s0qL/sQ7nC Qklj/iHJNXtrrT/1x8uEkyVymWwFbrOGszk/dvTqZSEkT532opJy56yg4bc6e73JocwP CZGzjIEQLM7paDqB2AgnaznFIkMcTH3qIrlLwb6TpAuxxY2VQ7WvesIhiK9qljl5fWr1 vSIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=0eXv+BBN3gMRLzt5AHf308ykbV2mTdbaEHvEiXE7PVs=; b=yYUqjUK7EicJ9xa/1/s34lc546QOJr5lJjgRZd7xvMScC521Dv8UHG6cOTO5OamBxx w19nLwiJKncT0jBzSwi/cHhZcJVMzm/5TceXml41j/XNjwZ7l29DehTll4mzyGp55Fqv S+iKOa0M31A7r/wqEVa+riCjaBSlqITzs1YXVYV3Vxn2h4o14jBS7mY7opSqetRoK9UK AJCjXLST9guH4qzNObLyhxWDpxy50IkQBcRrQ0b/wzlXZvwcorw8nRysBcGH6iqTpS8J ar3H0XrFr1Rourx1XI6ZUES89dcVHO6kYSNQ/TG/igqbJ7dJLq3P34oqomynJ6Y/AaM1 O+PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si10065454plr.341.2018.11.20.08.20.41; Tue, 20 Nov 2018 08:20:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbeKUChf (ORCPT + 99 others); Tue, 20 Nov 2018 21:37:35 -0500 Received: from verein.lst.de ([213.95.11.211]:46073 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbeKUChe (ORCPT ); Tue, 20 Nov 2018 21:37:34 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 3009B68B03; Tue, 20 Nov 2018 17:07:42 +0100 (CET) Date: Tue, 20 Nov 2018 17:07:42 +0100 From: Christoph Hellwig To: Robin Murphy Cc: hch@lst.de, konrad.wilk@oracle.com, m.szyprowski@samsung.com, john.stultz@linaro.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] swiotlb: Make DIRECT_MAPPING_ERROR viable Message-ID: <20181120160742.GA2492@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The subject line should say dma-direct. This isn't really swiotlb specific. > +#define DIRECT_MAPPING_ERROR ~(dma_addr_t)0 Please add braces around the value like the other *MAPPING_ERROR defintions so that it can be safely used in any context. Otherwise looks good: Reviewed-by: Christoph Hellwig