Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp965822imu; Tue, 20 Nov 2018 09:31:02 -0800 (PST) X-Google-Smtp-Source: AJdET5fy5H25lI/FIZkY51mZpeF0uO5ETxe4sXPRCUnlt8ax44wmTBvwjb1m7LBc0TnKajKaGCip X-Received: by 2002:a62:4641:: with SMTP id t62mr2411835pfa.141.1542735062313; Tue, 20 Nov 2018 09:31:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542735062; cv=none; d=google.com; s=arc-20160816; b=xVzq550zBjN1XgzYNmbU5u2kszjNiCkUmoGaiE/eyPBD5h9ZANf+98FWOrZFfxu1l9 mZRJRz5Qi2VVnu222XmTRaGaSxC5w+1c383T2sHshwsw9RqjClt01/k8Bd83Qtcr1MZA pnho0RxjuRDuWoovkCcXuKUUcXvpC8h33BXb1qtgqTbGPjU7I6cNC7WmbjzuGWH6DTqr ZF5e2nzDOPwENBXKpUf7F9052CSQ9/edG4QrfZw5s8Qetsc8E4PgY6lv5PYOsCTMjsVQ /On6iORap8FHocO8XJndNVAOI+3Uxl6y/WthAsFY8YDQ5ZLT4IY+ij57D0bxkJ6NEa7O o0eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7Qy+yv7yCvhWAuj3VlLr04ZmJwklJFZGR+jPGTDoQ04=; b=t1oQmMrGl1cgmviEPVhiUhFu1Ud62S4mf2GXASC5qUH6R/P1u529Y2rFamHMLHLxdB VvDAX4V9EngFUut9l8+Q3/cFxAq/Ytjomf/STe8m8Tde0uoyIJdmyhXFKlvqPg5cXTkO 2Ui+OTVawfaNbG5LxISnZ71DRJvhM/WbPrx0pGGGvJbkmxrLPHy+fBunloJ7lBPXs5ws mvrZG0MJhqkTAS8h+nzyd2HmE1upyUcpFLtLTQQqHNnLno5vWyJAzkMDsB9VyJ37tvHD bTNQ1zALG8h2ZSG+IpOaBNdHbhDY8Bk95lkAJ4cCh055TQ5uwWSaWlrVLYn5HHeel1TV rTmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Fkklsq8T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n18-v6si43163018plp.294.2018.11.20.09.30.38; Tue, 20 Nov 2018 09:31:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Fkklsq8T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730329AbeKUEAD (ORCPT + 99 others); Tue, 20 Nov 2018 23:00:03 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:36492 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727166AbeKUEAD (ORCPT ); Tue, 20 Nov 2018 23:00:03 -0500 Received: by mail-lf1-f67.google.com with SMTP id a16so1931302lfg.3; Tue, 20 Nov 2018 09:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7Qy+yv7yCvhWAuj3VlLr04ZmJwklJFZGR+jPGTDoQ04=; b=Fkklsq8TsS4qmMlpfKgRE0Oeu7p34ur/AzffTu2BwfKRooB8hqlpLmHvC/z8wAAM8O mW0OQWRvR7Uq5fouiRvLAVDYFd+nSM1PL1/2f0hR29ff4zsBlkV+A7aIHqUHNYUT/7cg hm+HC51u8RKDou3JTwYdQpQzHV3pTAYIaBR7nry6Oj5jRRlBrFWpRwOv4L+b2Zyibokv NHnvsYpi+7J5AMiM5ByW3dM9p1VcrwnLnmOF+SF00B1wqJ7ECJoGN8XDfNk5uWlK44WH 6zodHQhDMoyP8+c4Wx7LOK3/RrTI6w+6qs8CjhTebM7yLDvS+jTxedVtwdAcQjv8A+un RM6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=7Qy+yv7yCvhWAuj3VlLr04ZmJwklJFZGR+jPGTDoQ04=; b=Pl/a/ZAlYIZTZjTeJZsqbfWOMJd9T1iERlyvU8h4HVvN+WolOoffCwjRb5sHSPFUhO W9qDVqH7MrfnrG/Tn+lXztirqbZejXx2cVNGfjfPe8c4NwhXXz9gNHuhhn3boJ3+pkGT 8tegAvwXeOXoPkDLZax9d0rfTQtglt9RX1POXTfd5zbOC//DLSD7KUCdQLv6ynZeN6zr 7N2PHlajVPYEvJatdUoRUkGfEG7yjCfbk5JtR8jA1tU8tw4TjRdMiWqUw7C7vHs33JDH 6C2VU59xwj2dEIqQsxlrcm66owLNXCOmF0qqCrz7fYpT7lvTxnZ6TboCi56h1M2PB5nB ewTg== X-Gm-Message-State: AGRZ1gLBh9zng+HIFAdBHbyRoRbgyUgh5M1YUra3d22hT0E+ut6i0zN9 IXLa8nEXJfcSMz30mQQUVaI= X-Received: by 2002:a19:f115:: with SMTP id p21mr1607949lfh.20.1542734985479; Tue, 20 Nov 2018 09:29:45 -0800 (PST) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id m1sm6038497lfb.56.2018.11.20.09.29.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Nov 2018 09:29:44 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1gP9qJ-0005M3-Nk; Tue, 20 Nov 2018 18:29:44 +0100 Date: Tue, 20 Nov 2018 18:29:43 +0100 From: Johan Hovold To: "Ji-Ze Hong (Peter Hong)" Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH V1 1/1] USB: serial: f81534: fix reading old/new IC config Message-ID: <20181120172943.GJ19900@localhost> References: <1542250724-11667-1-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1542250724-11667-1-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 15, 2018 at 10:58:44AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had a internal configuration space to save & control > IC state with address F81534_CUSTOM_ADDRESS_START (0x2f00). Layout > as following: > +00h: to indicate the section is valid > +01h~04h: UART Mode & port availability > +05h~08h: Output pin control on IC power on > +09h~12h: Output pin control on working <-- New added > > Old driver will use +05~08h as default on working, but newer IC will > configed with shutdown mode(7) in 05h~08h and working mode with RS232(1) > in 09h~12h. It'll make mainstream driver not working. > > This patch will make mainstream driver compatible older and newer IC. > If using a old IC, the +05h~08h will be 00h~06h, we'll direct apply it. > If using a new IC, the +05h~08h will be 07h or larger, we'll read +09h~12h > to apply newer configuration. > > Signed-off-by: Ji-Ze Hong (Peter Hong) Applied for -next. I guess you can ask Greg if he's willing to take this into stable once 4.21-rc1 is out (as it is enabling support for a new class of devices). Thanks, Johan