Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp965877imu; Tue, 20 Nov 2018 09:31:04 -0800 (PST) X-Google-Smtp-Source: AJdET5fcIyDDtVd/CqzPA0yu1E7gtNAA/aC57PS0+Ma/DomjYCBaEXTC3ngqJ3LjCSYIsI+9q7R8 X-Received: by 2002:a62:7dcb:: with SMTP id y194-v6mr2996679pfc.215.1542735064891; Tue, 20 Nov 2018 09:31:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542735064; cv=none; d=google.com; s=arc-20160816; b=dP9hLLThNa9r4OhuU4DdKtg4Huo7ThK+Hr509OuQdGzX1vpCKjKzzEY1PE/tghpoWY +J1f44oTqbWE2uqOuxDEnHBpBpbu4N2tfta2B51k8zTt88gHHbzG4nP1Aas6fuCdAnQO xFi5/Pulpwgrh0Bq3rrJge9PZ9hMZX28mr6UrAUzk9wy2o2Tbapl3D5hIVYBTuJAVNwo W71nbgCFa3afUi8LAKXzCyH6NzOHAYs4QtskSDBwsb+p6i3rH9YJ06ifrg57KTTe5FGk f5Lma3HxebbjNyQCFrl8oyt3nyyIQ9d4RYfzBWhHWyF8X8AFJ0X6ErV0fcKiS2nbtg1g qu7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:to:from:cc:in-reply-to:subject:date:dkim-signature; bh=ZUZu1XwZ8f7g6NqpBSd3lwgL1/UqWz9FgIimF7IiiBU=; b=ELRuyN48j/bIoNWATXITUwNP5Jsxz1hnFjR52931G8BhL1ZRTOwKtIlFZayjhNC41c eAhdhOA5H99SJQZvmESKIuIk8EFv6YqQKHp8ypKTt2sZm/qb7yTG12ULs5oJuzWihvtK R1VU8Uh9KztaVxkH0w9hRck9UUaV5SzPdvwoLLwA4+8hg4drh3nMQabr0EgK2vtIzUHR XoVJOn7EGIi2RGGNIUmQ0qOAJr/jjTGfZXoQ7k3yfnU3QtJSf9RL4OFRzbRUo1Ejij0Z YXSzuIGDUUn5d/f9LKmNBX8Mw5rafSRYfRhG2GyDNHZ/rHF54jypLcUNg8k/AhKMbZbu xkyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=mL5lGmKn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6-v6si41460283pgr.274.2018.11.20.09.30.42; Tue, 20 Nov 2018 09:31:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=mL5lGmKn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730415AbeKUEAI (ORCPT + 99 others); Tue, 20 Nov 2018 23:00:08 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:45030 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727166AbeKUEAH (ORCPT ); Tue, 20 Nov 2018 23:00:07 -0500 Received: by mail-pl1-f194.google.com with SMTP id s5-v6so1318749plq.11 for ; Tue, 20 Nov 2018 09:29:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=ZUZu1XwZ8f7g6NqpBSd3lwgL1/UqWz9FgIimF7IiiBU=; b=mL5lGmKnmVqKTv+RoxLHuXmZVppJcsdNOft5F5ISDYcBmW4G+R/AwJfXd8KpXg2q+T guUtaHQaHlcq7x7PulayiauXMYWRr67bROQzwflJoA7emOAxvpJHgq2qUAGtdmuQwOCO +2vLPJl1cFch16mXDDOJqWaA+Ks8akJPclCAsF5okIhEHYVkobwN0A6EI5At2CvFZIM/ iLvzvwkRF7NB3Hn9fBtr+XeUchUKv9gc9Maa4hqqbaBRaMECZsvr2j9XBXd8h4TfWI+j //SZIZfUNNFysnkjoJNVUHbX8xEay4AMtb8dMdBm0SNNDoZTVPc16GWpfbKZErO5r/R+ R0KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=ZUZu1XwZ8f7g6NqpBSd3lwgL1/UqWz9FgIimF7IiiBU=; b=hW1krlaedzVHiHjw41wUQr9fisJS6osaZ9AvReexL3cOLixCx3KpubSC2Sk3ynSzEa 6Ba13kw9f1rf/pRT/n7dOSzGjJrHRysiEWHw78+nBMf6orEK73QI2GxmTa6wt5G11YU1 r99BGMNX6axjaIOd9emXYoYcZfJAH8LmUKXxUqpVd7gzubM/2C/NzbPWYwkPWFXaiugs JAmr49pKIzUaWaLQmPMVmY5/MCkgV3GjPhlTUPLxb0Gkmrr5mdVxQmeMbkAp6d2UhHJj zXnz/lUdfWG51ENp4aODLqeDAeiwoX1sFIhAXiXsn+cw4P424Dx9coyaqJXgTjXR8bE2 q/8A== X-Gm-Message-State: AA+aEWbSqlDhWQDF1ZKK0Ws2eEXj+llW17ysm8+ZLtEXOJrHA183Eqv+ rOaWVWAC+oJWhXnSNPSDZ8J8XQ== X-Received: by 2002:a17:902:b611:: with SMTP id b17-v6mr3169581pls.31.1542734991154; Tue, 20 Nov 2018 09:29:51 -0800 (PST) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id g5sm42969593pgu.57.2018.11.20.09.29.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Nov 2018 09:29:50 -0800 (PST) Date: Tue, 20 Nov 2018 09:29:50 -0800 (PST) X-Google-Original-Date: Tue, 20 Nov 2018 09:29:31 PST (-0800) Subject: Re: [PATCH] RISC-V: add of_node_put() In-Reply-To: <20181120141102.20534-1-tiny.windzz@gmail.com> CC: aou@eecs.berkeley.edu, dmitriy@oss-tech.org, atish.patra@wdc.com, tglx@linutronix.de, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, tiny.windzz@gmail.com From: Palmer Dabbelt To: tiny.windzz@gmail.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Nov 2018 06:11:02 PST (-0800), tiny.windzz@gmail.com wrote: > use of_node_put() to release the refcount. > > Signed-off-by: Yangtao Li > --- > arch/riscv/kernel/time.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/kernel/time.c b/arch/riscv/kernel/time.c > index 1911c8f6b8a6..40470e669a35 100644 > --- a/arch/riscv/kernel/time.c > +++ b/arch/riscv/kernel/time.c > @@ -26,6 +26,7 @@ void __init time_init(void) > cpu = of_find_node_by_path("/cpus"); > if (!cpu || of_property_read_u32(cpu, "timebase-frequency", &prop)) > panic(KERN_WARNING "RISC-V system with no 'timebase-frequency' in DTS\n"); > + of_node_put(cpu); > riscv_timebase = prop; > > lpj_fine = riscv_timebase / HZ; Thanks. I'm going to target this for next week's PR.