Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp990517imu; Tue, 20 Nov 2018 09:53:27 -0800 (PST) X-Google-Smtp-Source: AJdET5ftmLU3KbXTP/7p360l1tTJIBS8kzp5eW0fMKx8D8SS7n98/ZvSGL2QIOzxziWLbhxpVpbI X-Received: by 2002:a62:5c06:: with SMTP id q6-v6mr3215254pfb.171.1542736407040; Tue, 20 Nov 2018 09:53:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542736407; cv=none; d=google.com; s=arc-20160816; b=DCn+TZsSB2VUO6jrhMoyHSuKXb4UqUVhWElHRd6SJAOwrva/5RjzvFRoCIWCu2hA+5 G5LbDLY7GJiZiimewB3iR5rdHW831SU2K0wYzBhvD8K2hrAbRbU/FqYUHdR+7sLO1U3N gwlPG4M93VyUebf+A1Z/bkjS5ZgODnQ89468fIT2xT6clYRD+LgoZP1fpWrFsYFzq+6I /czQ5h1oG/G8mDA0NES0vcAP7gxa6hwQzyXxRwam1OHAMSLY9UG4Dn/caaMZqAXT1iZk nQLB/MHUjBs78J7nMWynTKCwNUe4aVZUWb0iClBXfed9ZW8fgK6L6qJ8/nseeyb5W4y6 R3fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=TBrrxbbfXPwXcUNMslsZgqUo+KIJpi0DSjuCsY06bjA=; b=XbF2gsVnbHpeQ981i5kaJScyiCxh0Mzt1BOLHxdwO3svyyStdbrIV33Jb9lyK0K3nl nTKgY1yxSC6Yl4elDTSZi8sg8YREq1Gfd1mpRI1Q8LBYN4cR9JWeD4dhDjEhhgwZ89yv TtWzD7jAiGFaIIgBIO+Jb5SFGcRtlJAfl8z6vekDYeS1IcLXUgxmTdKQ1lCHhBDiTQtd SxKYNJYuDh408tJiYW1bsveGpD5Cz6Ts8T/Youd0vvKEBa50SZxPhQYd+q5WWh0ODDK8 KExsgeuCQWetSKCrOdmWTMY847apw1dD2ozuNSngAhlvuZ3dxtDUFLRWOmNhPEpA/gVk pqtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si18973261pfi.12.2018.11.20.09.53.01; Tue, 20 Nov 2018 09:53:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729303AbeKUBt5 (ORCPT + 99 others); Tue, 20 Nov 2018 20:49:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:43698 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726108AbeKUBt5 (ORCPT ); Tue, 20 Nov 2018 20:49:57 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 87200AF4D; Tue, 20 Nov 2018 15:20:17 +0000 (UTC) Date: Tue, 20 Nov 2018 16:20:16 +0100 (CET) From: Jiri Kosina To: Linus Torvalds cc: Thomas Gleixner , Peter Zijlstra , Josh Poimboeuf , Andrea Arcangeli , David Woodhouse , Andi Kleen , Tim Chen , Casey Schaufler , Linux List Kernel Mailing , the arch/x86 maintainers , stable@vger.kernel.org Subject: Re: STIBP by default.. Revert? In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 18 Nov 2018, Linus Torvalds wrote: > This was marked for stable, and honestly, nowhere in the discussion > did I see any mention of just *how* bad the performance impact of this > was. > > When performance goes down by 50% on some loads, people need to start > asking themselves whether it was worth it. It's apparently better to > just disable SMT entirely, which is what security-conscious people do > anyway. > > So why do that STIBP slow-down by default when the people who *really* > care already disabled SMT? > > I think we should use the same logic as for L1TF: we default to > something that doesn't kill performance. Warn once about it, and let > the crazy people say "I'd rather take a 50% performance hit than > worry about a theoretical issue". Just to update status quo here -- Thomas is working on polishing Tim's set into mergeable state, I've just sent him small addition on top that makes IBPB also be controlled via the same toggle. That should make the whole 'spectre v2 userspace-to-userspace' mitigation control consistent and undestandable. And also give us even few more % back that are lost due to IBPB as well. -- Jiri Kosina SUSE Labs