Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 20 Nov 2018 08:14:19 -0800
From:   Tejun Heo <tj@kernel.org>
To:     Radu Rendec <radu.rendec@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/1] Improve kernfs_notify() poll notification latency
Message-ID: <20181120161419.GS2509588@devbig004.ftw2.facebook.com>
References: <20181116020954.24924-1-radu.rendec@gmail.com>
 <20181116020954.24924-2-radu.rendec@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181116020954.24924-2-radu.rendec@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 15, 2018 at 09:09:54PM -0500, Radu Rendec wrote:
> kernfs_notify() does two notifications: poll and fsnotify. Originally,
> both notifications were done from scheduled work context and all that
> kernfs_notify() did was schedule the work.
> 
> This patch simply moves the poll notification from the scheduled work
> handler to kernfs_notify(). The fsnotify notification still needs to be
> done from scheduled work context because it can sleep (it needs to lock
> a mutex).
> 
> If the poll notification is time critical (the notified thread needs to
> wake as quickly as possible), it's better to do it from kernfs_notify()
> directly. One example is calling sysfs_notify_dirent() from a hardware
> interrupt handler to wake up a thread and handle the interrupt in user
> space.
> 
> Signed-off-by: Radu Rendec <radu.rendec@gmail.com>

Acked-by: Tejun Heo <tj@kernel.org>

Greg, can you please route this one?

Thanks.

-- 
tejun