Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: WARN_ON after gic_reserve_range
To:     John Garry <john.garry@huawei.com>,
        Jan Glauber <Jan.Glauber@cavium.com>
Cc:     "Richter, Robert" <Robert.Richter@cavium.com>,
        Will Deacon <will.deacon@arm.com>,
        "Nair, Jayachandran" <Jayachandran.Nair@cavium.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20181120162305.GA2088@hc>
 <2665ddbd-5912-12b9-f5bd-6ccaec0e6e2d@huawei.com>
From:   Marc Zyngier <marc.zyngier@arm.com>
Openpgp: preference=signencrypt
Autocrypt: addr=marc.zyngier@arm.com; prefer-encrypt=mutual; keydata=
 xsFNBE6Jf0UBEADLCxpix34Ch3kQKA9SNlVQroj9aHAEzzl0+V8jrvT9a9GkK+FjBOIQz4KE
 g+3p+lqgJH4NfwPm9H5I5e3wa+Scz9wAqWLTT772Rqb6hf6kx0kKd0P2jGv79qXSmwru28vJ
 t9NNsmIhEYwS5eTfCbsZZDCnR31J6qxozsDHpCGLHlYym/VbC199Uq/pN5gH+5JHZyhyZiNW
 ozUCjMqC4eNW42nYVKZQfbj/k4W9xFfudFaFEhAf/Vb1r6F05eBP1uopuzNkAN7vqS8XcgQH
 qXI357YC4ToCbmqLue4HK9+2mtf7MTdHZYGZ939OfTlOGuxFW+bhtPQzsHiW7eNe0ew0+LaL
 3wdNzT5abPBscqXWVGsZWCAzBmrZato+Pd2bSCDPLInZV0j+rjt7MWiSxEAEowue3IcZA++7
 ifTDIscQdpeKT8hcL+9eHLgoSDH62SlubO/y8bB1hV8JjLW/jQpLnae0oz25h39ij4ijcp8N
 t5slf5DNRi1NLz5+iaaLg4gaM3ywVK2VEKdBTg+JTg3dfrb3DH7ctTQquyKun9IVY8AsxMc6
 lxl4HxrpLX7HgF10685GG5fFla7R1RUnW5svgQhz6YVU33yJjk5lIIrrxKI/wLlhn066mtu1
 DoD9TEAjwOmpa6ofV6rHeBPehUwMZEsLqlKfLsl0PpsJwov8TQARAQABzSNNYXJjIFp5bmdp
 ZXIgPG1hcmMuenluZ2llckBhcm0uY29tPsLBewQTAQIAJQIbAwYLCQgHAwIGFQgCCQoLBBYC
 AwECHgECF4AFAk6NvYYCGQEACgkQI9DQutE9ekObww/+NcUATWXOcnoPflpYG43GZ0XjQLng
 LQFjBZL+CJV5+1XMDfz4ATH37cR+8gMO1UwmWPv5tOMKLHhw6uLxGG4upPAm0qxjRA/SE3LC
 22kBjWiSMrkQgv5FDcwdhAcj8A+gKgcXBeyXsGBXLjo5UQOGvPTQXcqNXB9A3ZZN9vS6QUYN
 TXFjnUnzCJd+PVI/4jORz9EUVw1q/+kZgmA8/GhfPH3xNetTGLyJCJcQ86acom2liLZZX4+1
 6Hda2x3hxpoQo7pTu+XA2YC4XyUstNDYIsE4F4NVHGi88a3N8yWE+Z7cBI2HjGvpfNxZnmKX
 6bws6RQ4LHDPhy0yzWFowJXGTqM/e79c1UeqOVxKGFF3VhJJu1nMlh+5hnW4glXOoy/WmDEM
 UMbl9KbJUfo+GgIQGMp8mwgW0vK4HrSmevlDeMcrLdfbbFbcZLNeFFBn6KqxFZaTd+LpylIH
 bOPN6fy1Dxf7UZscogYw5Pt0JscgpciuO3DAZo3eXz6ffj2NrWchnbj+SpPBiH4srfFmHY+Y
 LBemIIOmSqIsjoSRjNEZeEObkshDVG5NncJzbAQY+V3Q3yo9og/8ZiaulVWDbcpKyUpzt7pv
 cdnY3baDE8ate/cymFP5jGJK++QCeA6u6JzBp7HnKbngqWa6g8qDSjPXBPCLmmRWbc5j0lvA
 6ilrF8nOwU0ETol/RQEQAM/2pdLYCWmf3rtIiP8Wj5NwyjSL6/UrChXtoX9wlY8a4h3EX6E3
 64snIJVMLbyr4bwdmPKULlny7T/R8dx/mCOWu/DztrVNQiXWOTKJnd/2iQblBT+W5W8ep/nS
 w3qUIckKwKdplQtzSKeE+PJ+GMS+DoNDDkcrVjUnsoCEr0aK3cO6g5hLGu8IBbC1CJYSpple
 VVb/sADnWF3SfUvJ/l4K8Uk4B4+X90KpA7U9MhvDTCy5mJGaTsFqDLpnqp/yqaT2P7kyMG2E
 w+eqtVIqwwweZA0S+tuqput5xdNAcsj2PugVx9tlw/LJo39nh8NrMxAhv5aQ+JJ2I8UTiHLX
 QvoC0Yc/jZX/JRB5r4x4IhK34Mv5TiH/gFfZbwxd287Y1jOaD9lhnke1SX5MXF7eCT3cgyB+
 hgSu42w+2xYl3+rzIhQqxXhaP232t/b3ilJO00ZZ19d4KICGcakeiL6ZBtD8TrtkRiewI3v0
 o8rUBWtjcDRgg3tWx/PcJvZnw1twbmRdaNvsvnlapD2Y9Js3woRLIjSAGOijwzFXSJyC2HU1
 AAuR9uo4/QkeIrQVHIxP7TJZdJ9sGEWdeGPzzPlKLHwIX2HzfbdtPejPSXm5LJ026qdtJHgz
 BAb3NygZG6BH6EC1NPDQ6O53EXorXS1tsSAgp5ZDSFEBklpRVT3E0NrDABEBAAHCwV8EGAEC
 AAkFAk6Jf0UCGwwACgkQI9DQutE9ekMLBQ//U+Mt9DtFpzMCIHFPE9nNlsCm75j22lNiw6mX
 mx3cUA3pl+uRGQr/zQC5inQNtjFUmwGkHqrAw+SmG5gsgnM4pSdYvraWaCWOZCQCx1lpaCOl
 MotrNcwMJTJLQGc4BjJyOeSH59HQDitKfKMu/yjRhzT8CXhys6R0kYMrEN0tbe1cFOJkxSbV
 0GgRTDF4PKyLT+RncoKxQe8lGxuk5614aRpBQa0LPafkirwqkUtxsPnarkPUEfkBlnIhAR8L
 kmneYLu0AvbWjfJCUH7qfpyS/FRrQCoBq9QIEcf2v1f0AIpA27f9KCEv5MZSHXGCdNcbjKw1
 39YxYZhmXaHFKDSZIC29YhQJeXWlfDEDq6nIhvurZy3mSh2OMQgaIoFexPCsBBOclH8QUtMk
 a3jW/qYyrV+qUq9Wf3SKPrXf7B3xB332jFCETbyZQXqmowV+2b3rJFRWn5hK5B+xwvuxKyGq
 qDOGjof2dKl2zBIxbFgOclV7wqCVkhxSJi/QaOj2zBqSNPXga5DWtX3ekRnJLa1+ijXxmdjz
 hApihi08gwvP5G9fNGKQyRETePEtEAWt0b7dOqMzYBYGRVr7uS4uT6WP7fzOwAJC4lU7ZYWZ
 yVshCa0IvTtp1085RtT3qhh9mobkcZ+7cQOY+Tx2RGXS9WeOh2jZjdoWUv6CevXNQyOUXMM=
Organization: ARM Ltd
Message-ID: <61079d3d-6bb6-cd00-fbfa-d13c19706e0f@arm.com>
Date:   Tue, 20 Nov 2018 17:37:37 +0000
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <2665ddbd-5912-12b9-f5bd-6ccaec0e6e2d@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 20/11/2018 17:30, John Garry wrote:
> On 20/11/2018 16:23, Jan Glauber wrote:
>> Hi Marc,
>>
>> with 4.20-rc3 I see two WARN_ON's firing on a ThunderX2 system that come from
>> commit 3fb68faee867 (irqchip/gic-v3-its: Register LPI tables with EFI config table).
>>
>> Global efi_memreserve_root is NULL as it will only be set when early initcalls are
>> running, but from the backtrace the WARN_ON's are running even earlier (init_IRQ).
>>
>> Am I the only one seeing this?
>>
> 
> I see it also:
> 
> [    0.000000] Booting Linux on physical CPU 0x0000010000 [0x410fd082]
> [    0.000000] Linux version 4.20.0-rc3 
> (johnpgarry@johnpgarry-ThinkCentre-M93p) (gcc version 7.3.1 20180425 
> [linaro-7.3-2018.05-rc1 revision 
> 38aec9a676236eaa42ca03ccb3a6c1dd0182c29f] (Linaro GCC 7.3-2018.05-rc1)) 
> #971 SMP PREEMPT Tue Nov 20 17:15:03 GMT 2018
> [    0.000000] efi: Getting EFI parameters from FDT:
> [    0.000000] efi: EFI v2.60 by EDK II
> [    0.000000] efi:  SMBIOS=0x3f050000  SMBIOS 3.0=0x39b00000 
> ACPI=0x39bd0000  ACPI 2.0=
> 
> ...
> 
> 
> [    0.000000] ITS@0x00000408c6000000: allocated 65536 Virtual CPUs 
> @1fb9d80000 (flat, esz 8, psz 4K, shr 1)
> [    0.000000] ITS@0x00000408c6000000: allocated 512 Interrupt 
> Collections @1fbb977000 (flat, esz 8, psz 4K, shr 1)
> [    0.000000] WARNING: CPU: 0 PID: 0 at 
> drivers/irqchip/irq-gic-v3-its.c:1696 its_init+0x360/0x5f4
> [    0.000000] Modules linked in:
> [    0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.20.0-rc3 #971
> [    0.000000] pstate: 00000085 (nzcv daIf -PAN -UAO)
> [    0.000000] pc : its_init+0x360/0x5f4
> [    0.000000] lr : its_init+0x35c/0x5f4
> [    0.000000] sp : ffff000009183ca0
> [    0.000000] x29: ffff000009183ca0 x28: ffff7dfffe67b3e4
> [    0.000000] x27: 0000000000000001 x26: ffff801fbb928000
> [    0.000000] x25: ffff000009325360 x24: ffff00000918c8c8
> [    0.000000] x23: ffff801fbb802100 x22: ffff00000918c8c8
> [    0.000000] x21: ffff000009189000 x20: ffff0000091b8000
> [    0.000000] x19: ffff000009325000 x18: ffffffffffffffff
> [    0.000000] x17: 0000000001f4d3b5 x16: 0000000000000000
> [    0.000000] x15: ffff0000091896c8 x14: ffff801fbb97389b
> [    0.000000] x13: ffff801fbb97389a x12: 2074707572726574
> [    0.000000] x11: ffff000009183a00 x10: ffff000009183a00
> [    0.000000] x9 : ffff7e007eeed400 x8 : ffff801fbbb60000
> [    0.000000] x7 : a2a2a2a2a2a2a2a2 x6 : 0000801ff2d1c000
> [    0.000000] x5 : ffff7e0000000000 x4 : ffff00000918c8c8
> [    0.000000] x3 : ffff801fbbb50000 x2 : 0000000000000000
> [    0.000000] x1 : 0000000000010000 x0 : 00000000ffffffed
> [    0.000000] Call trace:
> [    0.000000]  its_init+0x360/0x5f4
> [    0.000000]  gic_init_bases+0x2d4/0x2f4
> [    0.000000]  gic_acpi_init+0x154/0x278
> [    0.000000]  acpi_match_madt+0x44/0x78
> [    0.000000]  acpi_table_parse_entries_array+0x13c/0x214
> [    0.000000]  acpi_table_parse_entries+0x40/0x60
> [    0.000000]  acpi_table_parse_madt+0x24/0x2c
> [    0.000000]  __acpi_probe_device_table+0x80/0xdc
> [    0.000000]  irqchip_init+0x30/0x38
> [    0.000000]  init_IRQ+0xfc/0x130
> [    0.000000]  start_kernel+0x288/0x418
> [    0.000000] ---[ end trace c841ef100bdd09a6 ]---

Yes, anyone with GICv3 and EFI will see this.

	M.
-- 
Jazz is not dead. It just smells funny...