Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1030457imu; Tue, 20 Nov 2018 10:29:38 -0800 (PST) X-Google-Smtp-Source: AFSGD/Xi7qgvaIejirQml6m33bIeoaS30AF925qBtmtL/uNCytk6GWgf+SZTsdD0+YYZSBblQ3Hb X-Received: by 2002:a63:ef0b:: with SMTP id u11-v6mr2887377pgh.283.1542738578675; Tue, 20 Nov 2018 10:29:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542738578; cv=none; d=google.com; s=arc-20160816; b=vVG5ZPOqtATNHWXhkP0jiU7mWvSpjX1uw6p/u39CfT/95l+16Y86FMoVjZ1ZcrS/jK e1ibi0UKla/voxLpQF8t2K6hV1zx9epTzdyEQTQc3RaUC/qptaZyLr4cC6h29NcQHB3T yqYubSSRU0asILlghVk0kNHKeUzOFnK5dCvdNhdksbEPPoAjI+3eVuPhd0kVoJ02Cy5K 5KZUDNPg+9XvsIUF2/DCobp44Hz8gKO33V/S2V6pNi/LelIaGbHHzmSrbfAcilsFHntw qBPyjTPYZf4CCWIzdteJ7++olOeXp3/cIgX9K/3D7rkYAac/2nxuF7txALHdohnm51EB DXpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=CuWi++sTutTfogtyA+bVFPU0FhnDRY03GA60W1Fm/Y8=; b=NWsFurXzbX6LM2Z2vrfgdYyVD9Z3NPL9V5E4fVtZ7VsNR4epkuLazQzsWx2Kkkt6vM CnnzatwRINjwmeDGh0tsBQTcFY95xTu396aYTc3WTSeGktbrYrI8+sj3uzMUQtHwSLGm OaJ038YGnElq7xkPx+ADJ2E0HXOyACHvMXCmG+8aSMW/hSf4yZU0OZt+y6Gpt05YosEm uq0Z2cBubXCF46NEUlqW5hRAq4Sla4ojAVn5TPOb35rnna9l5fTMe+IZ6hFcsS03xtfc AYrWJHtM2DzIj+ieq+pEAuyFwzBQAKVgPNrHQ3u8vRb+xm06XnlWUJygam6caMScbyng 7FRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4si4949122pfm.85.2018.11.20.10.29.23; Tue, 20 Nov 2018 10:29:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbeKUE7P (ORCPT + 99 others); Tue, 20 Nov 2018 23:59:15 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:44698 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725926AbeKUE7O (ORCPT ); Tue, 20 Nov 2018 23:59:14 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 36B9D148BD7E3; Tue, 20 Nov 2018 10:28:44 -0800 (PST) Date: Tue, 20 Nov 2018 10:28:43 -0800 (PST) Message-Id: <20181120.102843.2033247081781930217.davem@davemloft.net> To: vincentc@andestech.com Cc: gregkh@linuxfoundation.org, rdunlap@infradead.org, yuehaibing@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts From: David Miller In-Reply-To: <1542692266-17720-1-git-send-email-vincentc@andestech.com> References: <1542692266-17720-1-git-send-email-vincentc@andestech.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Nov 2018 10:28:44 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org aFrom: Vincent Chen Date: Tue, 20 Nov 2018 13:37:46 +0800 > + /* Disable interrupts for polling */ > + ftmac100_disable_all_int(priv); > if (likely(netif_running(netdev))) { > - /* Disable interrupts for polling */ > - ftmac100_disable_all_int(priv); > napi_schedule(&priv->napi); > } This is now a single-line basic block, so please remove the curly braces. Thank you.