Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1088556imu; Tue, 20 Nov 2018 11:29:26 -0800 (PST) X-Google-Smtp-Source: AJdET5dVXvxi0WNa9Mh7pcsB7osFrLD7AOCDyaYG9smnMCR3skmWkMJh23HfmwPHYi+xgvKlT6LS X-Received: by 2002:a62:670f:: with SMTP id b15mr3494798pfc.212.1542742166452; Tue, 20 Nov 2018 11:29:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542742166; cv=none; d=google.com; s=arc-20160816; b=IEDP4C0x+/f3nwEN8/twsXBSG0EtlPW7A6fiqjoWY1WOYNiKpSKC3KLxXZ4dgzQXwg 60z1tMotPfdxKhYMLhbdmL/s1CxqJCr2JTLRd1mg2zEJsnLAn2FWmv6bVKmtDwD8VD07 VKCluB8oFadix/M7qjrJKKcspWf6Sl47+tGpx2w28g7K6LtgMt/dK69snqk+UJDwIsqR bQaNFnVkUGSb6heNUaUwy2wp7VuLDPP8RFbW5Zggns6bHjeT86NCvb/wQlQwARNqI2jQ HZZO4Q1Vh6UloGEIa7FDt4Q0qPKOqJzmmZY+JHeFPgIWkCJ9PY6m/l6JBh9JwwLh0gFg SYpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jdS2Sdu/yFhH1LL1OwIuLdKpJ2CmEgtb+qzNiSlaKHc=; b=d+CVeEBEj85ANsSpE+ZN4bERRkLNX1zMCNaA9k934O17S2kdCPi+pRIrSOtPg+tLVS eR1QoBKFiiI/CPvQVdbAGkDuWCwkmv8GWzQ6EkPhyF+vBJyWEIq2Enb+KPe7WRQFvVp8 J9U3Nfh43U3OKzzcdkLp67MiOB2/ipP5OhgkDv+fgGNX0CPXl/j+5my9hRsUBe03E29p JRbPHESDCSZ4Xjdcd8X+eZBWfHvrNjBQ/lhfNAeu9BTSqWUMspswb8ojltmvA16WF124 f/ngCimCJ85DqSt5bc5ovGnUVgSGMwG21tuMOYXEQvLXHgPxXJPs1BxUutKfE/XtauaU RQZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CPNHLAd2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cd2si16111546plb.39.2018.11.20.11.29.10; Tue, 20 Nov 2018 11:29:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CPNHLAd2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728990AbeKUCtl (ORCPT + 99 others); Tue, 20 Nov 2018 21:49:41 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:34586 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbeKUCtl (ORCPT ); Tue, 20 Nov 2018 21:49:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jdS2Sdu/yFhH1LL1OwIuLdKpJ2CmEgtb+qzNiSlaKHc=; b=CPNHLAd206Nzj49fUmRDUXApw M/rFPrfmbprNwUF2MUr92v+fuU60OCx9TZO6HynVha5NLrgSD342ltpZD5JeIZlJFojzllqYee2xn 2gYa+v1isf7e9YA7oK3uP/3rkRdNLVuRUyJtn6sQCQA1AJbJEFnN5jEDfpsVKWpgxdz0dkLGBVCs2 zCyEDJd/ojVP5uxOaGilF76zqC/RVHELaF6uMhmbZjimfn+YlSjE3hdQ90TxblOTrz/JzGfega/gU M51Og6aijik2Z/ZUty3E8J18CXP7Xu766KRegi3DsbbkxrbcTYUa7XSwCS9/ytD1C2XdobUrpEzeE T5d8n5l/g==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gP8kW-0003Qg-H3; Tue, 20 Nov 2018 16:19:40 +0000 Date: Tue, 20 Nov 2018 08:19:40 -0800 From: Christoph Hellwig To: John Garry Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/4] scsi: Add scsi_prot_op_normal() Message-ID: <20181120161940.GA10454@infradead.org> References: <1542725944-244183-1-git-send-email-john.garry@huawei.com> <1542725944-244183-2-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1542725944-244183-2-git-send-email-john.garry@huawei.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static inline bool scsi_prot_op_normal(struct scsi_cmnd *scmd) > +{ > + return scmd->prot_op == SCSI_PROT_NORMAL; > +} This "wrapper" just obsfucates the check being performed, please drop it.