Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1179429imu; Tue, 20 Nov 2018 13:03:31 -0800 (PST) X-Google-Smtp-Source: AFSGD/VIXb/mS7X+VTF94t9UOgIzCPp6eI9aEADTYaSO7shQ/cR/OFPJWZexm+lksYhZwWgcRPnf X-Received: by 2002:a63:9041:: with SMTP id a62mr3286202pge.163.1542747811358; Tue, 20 Nov 2018 13:03:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542747811; cv=none; d=google.com; s=arc-20160816; b=ismlf99uhQ26GfvEpDO/iE55xQw9iO3VKSTXEV3BwBOPSXpK4Sx8X8t1iHIFrkkDa9 Tmepba0X+opD+tUT1xOAph/81H4vrf1H0Isj8W/k0OTFFg6T67ej9DIM7/79XmvZ98Y2 6z783pjyk/rOsSIIin7vgc3GNbGEudtDRO8+Jq5AuPH7jBbbtljLC7q/vP1QF20TvK4V 5ySp9gJJNNaFD+mzoPAuzwNsat8bzEnDTzTfC5vy6QrN3WgfixXKRfqil0jzJLgqa5xz rqAstoHbpvr/4IKGtYyWLgov57BQPPiinZI9ZqQQxXtnQcFK+9ekEqnJjxSrzokOAXvg usrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Em/CJpRlqp1QVgNc3ZOgVTSUYmuIU8UpC5I+oNQ+QrA=; b=GOkS8QJJBfJE25hhxLoohBMGvzKsf4eeiWeXVGBxYEd16byNLsouC6pQNSFAg/m2L/ SCyP8ctbwj/9w9Ng4fI4qs9VwRgJYV/cWRTOVyOsBiihpts2fiYVRZTZlr7s+v6YmLJu qC7sQVHcPaWlJh6bpQZZpyfICZTHYCbnZHeLEZrXUbEIR672Yf/3j4BY6rxRGZ61Rffo e0p5XYMD0Jdxm9PaqrbylrC5jXrBvJdq8Rvh54na4Xy2o9ToYWissUUg6oxWp3CXPdiV Cnoc4emYvlM8IojGGl9ERh2JU1Kp/7+cjHnzw3mU+WQX8evhtb8hCTMLrSOkB7grQ1ZQ PPog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="ZFE/gKuH"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s13si21259805pgh.583.2018.11.20.13.03.13; Tue, 20 Nov 2018 13:03:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="ZFE/gKuH"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbeKUGAa (ORCPT + 99 others); Wed, 21 Nov 2018 01:00:30 -0500 Received: from mail.skyhub.de ([5.9.137.197]:59756 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbeKUGAa (ORCPT ); Wed, 21 Nov 2018 01:00:30 -0500 Received: from zn.tnic (p200300EC2BD1FF00883B4D3E2A7F8FA4.dip0.t-ipconnect.de [IPv6:2003:ec:2bd1:ff00:883b:4d3e:2a7f:8fa4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7E01C1EC0725; Tue, 20 Nov 2018 20:29:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1542742184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Em/CJpRlqp1QVgNc3ZOgVTSUYmuIU8UpC5I+oNQ+QrA=; b=ZFE/gKuHracTp3n9l9RXPbpQJNuxmP0r3auloiqwhFq05QZAnkLROoZ3bkwhsZhFgpoxhn 0SGUVVx3FO+/W2K80wDiyouCPebaVbpxv3EeryT57aJ5jKUQfoVUsZI01v4wBa1g60Uh8+ by5zxGHQ7yvdrP1fYiL7XehoXh/ZRHM= Date: Tue, 20 Nov 2018 20:29:35 +0100 From: Borislav Petkov To: lijiang Cc: Dave Young , Bjorn Helgaas , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, bhe@redhat.com Subject: Re: [PATCH 1/2 v6] x86/kexec_file: add e820 entry in case e820 type string matches to io resource name Message-ID: <20181120192935.GK2527@zn.tnic> References: <20181114072926.13312-1-lijiang@redhat.com> <20181114072926.13312-2-lijiang@redhat.com> <20181114112600.GD13926@zn.tnic> <9eb61523-7a08-24c4-ac15-050537bd9203@redhat.com> <20181115103959.GB26448@zn.tnic> <20181119095515.GC14045@dhcp-128-65.nay.redhat.com> <20181119102812.GA14688@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 20, 2018 at 11:37:26AM +0800, lijiang wrote: > BTW: Boris has mentioned the solution which adds the new descriptor 'IORES_DESC_RESERVED'. > > Which solution do you prefer? Add the new I/O resource descriptor 'IORES_DESC_RESERVED'(patch v7) > or exactly comparing a string(patch v6)? The new I/O descriptor of course - the string comparison thing is fragile and error-prone. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.