Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1296111imu; Tue, 20 Nov 2018 15:15:02 -0800 (PST) X-Google-Smtp-Source: AFSGD/VVy8eyJfYGQfDQzMPYyqG3HVgLAG7IqFF6O6YjYcBZDociJ5lYXY/pmO8otk6MKEMc+p17 X-Received: by 2002:a17:902:24e7:: with SMTP id l36-v6mr4242670plg.243.1542755702381; Tue, 20 Nov 2018 15:15:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542755702; cv=none; d=google.com; s=arc-20160816; b=GqCCQWKFP9wKm8c4n7jUwPAfkPcjBOCURpdxr8LcDjug4H7U6hG1WIZiBUoHoq0e9d /bFr7DWFz8XW6dDEncxmJQUlMMefBOKjjPXModIyv6v3V13IPQ/5s5JjCYxmxd54EECE fyX2fnvsx+cZ3nfduK7DwMcGkuQn6+svdHk2Xj4ha2Oy930UJZQ4IwnSMy3XLaPMx37K N7FlfooPytxsKhad2uYcbgnm7Hs8/yIqCTHSzA/nPUqRahFzp7cwg+iviCXKGIV4Vg1h 8EyH5t9m8Y/sWW1IaKFOS21c7XSDGkqMUWI3xxHs+QRQyJ7xOCA0oSkONSgPEGiAKhB8 a+2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=xOrAnhJWz15784yO4PS0RtQpDz5+Y0GKSZRMr/JnYHk=; b=n6fG/3npFX0GHX/MJAhTeIThBGCS+Wed+aFSISUp/RzotQ6fsTSsMwxEe3hIEI3nEq 5lObxAUQgfODAv8hIJaqzDSpfBPkmqlIqogPPRTLn1Sv/W9dbsgbYvbPytSZMLsdQj6G tyUp8QNPSbdiLrYPV9OxNXBQdmnYkSS17wI3f1uCrP2KlRBfBcgTEU2hdtmyEhniMyZt 5trIGrMCp8VTfzvu57JChiS50vLSUmUooplNapQ5x6QUCUZMPAFzACq9bEE3F+k3RjeA U8wXax1rIGfIsyOERfNjQb66QxNV4vYbWbZgZXhmecjSSXVojHcmAVeHLoGwQ6vPWpxb UBiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p19si32965327pgj.375.2018.11.20.15.14.47; Tue, 20 Nov 2018 15:15:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbeKUJpi (ORCPT + 99 others); Wed, 21 Nov 2018 04:45:38 -0500 Received: from mga14.intel.com ([192.55.52.115]:24185 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbeKUJpi (ORCPT ); Wed, 21 Nov 2018 04:45:38 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2018 15:13:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,258,1539673200"; d="scan'208";a="109963207" Received: from tstruk-mobl1.jf.intel.com ([10.7.196.53]) by orsmga001.jf.intel.com with ESMTP; 20 Nov 2018 15:13:59 -0800 Subject: Re: [PATCH v5] tpm: add support for partial reads To: Jarkko Sakkinen Cc: jgg@ziepe.ca, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org References: <154265371562.23494.10113870855345906523.stgit@tstruk-mobl1.jf.intel.com> <20181120124810.GB8813@linux.intel.com> <77b031b2-7fa2-f057-1e6a-70f0427ec6c4@intel.com> <20181120230759.GF8391@linux.intel.com> From: Tadeusz Struk Openpgp: preference=signencrypt Autocrypt: addr=tadeusz.struk@intel.com; prefer-encrypt=mutual; keydata= xsDiBEiLICMRBADteQacQxypsuFvAw6IwYzbD8pgQi+kLYBcqfGgVAUN/cO+sLl6u1lVdaDB fhAArdbV9lpoqcWnmhQFTb4A+W569EpydBr6nuatWkEB+fmmx8YoUtuZfXt7v+1l1rc09kaW LY+TkwQkvFCeuvdasgmBLnmRWymEGWi1E12hUgTw/wCgtK24geC7XkiuANMv0gpr+raOgQMD /2yJZ0SeXQApWyTRaeIYN8GgYHZTWuBp/ofN+viEkhrDxahcaGPP5B/Nv6VS1+M0e5m8OzHj qPUbgfyOeJcslC5aoZdqqqzVWVLaA/+Jy+O+6T3k3R/IryVVATldBlwnGFDhET0mKQsd15zt cIdQBBbfSFR5VlugZuWV5q442IpPA/4g7nen9FFPxh45Te8D54hAsOCywjm6xUE0UJGYHeJ/ MXCPtuXfVCbYcOxZVH7kUS2Vtk5d3bF40IE2WnVq1ZScNANF4ZjikxYhYGfNWX3HXak1gSoj UrY87rMSjPIAry4L0BoIx2qgL/k4iV/3QcXL4t5wosU0iw++suf1zGGcKM0gVGFkZXVzeiBT dHJ1ayA8dHN0cnVrQGdtYWlsLmNvbT7CYwQTEQIAIwIbAwYLCQgHAwIEFQIIAwQWAgMBAh4B AheABQJQTjJTAhkBAAoJEDFswfskq9xyqvcAoI2nsaUCX8ZGbu+Jhq+++qlBFJ2rAJ983RoO R2ofHhn3g3Qi4K34tw0l087BTQRauzUlARAAqkWRL/InEPnoGMg/gw/CRaDBaIBgMsvIcghI 7xevIzpleXt6jKHghSBooH+zaT7qi4u2gkgPn4odsER3Rm94XgrZJgoqls6EpKMWpJNGP4HT eYgykhfsZOLX8ijUbjTM/Sm/dZVo6aYoBL2+ciJwyl+Zt3Mp6un3/GWu6cA9005V50pRqO7j PTlVCHi2bedcEEf5DDsYJv/3Oz8/4LpSf6BL6BltjeZVa2y03dTMmD031JTH+OuyJm1yh72Z HWxhlYNXOv6uFJJVr+paQjrAsBVIYKhK24bD+uGJxLm8AN9i7/Si+2YeSsXvKUhk9mIoFBnU VFo63cziRTcpRu/kXgDAbujwN88qytEcvhEZHS6B9vdws+lhTpolEjkLCkz0Y59z4Fs9srKy QkRN+wtdiLgrwyDW3ryAKxcDmOumGWebDxpaOI/pBhrlS93HmDlvj7JmgTUU4a/NhwI3dXh5 pn8FZzZyVXe3Kc3bu5T3UAC7uztinsAvCJQS6jGZWrXmXkqYkaLXQOw61eInWjr01zE/zDbE mdJPM0+va/gtZx9TtGxr4PpjbqswqCiubLDZXZHh5uqArPv/i+E8aXIsNSTN6Rrqs1j9YgDN ALksibv6+tXH3sOlCUgjuZgJH3+s/mnaAtiV2rZ/WlH15d6nd0uiDSZrKhlR+g4NHMh1ztEA EQEAAcJPBBgRAgAPBQJauzUlAhsMBQkJZgGAAAoJEDFswfskq9xyfv8AoI8aPrJCoM0h5WOP kKxMmPEPHzUNAJ9jBBYXhX1CWg+IhI7i/fLlI0vwCA== Message-ID: Date: Tue, 20 Nov 2018 15:13:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181120230759.GF8391@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/18 3:07 PM, Jarkko Sakkinen wrote: >>>> + /* Holds the resul of the last successful call to tpm_transmit() */ >>> This comment is cruft. >> Do you want me to remove it? This is the comment you proposed. > As I explained before it made sense before you made the remark that > it can only get positive values i.e. the length. > So what do you want me to do with this one? -- Tadeusz