Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <f3548de1f5204165748c92314fbd24a10e47b8c5.camel@perches.com>
Subject: Re: [PATCH v3] debugobjects: scale the static pool size
From:   Joe Perches <joe@perches.com>
To:     Qian Cai <cai@gmx.us>, Waiman Long <longman@redhat.com>
Cc:     tglx@linutronix.de, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com,
        arnd@arndb.de
Date:   Tue, 20 Nov 2018 15:58:59 -0800
In-Reply-To: <trinity-ce6c61be-cc03-4a9d-8f26-562694d048da-1542758061535@msvc-mesg-gmx023>
References: <20181120201432.2163-1-cai@gmx.us>
         <20181120232810.2503-1-cai@gmx.us>
         <e286be8a-7f0a-65ab-0275-15abcd33eb07@redhat.com>
         <trinity-ce6c61be-cc03-4a9d-8f26-562694d048da-1542758061535@msvc-mesg-gmx023>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2018-11-21 at 00:54 +0100, Qian Cai wrote:
> On 11/20/18 at 6:38 PM, Waiman Long wrote:
> > On 11/20/2018 06:28 PM, Qian Cai wrote:
> > > The current value of the early boot static pool size is not big enough
> > > for systems with large number of CPUs with timer or/and workqueue
> > > objects selected. As the results, systems have 60+ CPUs with both timer
> > > and workqueue objects enabled could trigger "ODEBUG: Out of memory.
> > > ODEBUG disabled". Hence, fixed it by computing it according to
> > > CONFIG_NR_CPUS and CONFIG_DEBUG_OBJECTS_* options.
[]
> > > +#define ODEBUG_POOL_SIZE	(ODEBUG_DEFAULT_POOL + CONFIG_NR_CPUS * \
> > > +(ODEBUG_TIMERS_PCPU_CNT + ODEBUG_WORK_PCPU_CNT))
> > 
> > Just a nit about indentation. There should be some indentation in the
> > continued line.
> 
> I am fine to add that, but checkpatch.pl complained
> that there should no spaces at the beginning of a
> newline. Guess we just ignore the warning?
> 
> “please, no spaces at the start of a line”

It wants tabs '0x09' and not spaces '0x20'