Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Nov 2018 08:49:03 +0800
From:   Vincent Chen <vincentc@andestech.com>
To:     David Miller <davem@davemloft.net>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "yuehaibing@huawei.com" <yuehaibing@huawei.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: faraday: ftmac100: remove netif_running(netdev)
 check before disabling interrupts
Message-ID: <20181121004903.GA28845@andestech.com>
References: <1542692266-17720-1-git-send-email-vincentc@andestech.com>
 <20181120.102843.2033247081781930217.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20181120.102843.2033247081781930217.davem@davemloft.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 21, 2018 at 02:28:43AM +0800, David Miller wrote:
> aFrom: Vincent Chen <vincentc@andestech.com>
> Date: Tue, 20 Nov 2018 13:37:46 +0800
> 
> > +	/* Disable interrupts for polling */
> > +	ftmac100_disable_all_int(priv);
> >  	if (likely(netif_running(netdev))) {
> > -		/* Disable interrupts for polling */
> > -		ftmac100_disable_all_int(priv);
> >  		napi_schedule(&priv->napi);
> >  	}
> 
> This is now a single-line basic block, so please remove the curly
> braces.
> 
> Thank you.

OK. I will remove it.
Thank you.