Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1562684imu; Tue, 20 Nov 2018 21:13:53 -0800 (PST) X-Google-Smtp-Source: AFSGD/X8OWHAHG7DMmiSs1DSNPRmSDZl3t5d3AarfpVY4qxhcMEl8qnSZE72W7rFuplBSovTzaam X-Received: by 2002:a63:1904:: with SMTP id z4mr4506998pgl.135.1542777233901; Tue, 20 Nov 2018 21:13:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542777233; cv=none; d=google.com; s=arc-20160816; b=bwfQvvOoZyi07e2S7Q5zVrb+ba6YRlVoGfewDRpttBONFSbTwppuqiVMDlL7u0Z2oY JlGG6FfNB4ncP0v05NBH8ftyeC9UU/K7LFk8/+VlQL6kYBhUIgw38RUIcXT64x9nNCRE fPWKQFNlmtFwQBbl8VHKMhUmi5ondg1dfBQMhRkyJuL9nJhESziy9gRZm4+mCnEZiBrn e7drB2ixvJdclAUw/cTQJceY/uHzBODV28b7XHp0owaZgn9n+2ppu47iouHWeweJZaOH LmHPB5MNdzHktXt9tEXNllLoFZSvFRMyVpR/yz4d9Wg0cqPDDtcbJl+OwLpHMZjgtaBv WuVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=ObcDvYuCvCRY854lGNth8zzfyqEUvVBRMF/Qt74EXuE=; b=GPzCkfkWShWaJlQIL+jLZAhvuBA8Y9qzA9kljWyAOg7k5dMeLHnxoa9IYJG7n55fQi r1A9ch9U3tIz7FnNGCGr4kbpBaCk9IN0B4MuQ5zQEK6xt/oGNy+ojZGKY6nFW6ky9Kjs HwEr7SVw8+aB0infNls7m+a8EuZX13Dgc3kWZcbEcw2sJcgjIKm7FJQYA+/P84tnR+0F nsm5N07WCYfK4jpmJqdcnd5lbPTdS+D7d3JtKGWkhOGr0HlDd9Jn7/i4C8IsEZ9Fwjad cq9X6bFm9rv61/TAnJQ5ANHLmjwUSYJANKhjJXtAnz0ABgXwhgR5rgFw9nh4J4+RLZqf Rvhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="KYUv/rCE"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q15si46034436pgm.420.2018.11.20.21.13.37; Tue, 20 Nov 2018 21:13:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="KYUv/rCE"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727098AbeKUPYp (ORCPT + 99 others); Wed, 21 Nov 2018 10:24:45 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:34580 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbeKUPYp (ORCPT ); Wed, 21 Nov 2018 10:24:45 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAL4nMqs032244; Wed, 21 Nov 2018 04:51:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2018-07-02; bh=ObcDvYuCvCRY854lGNth8zzfyqEUvVBRMF/Qt74EXuE=; b=KYUv/rCE/lT+oc+6eV3gucNcZHOeI3d0yFGKUrSOtHxcLZGq+9ibWqZ19it0q2hXyPkD qd0fA2rAKTW2dDpijvMP3FEq5JiZA81qH+niJCYoY+DONuchuL3K8rZ5YM1eXtaWgS9X p8ACNP4Q+GghzoQgRIwtQyaZ5FkNvsRtUXMdL5VYqL2P7JZl7qP3xsCsqCcj/U3fPZrE fhgDzaEKCnxzwJkEcUJjEZQR5LCHQx2mwMnCRy4aIfkggDwbcZTkm0hg/o6r+ubeKtEb luHD6oacE2q10FNMFfg6QkbF4LdOr9tsi8tyKEGVkmg8qvSZgbxliFq5omN0Ek+RRjUP VA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2ntadtydgj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Nov 2018 04:51:49 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wAL4pg56026719 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Nov 2018 04:51:43 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAL4pf8x018611; Wed, 21 Nov 2018 04:51:41 GMT Received: from [192.168.0.110] (/73.243.10.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 20 Nov 2018 20:51:40 -0800 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page From: William Kucharski In-Reply-To: <20181120141207.GK22247@dhcp22.suse.cz> Date: Tue, 20 Nov 2018 21:51:39 -0700 Cc: "Kirill A. Shutemov" , Linux-MM , Andrew Morton , Oscar Salvador , Pavel Tatashin , David Hildenbrand , LKML Content-Transfer-Encoding: 7bit Message-Id: <29F15A96-D6EB-450E-B54B-A4CB460ED9B3@oracle.com> References: <20181120134323.13007-1-mhocko@kernel.org> <20181120134323.13007-4-mhocko@kernel.org> <20181120140715.mouc7okin3ht5krr@kshutemo-mobl1> <20181120141207.GK22247@dhcp22.suse.cz> To: Michal Hocko X-Mailer: Apple Mail (2.3445.102.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9083 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=663 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811210044 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Nov 20, 2018, at 7:12 AM, Michal Hocko wrote: > > + /* > + * Check the locked pages before taking a reference to not > + * go in the way of migration. > + */ Could you make this a tiny bit more explanative, something like: + /* + * Check for a locked page first, as a speculative + * reference may adversely influence page migration. + */ Reviewed-by: William Kucharski