Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1627227imu; Tue, 20 Nov 2018 22:38:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/UGnuL5qhQUV9ksghc2dKzJVT8AExtY+sz6QGdt0hg+dAu8EBgFAQZizAFmXij9DCjDIXzK X-Received: by 2002:a17:902:8507:: with SMTP id bj7-v6mr5400047plb.99.1542782307764; Tue, 20 Nov 2018 22:38:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542782307; cv=none; d=google.com; s=arc-20160816; b=w7aFS7eS3xvBcDgrEC6qML5NREeNfOFlqgW/aZplmU6zPZkSb8/BjBICuoAMWieNii Iw6MVvw+Zytkdr5MtgZJ76BT6Our4FF2G/OJ9urJb+cxOpFlAdo+/o4l5WBteAG9OjgN 1T7rAnfthe4jXdi+j5s7Eo3aQRREHcT4ORkXEOGcDs/1HCryixRsmW/Od/OPf5bW+Kq7 8LlILhNpdsNeIqLVUnrlUs/r0RIsfVLPB0j6rfvkXy8+cNeOV7lueSz2nR06OCcao0lV X4ixkgL/iLb5W9R00SHAAGiJOTR3MeTEkO6JXUrSIuTagNnlZWPlEU+pMMu9yyWnnNJL 1Qbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=YkCGkxzpDfjW+OP4B45NyIRv2+jWK/j+fejmr3EN9o4=; b=ZKjFsR/IRLUWpfX5zNL4fe9LOpjgnuWtzRHSsMgkvHZdxLIg62DH8VZSZXDZ9EhIw1 EVNXyw5/k/XPTR46xviefr8wn6cuwfOPcLvyoUKqv+706ngZV/+98AI073cvz1NcKVec Z0IMV7OI7ogVuWj2vC7Z7qPaTA+K17vLqvLjf1UO6Pqca69N6epMR6sM7JjhOa/FYfWe k5aB8D+b8LBkcZMRgWzi6ZpMwhWthz/ujV3vfydNPAVSSHVfZQquq+dYEtTxxUgdwSNb T6TVYg438S6JYdAaI+r+DyZ6kcVOGUF6ge5TpsqWAFMRNRW+DW6cYLl+rx+P4kbYJFJy Lwtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Ho+G9Vdt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si46772295pgz.180.2018.11.20.22.38.12; Tue, 20 Nov 2018 22:38:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Ho+G9Vdt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbeKURJ1 (ORCPT + 99 others); Wed, 21 Nov 2018 12:09:27 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:4603 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727188AbeKURJ0 (ORCPT ); Wed, 21 Nov 2018 12:09:26 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 20 Nov 2018 22:36:15 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 20 Nov 2018 22:36:15 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 20 Nov 2018 22:36:15 -0800 Received: from [10.19.225.182] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 21 Nov 2018 06:36:13 +0000 Subject: Re: [PATCH] thermal: tegra: add get_trend ops To: Thierry Reding CC: , , , , References: <1542705077-29697-1-git-send-email-wni@nvidia.com> <20181120153833.GB28796@ulmo> From: Wei Ni Message-ID: Date: Wed, 21 Nov 2018 14:36:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181120153833.GB28796@ulmo> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1542782175; bh=YkCGkxzpDfjW+OP4B45NyIRv2+jWK/j+fejmr3EN9o4=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=Ho+G9VdtjTpUyMmbEu8mTTuqq/DseKLERj68HvOiFs4/7KaetTS4CHTWeAVXK6PHs XT/0o4Igi7mQaIFvi0EflFHb3wuV71935Asy/wcgFq0UFBehJIJYR6R6jHBHBQ83SC HLLOIFuA2GkU0QM+dtg/+gtMO8ntNlpifP9cNvFCmTC1wmirsGadz6nE0GO5K5MtFb jXzbMHcBAMIdAVzPbiFtlaCwXlMOGzy/KhIiuTeFgYHYcVuTddiJnIf+0pHYwbDkAY djAd8wRDqHLzHC3dKXolRsLbcxpKNc+UZwTxRPxr4HO5BPg56k0O1W++SGJj5dwe4K R5NmLKZkKWXGQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/11/2018 11:38 PM, Thierry Reding wrote: > On Tue, Nov 20, 2018 at 05:11:17PM +0800, Wei Ni wrote: >> Add support for get_trend ops that allows soctherm >> sensors to be used with the step-wise governor. >> >> Signed-off-by: Wei Ni >> --- >> drivers/thermal/tegra/soctherm.c | 34 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c >> index ed28110a3535..d2951fbe2b7c 100644 >> --- a/drivers/thermal/tegra/soctherm.c >> +++ b/drivers/thermal/tegra/soctherm.c >> @@ -488,9 +488,43 @@ static int tegra_thermctl_set_trip_temp(void *data, int trip, int temp) >> return 0; >> } >> >> +static int tegra_thermctl_get_trend(void *data, int trip, >> + enum thermal_trend *trend) >> +{ >> + struct tegra_thermctl_zone *zone = data; >> + struct thermal_zone_device *tz = zone->tz; >> + int trip_temp, temp, last_temp, ret; >> + >> + if (!tz) >> + return -EINVAL; >> + >> + ret = tz->ops->get_trip_temp(zone->tz, trip, &trip_temp); >> + if (ret) >> + return ret; >> + >> + mutex_lock(&tz->lock); >> + temp = tz->temperature; >> + last_temp = tz->last_temperature; >> + mutex_unlock(&tz->lock); >> + >> + if (temp > trip_temp) { >> + if (temp >= last_temp) >> + *trend = THERMAL_TREND_RAISING; >> + else >> + *trend = THERMAL_TREND_STABLE; >> + } else if (temp < trip_temp) { >> + *trend = THERMAL_TREND_DROPPING; >> + } else { >> + *trend = THERMAL_TREND_STABLE; >> + } >> + >> + return 0; >> +} > > This looks like a reimplementation of the get_tz_trend() helper. Is > seems like that helper already has everything we need. Perhaps this > isn't working because of-thermal installs of_thermal_get_trend(), a > function that returns -EINVAL if the driver doesn't implement the > ->get_trend() callback. 1. The get_tz_trend() helper can work, because it has: if (tz->emul_temperature || !tz->ops->get_trend || tz->ops->get_trend(tz, trip, &trend)) { ... } the tz->ops->get_trend is of_thermal_get_trend(). If without special get_trend(), it will return -EINVAL, so it will implement the if block to get the "trend". If we have the special get_trend(), then the of_thermal_get_trend() will return 0, so this helper will not implement the if block, it will get the "trend" from the special get_trend(). 2. There has a little difference between the helper and our special callback. The tegra_thermctl_get_trend() consider the trip_temp, but the get_tz_trend() helper didn't. > > Perhaps a better way would be to do something like this in > thermal_zone_of_add_sensor(): > > if (ops->get_trend) > tzd->ops->get_trend = of_thermal_get_trend; > > That's similar to how ->set_trips() and ->set_emul_temp() are set up > and should make sure that get_tz_trend() will do the right thing for > all drivers that don't implement a special ->get_trend(). As above description, I think the of_thermal_get_trend() already can handle this case, doesn't need to change. Wei. > > Thierry >